enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard
verified publisher icon kubernetes

Enable per-request Read/Write Deadline

Open tkashem opened this issue 1 year ago • 7 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Enable per-request Read/Write deadline to remove timeout filter
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/4460-per-request-deadline
  • Discussion Link:
  • Primary contact (assignee): @tkashem
  • Responsible SIGs: sig-api-machinery
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.31
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4462
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/46858

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

tkashem avatar Jan 31 '24 00:01 tkashem

/sig api-machinery /cc @wojtek-t

tkashem avatar Jan 31 '24 00:01 tkashem

/label lead-opted-in /stage alpha /milestone v1.31

wojtek-t avatar Jun 07 '24 09:06 wojtek-t

Hello @tkashem 👋, 1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage alpha for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [X] KEP readme has up-to-date graduation criteria.
  • [X] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

  • Update issue description to add direct link to KEP README.md
    • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/4460-per-request-deadline/README.md
  • Update issue description to add the KEP update alpha PR as
    • KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4462
  • Ensure that this issue has an assignee.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

dipesh-rawat avatar Jun 07 '24 12:06 dipesh-rawat

Hello @tkashem :wave:, 1.31 Docs Lead here. Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release. Thank you!

Princesso avatar Jun 13 '24 07:06 Princesso

Hi @tkashem

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

hailkomputer avatar Jun 19 '24 11:06 hailkomputer

@tkashem , friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

hailkomputer avatar Jun 28 '24 09:06 hailkomputer

Hey again @tkashem 👋, 1.31 Enhancements team here,

Just checking in as we approach code freeze at at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

(Compiled the following list based on the mention of PR https://github.com/kubernetes/enhancements/pull/4462 in the description. Please let me know if there are any PRs listed below that don't require tracking as part of this KEP)

  • https://github.com/kubernetes/kubernetes/pull/125093
  • https://github.com/kubernetes/kubernetes/pull/124895
  • https://github.com/kubernetes/kubernetes/pull/124730
  • https://github.com/kubernetes/kubernetes/pull/122923
  • https://github.com/kubernetes/kubernetes/pull/114189

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

dipesh-rawat avatar Jul 01 '24 23:07 dipesh-rawat

Hey again @tkashem 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in around two weeks time, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4460#issuecomment-2201438897 that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

dipesh-rawat avatar Jul 09 '24 18:07 dipesh-rawat

Hi @dipesh-rawat, this enhancement will miss 1.31, more work is needed to satisfy all of the alpha criteria. I would like to target 1.32 for alpha. please let me know what steps I should take to clear/reset the milestone, thanks!

tkashem avatar Jul 13 '24 00:07 tkashem

@tkashem Thank you for confirming that this enhancement will be targeted for a future release. I will mark this as Deferred on the tracking board for the current v1.31 release.

I noticed that one PR https://github.com/kubernetes/kubernetes/pull/124730, which is related to this KEP, has been merged into k/k. Not sure if it needs reverting or if we’re good since all tests in the PR passed.

I’ll involve @sreeram-venkitesh (v1.31 Enhancements Lead) to review and ensure everything mentioned above is okay. Additionally, he can assist in clearing milestones and labels. @sreeram-venkitesh, please take a look at this when you get the chance.

dipesh-rawat avatar Jul 16 '24 00:07 dipesh-rawat

@tkashem Thanks for pinging us about moving this KEP to the next release! I'll remove it from the milestone now.

/milestone clear

@dipesh-rawat I don't think we need to revert the PR that was already merged. I will confirm this though.

sreeram-venkitesh avatar Jul 16 '24 06:07 sreeram-venkitesh

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

tjons avatar Sep 16 '24 12:09 tjons

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 15 '24 12:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 14 '25 13:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Feb 13 '25 13:02 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 13 '25 13:02 k8s-ci-robot

if someone wants to pick it up in the future:

  • https://github.com/kubernetes/kubernetes/pull/122923
  • https://github.com/kubernetes/kubernetes/pull/124730
  • https://github.com/kubernetes/kubernetes/pull/125093
  • https://github.com/kubernetes/kubernetes/pull/124895
  • https://github.com/kubernetes/kubernetes/pull/122976
  • https://github.com/kubernetes/kubernetes/pull/122924
  • https://github.com/kubernetes/kubernetes/pull/114189

tkashem avatar Apr 10 '25 12:04 tkashem