enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Add more granular failure reason for Job PodFailurePolicy

Open danielvegamyhre opened this issue 1 year ago • 14 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add an optional Reason field to the Job PodFailurePolicyRule, which allows the user to specify the failure reason which will be included in the condition added to the Job when it fails.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/4443-configurable-pod-failure-policy-reasons/README.md
  • Discussion Link: https://github.com/kubernetes/kubernetes/issues/122972
  • Primary contact (assignee): @danielvegamyhre
  • Responsible SIGs: sig-apps
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.31
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4479
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

danielvegamyhre avatar Jan 26 '24 19:01 danielvegamyhre

/sig apps /wg batch

danielvegamyhre avatar Jan 26 '24 19:01 danielvegamyhre

/label lead-opted-in /milestone v1.30 /stage alpha

soltysh avatar Feb 06 '24 20:02 soltysh

Hello @danielvegamyhre 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.30.
  • [x] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

  • Make sure that the #4479 is merged to the k/enhancements repo.

The status of this enhancement is marked as At risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

salehsedghpour avatar Feb 08 '24 21:02 salehsedghpour

Hello 👋, 1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.30, please file an exception request. Thanks!

salehsedghpour avatar Feb 09 '24 02:02 salehsedghpour

/milestone clear

salehsedghpour avatar Feb 09 '24 02:02 salehsedghpour

/label lead-opted-in /milestone v1.31 /stage alpha

soltysh avatar Apr 26 '24 15:04 soltysh

Hi @danielvegamyhre 👋 v1.31 Enhancements team here.

I wanted to check in as we approach the enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting alpha for v1.31. Please correct me if that isn't the case.

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [X] KEP readme has up-to-date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we need to do the following:

  • [x] Get https://github.com/kubernetes/enhancements/pull/4479 merged before the enhancements freeze. The files look good to me.

The status of this enhancement is marked as at risk for enhancement freeze. We can mark it as tracked as soon as the above changes are merged. Please make sure to get this done before the enhancements freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you!

mickeyboxell avatar Jun 04 '24 20:06 mickeyboxell

Hello @danielvegamyhre 👋, 1.31 Docs Shadow here.

Does the work related to this KEP planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

salaxander avatar Jun 11 '24 21:06 salaxander

With https://github.com/kubernetes/enhancements/pull/4479 merged, we can mark this KEP as tracked for enhancements freeze 🎉

sreeram-venkitesh avatar Jun 13 '24 13:06 sreeram-venkitesh

Hello there @danielvegamyhre

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Edit: @danielvegamyhre can you assign this issue to yourself? So it's easier to check the owner on the GitHub project. Thanks a lot!

mbianchidev avatar Jun 14 '24 10:06 mbianchidev

Hello @danielvegamyhre :wave:, 1.31 Docs Lead here. Does this enhancement work planned for 1.31 require any new docs or modification to existing docs? If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release. Thank you!

Princesso avatar Jun 23 '24 15:06 Princesso

Hello there @danielvegamyhre

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Edit: @danielvegamyhre can you assign this issue to yourself? So it's easier to check the owner on the GitHub project. Thanks a lot!

Reminder of the 3rd of July deadline! It's totally fine to also opt out if you don't think that writing a blog is useful for our users or if you don't have time (in that case team comms can also help you out :eyes: )

mbianchidev avatar Jun 25 '24 17:06 mbianchidev

Added placeholder PR https://github.com/kubernetes/kubernetes/pull/125804

danielvegamyhre avatar Jun 29 '24 18:06 danielvegamyhre

Hey again @danielvegamyhre 👋 Kubernetes 1.31 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

  • Is this the correct PR for changes to k/k? https://github.com/kubernetes/kubernetes/pull/126169
  • https://github.com/kubernetes/kubernetes/pull/125804

If you anticipate missing code freeze, you can file an [exception request](https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md) in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

The status of this enhancement is marked as at risk for code freeze.

mickeyboxell avatar Jul 03 '24 21:07 mickeyboxell

Hey @danielvegamyhre 👋 Kubernetes 1.31 Enhancements team here.

Following up on the message above as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024. Please let me know if you have any questions.

mickeyboxell avatar Jul 15 '24 16:07 mickeyboxell

Hello @danielvegamyhre 👋 Kubernetes 1.31 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.31 milestone.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

mickeyboxell avatar Jul 24 '24 02:07 mickeyboxell

/milestone clear

sreeram-venkitesh avatar Jul 24 '24 02:07 sreeram-venkitesh

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

tjons avatar Sep 16 '24 12:09 tjons