enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Restarting sidecar containers during Pod termination

Open matthyx opened this issue 1 year ago • 39 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allow sidecar containers to restart during the shutdown of the Pod.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4438-container-restart-termination
  • Discussion Link:
  • Primary contact (assignee): @matthyx
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.32
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • 1.30 https://github.com/kubernetes/enhancements/pull/4324
      • 1.31 https://github.com/kubernetes/enhancements/pull/4660
      • 1.32 https://github.com/kubernetes/enhancements/pull/4873
    • [ ] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/125710
    • [ ] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/45170
      • https://github.com/kubernetes/website/pull/45142

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

matthyx avatar Jan 25 '24 07:01 matthyx

/sig node

matthyx avatar Jan 25 '24 07:01 matthyx

/stage alpha /milestone v1.30

SergeyKanzhelev avatar Jan 27 '24 01:01 SergeyKanzhelev

/label lead-opted-in

mrunalp avatar Feb 02 '24 04:02 mrunalp

Hello @matthyx 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

AnaMMedina21 avatar Feb 07 '24 19:02 AnaMMedina21

Hi @matthyx ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

Checksumz avatar Feb 15 '24 09:02 Checksumz

Hi @matthyx ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

https://github.com/kubernetes/website/pull/45142

matthyx avatar Feb 15 '24 10:02 matthyx

Hello @matthyx 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

A feature gate is being added, so we'll need docs, marking it as Need Docs. Thanks!

Vyom-Yadav avatar Feb 15 '24 17:02 Vyom-Yadav

Hey again @matthyx 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [x] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP, I didn't see any in the description As always, we are here to help if any questions come up. Thanks!

AnaMMedina21 avatar Feb 29 '24 18:02 AnaMMedina21

@AnaMMedina21 this is the main PR https://github.com/kubernetes/kubernetes/pull/121412 however I'm not sure it will be finished on time... I will keep you posted here! /cc @gjkim42

matthyx avatar Mar 01 '24 07:03 matthyx

@AnaMMedina21 we have missed code freeze, let's try again for 1.31

matthyx avatar Mar 06 '24 06:03 matthyx

@AnaMMedina21 I updated the status to Removed From Milestone

Vyom-Yadav avatar Mar 11 '24 08:03 Vyom-Yadav

/milestone clear

pacoxu avatar Mar 26 '24 11:03 pacoxu