enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Job API managed-by mechanism

Open mimowo opened this issue 1 year ago • 40 comments

Enhancement Description

  • One-line enhancement description: Support managed-by mechanism for Jobs

  • Kubernetes Enhancement Proposal: KEP-4368: Support managedBy field for Jobs

  • Discussion Link: Job API proposal for MultiKueue, and sig-apps meeting Nov 27,2023, and wg-batch meeting Jan 18 2024

  • Primary contact (assignee): @mimowo

  • Responsible SIGs: apps

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.30
    • Beta release target (x.y): 1.32
    • Stable release target (x.y):
  • [x] Alpha

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4370
      • https://github.com/kubernetes/enhancements/pull/4530
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/123273
      • https://github.com/kubernetes/kubernetes/pull/123751
      • https://github.com/kubernetes/kubernetes/pull/123815
      • https://github.com/kubernetes/kubernetes/pull/123792
      • https://github.com/kubernetes/kubernetes/pull/124793
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/45132
  • [x] Second Alpha (1.31)

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4657
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/125175
      • https://github.com/kubernetes/kubernetes/pull/125510
      • https://github.com/kubernetes/kubernetes/pull/125546
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/46808
  • [x] Beta

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4856
    • [X] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/127402
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/48378

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

mimowo avatar Dec 20 '23 14:12 mimowo

/sig apps /wg batch /assign

mimowo avatar Dec 20 '23 14:12 mimowo

/label lead-opted-in /milestone v1.30 /stage beta

soltysh avatar Jan 19 '24 10:01 soltysh

Hello @mimowo 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the [latest template](https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template) has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check [here](https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval)).

For this KEP, we would just need to update the following:

  • KEP status is marked as implementable for latest-milestone: 1.30.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

mickeyboxell avatar Jan 31 '24 22:01 mickeyboxell

@mickeyboxell would you like to take a look at why the checkbox about status: implementable and latest-milestone: 1.30 isn't checked? It seems the fields are filled accordingly in kep.yaml

mimowo avatar Feb 01 '24 08:02 mimowo

Thanks for catching that. It looks like an oversight on my part.

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

mickeyboxell avatar Feb 01 '24 20:02 mickeyboxell

BTW, the issue description should link to https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/4368-support-managed-by-label-for-batch-jobs (instead of to https://github.com/kubernetes/enhancements/pull/4370)

sftim avatar Feb 13 '24 17:02 sftim

@mimowo Can you open a placeholder docs PR for this by Thursday? Thank you 🙏

celestehorgan avatar Feb 14 '24 08:02 celestehorgan

@mimowo Can you open a placeholder docs PR for this by Thursday? Thank you 🙏

Sure, PTAL: https://github.com/kubernetes/website/pull/45132.

mimowo avatar Feb 14 '24 09:02 mimowo

Hi @mimowo,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

natalisucks avatar Feb 15 '24 12:02 natalisucks

Hey again @mimowo 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

  • https://github.com/kubernetes/kubernetes/pull/123273

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

mickeyboxell avatar Feb 22 '24 16:02 mickeyboxell

/stage alpha

kannon92 avatar Mar 01 '24 20:03 kannon92

Hi @mimowo 👋 Enhancements team here, just a friendly reminder to follow up on the open Enhancement items above prior to code freeze at 02:00 UTC Wednesday 6th March 2024.

mickeyboxell avatar Mar 05 '24 03:03 mickeyboxell

Hey again @mimowo 👋 Enhancements team here,

With all the implementation (code related) PRs merged as per the issue description:

  • https://github.com/kubernetes/kubernetes/pull/123273

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!

The last thing to do is to update the status field in the kep.yaml file to implemented when the code PRs are merged and the feature gates are removed.

mickeyboxell avatar Mar 05 '24 22:03 mickeyboxell

@mickeyboxell could you please update the speadsheet to indicate this is Alpha stage: https://github.com/orgs/kubernetes/projects/175/views/1?filterQuery=managed?

mimowo avatar Mar 06 '24 11:03 mimowo