Coordinated Leader Election

[jpbetz]

Enhancement Description

• One-line enhancement description (can be used as a release note): A "coordinated" component leader election mechanism that is safer for upgrades and rollbacks.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/4356
• Discussion Link:
• Primary contact (assignee): @jpbetz
• Responsible SIGs: sig-apimachinery
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.30
  • Beta release target (x.y):
  • Stable release target (x.y):
• [ ] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4356
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[jpbetz]

/sig api-machinery

[jpbetz]

/label lead-opted-in

This is targeting 1.31, but we'd like to merge the KEP early if possible so we can start implementation work.

[jpbetz]

/assign @sttts

[deads2k]

/milestone v1.31

[salehsedghpour]

/milestone clear

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sreeram-venkitesh]

Hi @jpbetz @deads2k, since this KEP already had lead-opted-in label and is targeting 1.31 for alpha as mentioned above by Joe, I've not made any changes and the KEP has been added to the 1.31 enhancements tracking board. Please let me know if this works. We can add the 1.31 milestone and update the issue description as well.

[tjons]

Hello @jpbetz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage alpha for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [x] KEP readme has up-to-date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

• [ ] Merge the KEP readme using the latest template into the k/enhancements repo.
• [ ] Mark the KEP status as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

/stage alpha

[chanieljdan]

Hi @jpbetz 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you!

Daniel

[Jefftree]

Hello @jpbetz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage alpha for 1.31 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [x] KEP readme has up-to-date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

• [ ] Merge the KEP readme using the latest template into the k/enhancements repo.
• [ ] Mark the KEP status as implementable for latest-milestone: { 1.31 }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

Hi @tjons. I just want to double check, the PRs have merged (https://github.com/kubernetes/enhancements/pull/4703 and https://github.com/kubernetes/enhancements/pull/4356) and this is the updated state of the KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/4355-coordinated-leader-election. I just want to double check that everything should be in place for alpha? Thanks!

[tjons]

Hi @Jefftree - the KEP readme changes look good, but we still need to update the latest-milestone and the target release for alpha in the kep.yaml file. Also, I'm not seeing a PRR yet... have you requested one? PRRs are required usually for each stage, including alpha.

[Jefftree]

Hi @tjons

PRR is merged: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-api-machinery/4355.yaml

Milestone has been updated to 1.31 and merged: https://github.com/kubernetes/enhancements/pull/4717

[tjons]

Looks good! Will update the status to tracked for enhancements freeze

[hailkomputer]

Hi @jpbetz

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[chanieljdan]

Hi @jpbetz 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you!

Daniel

Hi @jpbetz 👋,

Just a reminder to open a placeholder PR against dev-1.31 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday June 27, 2024 18:00 PDT.

Thanks,

Daniel

[hailkomputer]

@jpbetz , friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

[tjons]

Hi @Jefftree - 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024 .

Here's where this enhancement currently stands:

• [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Current PRs for this enhancement:

• https://github.com/kubernetes/kubernetes/pull/124012

If you anticipate missing code freeze, you can file an exception request in advance.

As always, we are here to help if any questions come up. Thanks!

[sreeram-venkitesh]

/milestone v1.31

[Jefftree]

One PR: https://github.com/kubernetes/kubernetes/pull/124012

[tjons]

Great! I'll keep an eye on it.

[tjons]

@Jefftree with the outstanding PR now having the approved and lgtm labels, this enhancement is now tracked for code freeze!

[tjons]

Hello @Jefftree 👋 Enhancements team here,

Unfortunately, after posting the above comment, I just realized that the unit and integration tests are failing... after discussing with the release team, we are going to untrack this for code freeze because of the size of the PR. Hence this enhancement is now removed from the 1.31 milestone.

If you still wish to progress this enhancement in 1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[k8s-ci-robot]

@tjons: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

Hello @Jefftree 👋 Enhancements team here,

Unfortunately, after posting the above comment, I just realized that the unit and integration tests are failing... after discussing with the release team, we are going to untrack this for code freeze because of the size of the PR. Hence this enhancement is now removed from the 1.31 milestone.

If you still wish to progress this enhancement in 1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sreeram-venkitesh]

/milestone clear

[Jefftree]

Hello @Jefftree 👋 Enhancements team here,

Unfortunately, after posting the above comment, I just realized that the unit and integration tests are failing... after discussing with the release team, we are going to untrack this for code freeze because of the size of the PR. Hence this enhancement is now removed from the 1.31 milestone.

If you still wish to progress this enhancement in 1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

Hi @tjons. I don't see the tests failing and it was approved before the deadline. Do I need an exception to proceed with merge?

[sreeram-venkitesh]

Hi @Jefftree, we are in the code freeze party call right now and at the time of removing the KEP from the milestone, the test were failing. I can see @pacoxu's comment on your PR pointing out a failing test which might be related to your code change (https://github.com/kubernetes/kubernetes/pull/124012#issuecomment-2246741964). We are waiting for all of CI to complete.

If there is no further code changes required to fix any failing tests, you don't need to file an exception, but the release team will go through the PR for approval and apply the milestone label.

[sreeram-venkitesh]

@Jefftree We need to file an exception request to merge https://github.com/kubernetes/kubernetes/pull/124012 now that there are new code changes pushed to the PR after the code freeze. You can file an exception for 1 day since the changes have been pushed and lgtm'd

CC: @sttts @neoaggelos @Priyankasaggu11929

[aojea]

In this case the exception is justified, the new code is just a test fix https://github.com/kubernetes/kubernetes/pull/124012/commits/6b7c8895ef984f99c684c373db852c749c85d42a

[sreeram-venkitesh]

/milestone v1.31

Status updated to Tracked for code freeze!