enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

add ProcMount option

Open haircommander opened this issue 1 year ago β€’ 38 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note):

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4265-proc-mount

  • Discussion Link:

  • Primary contact (assignee): @sohankunkerkar @haircommander

  • Responsible SIGs: node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.12
    • Beta release target (x.y): 1.31
    • Stable release target (x.y):
  • [x] Alpha

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/community/pull/1934
      • https://github.com/kubernetes/enhancements/pull/4266
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/64283
      • https://github.com/kubernetes/kubernetes/pull/123520
    • [x] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/45152
  • [ ] Beta

    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4679
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/123303
    • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

haircommander avatar Oct 02 '23 18:10 haircommander

replaces https://github.com/kubernetes/community/pull/1934 /sig node /sig auth

haircommander avatar Oct 02 '23 18:10 haircommander

/label lead-opted-in

mrunalp avatar Oct 03 '23 15:10 mrunalp

Hola @haircommander πŸ‘‹, v1.29 Enhancements team here.

I am just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2023..

This enhancement is targeting stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: { v1.29}. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • For this PR to be approved: https://github.com/kubernetes/enhancements/pull/4266

The status of this enhancement is marked as Tracked for Enhancements Freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

AnaMMedina21 avatar Oct 03 '23 22:10 AnaMMedina21

Sorry for the confusion @haircommander, this is actually currently At Risk for Enhancement Freeze until https://github.com/kubernetes/enhancements/pull/4266 is approved. We'll update the status once the PR goes in. Let me know if you have any questions- Thanks!

npolshakova avatar Oct 04 '23 19:10 npolshakova

Hello πŸ‘‹, 1.29 Enhancements Lead here. Unfortunately, this enhancement did not meet requirements for v1.29 enhancements freeze. Feel free to file an exception to add this back to the release tracking process.

https://github.com/kubernetes/enhancements/pull/4266 is awaiting PRR approval. Please file an exception and once the PRR review is complete this should fulfill all the enhancement freeze requirements.

Thanks!

/milestone clear

npolshakova avatar Oct 06 '23 02:10 npolshakova

@haircommander, what's the β€œOne-line enhancement description” for this KEP?

sftim avatar Oct 06 '23 16:10 sftim

@npolshakova https://groups.google.com/g/kubernetes-sig-release/c/emPOBgXxu0Q/m/JxEx-ZrcBgAJ?utm_medium=email&utm_source=footer

Your updated deadline to make any changes to your KEP is 18:00 PST Monday 9th October 2023.

The exception is approved by v1.29 release team. However, we may miss the deadline again 🀣.

pacoxu avatar Oct 16 '23 09:10 pacoxu

@pacoxu It looks like this won't be making it into 1.29 from the slack discussion: https://kubernetes.slack.com/archives/C2C40FMNF/p1697033013866149?thread_ts=1696609849.513439&cid=C2C40FMNF

npolshakova avatar Oct 16 '23 12:10 npolshakova

/triage accepted

stlaz avatar Nov 20 '23 17:11 stlaz

/remove-label lead-opted-in

salehsedghpour avatar Jan 06 '24 15:01 salehsedghpour

@SergeyKanzhelev @mrunalp a little late but I have decided to update the KEP. can you PTAL and opt-in as discussed in sig node meeting?

haircommander avatar Feb 01 '24 20:02 haircommander

/stage beta /milestone v1.30 /label lead-opted-in

mrunalp avatar Feb 02 '24 04:02 mrunalp

Hello @haircommander πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage beta for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • [x] Merge the updates to the KEP readme into the k/enhancements repo.
  • [x] Complete the PRR review process and merge it into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

tjons avatar Feb 06 '24 20:02 tjons

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze πŸš€

tjons avatar Feb 08 '24 20:02 tjons

Hi @haircommander ,

πŸ‘‹ from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

Checksumz avatar Feb 15 '24 09:02 Checksumz

Hello @haircommander πŸ‘‹, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

At a minimum, we'll need bumping ProcMountType feature gate to beta in docs, so marking as Need Docs. If there are some logical changes, we'll need a PR for that too. Thanks!

Also, I edited the issue desc to update the target version :)

- Beta release target (x.y): 1.29
+ Beta release target (x.y): 1.30

Vyom-Yadav avatar Feb 15 '24 16:02 Vyom-Yadav

Hey again @haircommander πŸ‘‹ Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PR is open and needs to be merged before code freeze:

  • https://github.com/kubernetes/kubernetes/pull/123303

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

tjons avatar Feb 25 '24 18:02 tjons

Hey @haircommander - code freeze is ~6 hours away! We still need https://github.com/kubernetes/kubernetes/pull/123303 to merge before freeze or this will require an exception.

tjons avatar Mar 06 '24 02:03 tjons

Thanks for the heads up! I will file an exception

haircommander avatar Mar 06 '24 02:03 haircommander

Hello @haircommander πŸ‘‹ Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

salehsedghpour avatar Mar 06 '24 08:03 salehsedghpour

/milestone v1.30

MaryamTavakkoli avatar Mar 06 '24 19:03 MaryamTavakkoli

@MaryamTavakkoli: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 06 '24 19:03 k8s-ci-robot

With the exception request being approved, this enhancement is now marked as tracked for code freeze.

/milestone v1.30

salehsedghpour avatar Mar 07 '24 10:03 salehsedghpour

/stage alpha

(retargeted at alpha)

haircommander avatar Mar 25 '24 17:03 haircommander