kubernetes
KEP-4261: Add support for multiple metrics APIs
- One-line PR description: Add support for multiple metrics APIs, allowing multiple services exposing metrics on same metric type
- Issue link: https://github.com/kubernetes/enhancements/issues/4261
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JorTurFer Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @JorTurFer!
It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/enhancements has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @JorTurFer. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@chicks-net: You can't reopen an issue/PR unless you authored it or you are a collaborator.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/reopen I don't understand how this gets so little attention. If you run a pre-keda cluster and want to switch, you're going to hit this and end up doing some janky nginx --insecure stuff. It seems like core functionality (HPA) that is now tied to keda implementing everything anyone needs. Let me know if there's anything I can do to help this forward
@afirth: Reopened this PR.
In response to this:
/reopen I don't understand how this gets so little attention. If you run a pre-keda cluster and want to switch, you're going to hit this and end up doing some janky nginx --insecure stuff. It seems like core functionality (HPA) that is now tied to keda implementing everything anyone needs. Let me know if there's anything I can do to help this forward
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
What this improvement needs: willing volunteers that have the capacity. So far, we didn't find some.
Personally I'd prefer to see an out-of-tree component that lets you aggregate metric sources, rather than the approach in this KEP. But either way, it's volunteer time and effort that is needed to manage the work around improving Kubernetes.
.
We finally decided to go using an external proxy rather than modifying the k8s API. I've created a PoC that verifies to idea to check if it's feasible or not (it is), but I haven't had enough time to finish and publish the project. I hope that it'll be ready during next months
Thanks @JorTurFer, also for your help in the past when I had to deal with this! Do you have a link to the PoC that people could potentially explore or contribute to? (I came here from https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/70)
Tyvm for championing this @JorTurFer , I would love to view and possibly contribute to any working PoC you have around the proxy server approach you mentioned above. We are running into this issue while trying to onboard Keptn enterprise wide at a cluster-level when there is an existing metrics apiserver in place for our primary Prometheus monitoring stack.
