New Static Policy Proposal - Spread HT across physical CPUs

[Jeffwan]

Enhancement Description

• One-line enhancement description (can be used as a release note): VPA + core binding
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/7057e50c7c4ba39baba144e650eba15276cc3a65/keps/sig-node/4176-cpumanager-spread-cpus-preferred-policy/README.md
• Discussion Link: https://docs.google.com/document/d/1V3DLh3pH3CD-xhhJvAnOq_oWgPyjO-vj6wY6qdew9H0/edit#heading=h.ybybfdfputt
• Primary contact (assignee): @Jeffwan
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.31
  • Beta release target (x.y): 1.32
  • Stable release target (x.y): 1.34
• [ ] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4177
  • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/123733
  • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[Jeffwan]

/sig node

[ffromani]

/cc

[SergeyKanzhelev]

/stage alpha /milestone v1.29

Applying the milestone as discussed at SIG Node meeting this week

[npolshakova]

Hello @Jeffwan, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

[salehsedghpour]

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

[Jeffwan]

Sounds good. I will follow the instruction and move it to v1.30. We plan to polish it for further review.

[Jeffwan]

@salehsedghpour This is the initial issue and the PR is not merged yet. Could you help add v1.30 milestone? @SergeyKanzhelev @ffromani We will put some time to address all the comments recently

[salehsedghpour]

Thanks for the info @Jeffwan, may you please follow it up so that you could also have the lead-opted-in label and the milestone with the SIG leads?

[SergeyKanzhelev]

/stage alpha /milestone v1.30

As discussed this is conditioned on the discussion on whether NRI approach will work better for this scenario

[mrunalp]

/label lead-opted-in

[jpbetz]

PRR reviewer here, is there a KEP PR for 1.30 for this enhancement?

[Jeffwan]

@jpbetz I see you've already left comments in the PR. https://github.com/kubernetes/enhancements/pull/4177 Let's discuss more details there.

[sreeram-venkitesh]

Hello @Jeffwan 👋, v1.30 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [x] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [x] KEP readme has up-to-date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we need to do the following:

• Update the latest-milestone here in the kep.yaml to 1.30
• Update the alpha milestone to 1.30 instead of 1.29.
• Make sure to create the prod-readiness/<sig>/<KEP number>.yaml file as mentioned by @jpbetz here. More about

The status of this enhancement is marked as At risk for enhancements freeze. Please make sure to do all the above tasks and get your PRs merged before the enhancements freeze. Please let us know if you have any questions!

[Jeffwan]

@sreeram-venkitesh Thanks for the reminder. All the TODO items have been addressed and it's pending review.

[sreeram-venkitesh]

Hello 👋, v1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

[salehsedghpour]

/milestone clear

[Jeffwan]

@sreeram-venkitesh @salehsedghpour I filed an exception and waiting for sig-node to approve it.

[celestehorgan]

Hello @Jeffwan!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

[Checksumz]

Hi @Jeffwan ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

[Jeffwan]

@celestehorgan https://github.com/kubernetes/website/pull/45216 @Checksumz https://github.com/kubernetes/website/pull/45217

I have filed placeholder PRs for doc and blog change.

[sreeram-venkitesh]

Hey again @Jeffwan 👋 v1.30 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024.

Here's where this enhancement currently stands:

• [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I was not able to find the PRs for the code changes in k/k. Please let me know of the PRs that we should track and also update the issue description with the same. Currently the KEP is marked as At Risk for Code Freeze.

As always, we are here to help if any questions come up. Thanks!

[sreeram-venkitesh]

@Jeffwan Please let me know which all PRs needs to be tracked for the code freeze. The code freeze is tomorrow.

[Jeffwan]

@sreeram-venkitesh https://github.com/kubernetes/kubernetes/pull/123733 here the PR. I am trying to polish all the tests and gather feedbacks from reviewers. It's a little bit late but I will spend most of time today to finish it

[salehsedghpour]

Hello @Jeffwan 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

[Jeffwan]

@salehsedghpour The code are in good shape now and I have few rounds discussion with the reviewers to move forward the feature. If we do can deliver the high-quality code in 1 day, I will file the exception. Thanks.