[KEP-3085] Add condition for sandbox creation (xposted from original issue)

[kannon92]

This is a repost of https://github.com/kubernetes/enhancements/issues/3085 as we want to keep this up to date.

Enhancement Description

• One-line enhancement description (can be used as a release note): Surface pod conditions around completion of pod sandbox creation marked by successful network configuration for the pod.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation
• Discussion Link: SIG Node Agenda
• Primary contact (assignee): @kannon92 (@ddebroy is original author)
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha1 release target (x.y): 1.25
  • Alpha2 release target (x.y): 1.28
  • Beta release target (x.y): 1.29-1.30
  • Stable release target (x.y):
• [x] Alpha1 (1.25)
  • [x] KEP (k/enhancements) update PR(s):
    • [x] https://github.com/kubernetes/enhancements/pull/3087
    • [x] https://github.com/kubernetes/enhancements/pull/4077
  • [x] Code (k/k) update PR(s):
    • [x] https://github.com/kubernetes/kubernetes/pull/111358
    • [x] https://github.com/kubernetes/kubernetes/pull/117702
  • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/35704
• [x] Alpha2 (1.28)
  • [x] KEP (k/enhancements) update PR(s):
    • [x] https://github.com/kubernetes/enhancements/pull/3778
  • [x] Code (k/k) update PR(s):
    • [x] https://github.com/kubernetes/kubernetes/pull/117702
  • [x] Docs (k/website) update PR(s):
    • [x] https://github.com/kubernetes/website/pull/41744
    • [x] https://github.com/kubernetes/website/pull/40945
• [x] Beta (1.29-1.30)
  • [x] KEP (k/enhancements) update PR(s):
    • https://github.com/kubernetes/enhancements/pull/4139
    • https://github.com/kubernetes/enhancements/pull/4483
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes/kubernetes/pull/119659
    • https://github.com/kubernetes/kubernetes/pull/121044
    • https://github.com/kubernetes/kubernetes/pull/121321
  • [x] Docs (k/website) update(s):
    • https://github.com/kubernetes/website/pull/43533
    • https://github.com/kubernetes/website/pull/43932

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kannon92]

/sig node

[kannon92]

Moved https://github.com/kubernetes/enhancements/issues/3085 to this thread so I can keep it up-to-date with latest changes. It was a bit challenging to keep release team up to date so want to be able to update this.

[kannon92]

@Atharva-Shinde can you please add the same labels as the issue in #3085?

[Atharva-Shinde]

/stage alpha /milestone v1.28

/label lead-opted-in for v1.28 as per comment

[Atharva-Shinde]

@kannon92 please link the original issue in this issue description :)

[liggitt]

can this be categorized into a stage in the 1.28 project? the repost of the issue meant it was missing some metadata

[kannon92]

can this be categorized into a stage in the 1.28 project? the repost of the issue meant it was missing some metadata

@Atharva-Shinde are you able to help with this? I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

[Atharva-Shinde]

can this be categorized into a stage in the 1.28 project?

@liggitt I have updated the stage on the enhancements project board to alpha.

I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

I'm not sure if I understand you @kannon92, this issue already has a v1.28 milestone tag attached here and on the project board too.

[kannon92]

can this be categorized into a stage in the 1.28 project?

@liggitt I have updated the stage on the enhancements project board to alpha.

I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

I'm not sure if I understand you @kannon92, this issue already has a v1.28 milestone tag attached here and on the project board too.

I realize I was wrong. I thought I should see a label in the issue with v1.28 but I don't see that.

[npolshakova]

Hello 👋, 1.29 Enhancements Lead here.

If you wish to progress this enhancement in v1.29, please have the SIG lead opt-in your enhancement by adding the lead-opt-in and milestone v1.29 labels before the Production Readiness Review Freeze.

/remove-label lead-opted-in

[SergeyKanzhelev]

/milestone v1.29 /label lead-opted-in

as discussed at sig node meeting this week

[kannon92]

/assign

[sanchita-07]

Hello @kannon92 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [ ] KEP readme has up-to-date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would need to add/update the following:

• The status should be marked as implementable in the kep.yaml file.
• Ensure that the PR including the production readiness review has been reviewed and merged into k/enhancements.
• KEP readme has up-to-date graduation criteria

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[sanchita-07]

Hi @kannon92, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze. It looks like merging of #4139 will address the requirements. Let me know if I missed anything. Thanks!

[sanchita-07]

Hi @kannon92, With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀. The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[kannon92]

Can someone update the stage to say beta?

[SergeyKanzhelev]

/stage beta

[harshitasao]

Hi @kannon92 @ddebroy 👋, v1.29 Docs Shadow here Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

[kannon92]

@charles-chenzz would you be interested in taking lead on the changes needed for the website and maybe doing a blog post for beta promotion?

[charles-chenzz]

@charles-chenzz would you be interested in taking lead on the changes needed for the website and maybe doing a blog post for beta promotion?

@kannon92 yes, I would like to. but the blog post might need to add you to review as well

[harshitasao]

Hi @kannon92! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

[charles-chenzz]

Hi @harshitasao , the place hold PR is open. https://github.com/kubernetes/website/pull/43533 please ignore the other ones :(

[James-Quigley]

Hi @kannon92 :wave: from the v1.29 Communications Release Team! We would like to check if you have any plans to publish blogs for this KEP regarding new features, removals, and deprecations for this release. If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review) Here's the 1.29 Calendar

[kannon92]

Hi @kannon92 👋 from the v1.29 Communications Release Team! We would like to check if you have any plans to publish blogs for this KEP regarding new features, removals, and deprecations for this release. If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review) Here's the 1.29 Calendar

@charles-chenzz and I have discussed a post highlight this feature.

[sanchita-07]

Hey again @kannon92 again 👋, 1.29 Enhancements team here.

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023:

Here's where this enhancement currently stands:

• [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [x] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PR was merged before code freeze:

• https://github.com/kubernetes/kubernetes/pull/119659
• https://github.com/kubernetes/kubernetes/pull/121044
• https://github.com/kubernetes/kubernetes/pull/121213

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

With the merged and linked in the issue description, this KEP is tracked for code freeze for v1.29. 🚀 As always, we are here to help if any questions come up ✌. Thanks :)

[kannon92]

@sanchita-07

https://github.com/kubernetes/kubernetes/pull/1211213 was actually reverted https://github.com/kubernetes/kubernetes/pull/121324

So @charles-chenzz is looking into https://github.com/kubernetes/kubernetes/pull/121321 to resolve these failures.

I'll update the ticket to reflect that.

[sanchita-07]

Thanks @kannon92 for mentioning! Currently, I am marking this KEP as at risk for code freeze as the PR :

• https://github.com/kubernetes/kubernetes/pull/121321 is in progress.

After this PR gets approved and lgtm level we will certainly move this KEP to tracked for code freeze :)

[sanchita-07]

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PR for this KEP is:

https://github.com/kubernetes/kubernetes/pull/121321

Please let me know if there are additional test PRs we should track. Thanks!

[kcmartin]

@kannon92 @charles-chenzz Hi, 1.29 Comms Team again! You indicated you were thinking about writing a blog post for this feature. A reminder that today (November 14, 2023) is the deadline for opening a Draft blog PR. Would you please update us about your plans?

[kannon92]

@kannon92 @charles-chenzz Hi, 1.29 Comms Team again! You indicated you were thinking about writing a blog post for this feature. A reminder that today (November 14, 2023) is the deadline for opening a Draft blog PR. Would you please update us about your plans?

https://github.com/kubernetes/website/pull/43932 has the draft PR.