Discover cgroup driver from CRI

[marquiz]

Enhancement Description

• One-line enhancement description (can be used as a release note): Extend CRI API for the kubelet to discover the cgroup driver from the container runtime.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri
• Discussion Link: kubernetes/kubernetes#99808, also SIG Node meeting Feb 14th, 2023,
• Primary contact (assignee): @marquiz @haircommander
• Responsible SIGs: SIG Node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.28
  • Beta release target (x.y): 1.31
  • Stable release target (x.y): 1.34
• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4034
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes/kubernetes/pull/118770
  • [x] Docs (k/website) update PR(s):
    • https://github.com/kubernetes/website/pull/42160
• [x] Beta
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4682
  • [x] Code (k/k) update PR(s):
    • ~~https://github.com/kubernetes/kubernetes/pull/119441~~
    • [x] https://github.com/kubernetes/kubernetes/pull/125828
  • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/47054
• [ ] Stable
  • [ ] KEP (k/enhancements) update PR(s): #5370
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[marquiz]

/sig node

[SergeyKanzhelev]

/milestone v1.28

[SergeyKanzhelev]

/label lead-opted-in

[SergeyKanzhelev]

/stage alpha

[salehsedghpour]

Hello @marquiz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [X] KEP readme using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for latest-milestone: 1.28
• [ ] KEP readme has a updated detailed test plan section filled out
• [X] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update the detailed test plan section in the readme file.
• Update the reviewer and approver fields in kep.yaml.
• Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[salehsedghpour]

Hi @marquiz 👋, just checking in before the enhancements freeze on 01:00 UTC Friday, 16th June 2023.

The status for this enhancement is at risk.

For this KEP, we would just need to update the following:

• Update the detailed test plan section in the readme file.
• Update the reviewer and approver fields in kep.yaml.
• Ensure that the PRs are merged.

Let me know if I missed anything. Thanks!

[marquiz]

Thanks @salehsedghpour. The first two of the items should now be addressed:

• Test plan section in the readme file has been updated
• Reviewer and approver fields in kep.yaml have been filled

[salehsedghpour]

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀

The status of this enhancement is marked as tracked.

[VibhorChinda]

Hello @marquiz :wave:, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[Rishit-dagli]

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

[salehsedghpour]

Hey again @marquiz :wave: Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 . Here’s the enhancement’s state for the upcoming code freeze:

• [ ] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• [x] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too. For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :
  • https://github.com/kubernetes/kubernetes/pull/118770

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

[VibhorChinda]

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023. Thanks.

[marquiz]

@VibhorChinda thanks 🫡 I will work on that tomorrow

[Atharva-Shinde]

Hey @marquiz 👋 Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/118770 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

[VibhorChinda]

Hello @marquiz :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

[marquiz]

@VibhorChinda argh, I had submitted the documentation to the main branch, against the guidance 🙈 I now re-submitted towards dev-1.28 (https://github.com/kubernetes/website/pull/42160).

[npolshakova]

/remove-label lead-opted-in

[salehsedghpour]

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

[marquiz]

Plan is for beta in v1.31 (description updated)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[SergeyKanzhelev]

/label lead-opted-in /milestone v1.31 /stage beta /remove-lifecycle stale

[dipesh-rawat]

Hello @marquiz 👋, 1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [x] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• [x] KEP readme has up-to-date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• Please update kep.yaml to reflect beta for v1.31
• Please submit a PRR for beta

It looks like https://github.com/kubernetes/enhancements/pull/4682 will address most of these issues.

• [ ] Get https://github.com/kubernetes/enhancements/pull/4682 merged before the enhancements freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

Hi @marquiz @haircommander👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

The current status of this enhancement is still marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment https://github.com/kubernetes/enhancements/issues/4033#issuecomment-2148631605 that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[haircommander]

KEP update PR merged https://github.com/kubernetes/enhancements/pull/4682 :) @marquiz can you update the description?

[dipesh-rawat]

Hello @marquiz @haircommander,

Now that PR https://github.com/kubernetes/enhancements/pull/4682 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

• Update issue description to mention,
  • Beta KEP (k/enhancements) update PR(s): #4682
• Ensure that this issue has an assignee.

Aside from the minor nits mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[haircommander]

/assign

[dipesh-rawat]

@marquiz @haircommander, We're currently in enhancements freeze at the moment. We need a update in the kep.yaml to set the stage: beta. Could you please make this update to the kep.yaml as soon as you can.

[haircommander]

i'm afraid I don't have the power to edit and I think @marquiz is on vacation

[hacktivist123]

Hello @marquiz @haircommander 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

[rashansmith]

Hi @haircommander,

:wave: from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.