enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Add Pod Index Label for StatefulSets and Indexed Jobs

Open danielvegamyhre opened this issue 2 years ago β€’ 42 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add Pod Index Label for StatefulSets and Indexed Jobs.
  • Kubernetes Enhancement Proposal:
  • Discussion Link: https://github.com/kubernetes/kubernetes/issues/117986
  • Primary contact (assignee): @danielvegamyhre
  • Responsible SIGs: sig-apps
  • Enhancement target (which target equals to which milestone):
    • Beta release target (x.y): 1.28
    • Stable release target (x.y): 1.32

Note: We will release the feature directly in Beta state since there is no benefit in having an alpha release, since we are simply adding a new label so there is very little risk (unlike removing an existing label which other things may depend on, for example).

  • [X] Beta
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4019
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/118883
      • [x] https://github.com/kubernetes/kubernetes/pull/119232
    • [x] Docs (k/website) update(s):
      • [x] https://github.com/kubernetes/website/pull/42139
  • [ ] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4865
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

danielvegamyhre avatar May 17 '23 03:05 danielvegamyhre

/sig apps /assign

danielvegamyhre avatar May 17 '23 03:05 danielvegamyhre

/label beta /milestone v1.28 /label lead-opted-in

soltysh avatar May 22 '23 09:05 soltysh

@soltysh: The label(s) /label beta cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label beta /milestone v1.28 /label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 22 '23 09:05 k8s-ci-robot

/stage beta

soltysh avatar May 22 '23 09:05 soltysh

Hi @danielvegamyhre πŸ‘‹, Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise.)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.28
  • [x] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like https://github.com/kubernetes/enhancements/pull/4019 will address some of these requirements.

For this KEP, we would just need to update the following:

  • Mark the status as implementable for 1.28
  • Address questions inside the Production Readiness Review Questionnaire

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar May 30 '23 23:05 npolshakova

@Atharva-Shinde this is only pending PRR review

ahg-g avatar Jun 09 '23 15:06 ahg-g

@Atharva-Shinde this is only pending PRR review

Ack. We'll mark this as tracked after it is approved.

Atharva-Shinde avatar Jun 10 '23 05:06 Atharva-Shinde

Looks like the PRR is approved and https://github.com/kubernetes/enhancements/pull/4019 has gone in so this is now tracked for 1.28 πŸš€

npolshakova avatar Jun 14 '23 19:06 npolshakova

Hello @danielvegamyhre! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

katcosgrove avatar Jun 21 '23 13:06 katcosgrove

Hey again @danielvegamyhre :wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • [ ] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • [ ] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

  • https://github.com/kubernetes/kubernetes/pull/118883
  • https://github.com/kubernetes/kubernetes/pull/119232

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

npolshakova avatar Jul 11 '23 21:07 npolshakova

Hey @danielvegamyhre , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

Rishit-dagli avatar Jul 12 '23 15:07 Rishit-dagli

@Rishit-dagli Docs PR created here: https://github.com/kubernetes/website/pull/42059

danielvegamyhre avatar Jul 17 '23 17:07 danielvegamyhre

Hey @danielvegamyhre πŸ‘‹ Enhancements Lead here

With all the implementation(code related) PRs merged as per the issue description: https://github.com/kubernetes/kubernetes/pull/118883 https://github.com/kubernetes/kubernetes/pull/119232

This enhancement is now marked as tracked for the v1.28 Code Freeze!

Atharva-Shinde avatar Jul 19 '23 02:07 Atharva-Shinde

All items for beta in 1.28 release have been completed.

danielvegamyhre avatar Aug 03 '23 21:08 danielvegamyhre

Hello πŸ‘‹, 1.29 Enhancements Lead here.

If you wish to progress this enhancement in v1.29, please have the SIG lead opt-in your enhancement by adding the lead-opt-in and milestone v1.29 labels before the Production Readiness Review Freeze.

/remove-label lead-opted-in

npolshakova avatar Aug 27 '23 22:08 npolshakova

Hello πŸ‘‹ 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

salehsedghpour avatar Jan 16 '24 23:01 salehsedghpour

@salehsedghpour we will graduate this to GA

/label lead-opted-in /milestone v1.30

danielvegamyhre avatar Jan 17 '24 00:01 danielvegamyhre

@danielvegamyhre: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

@salehsedghpour we will graduate this to GA

/label lead-opted-in /milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 17 '24 00:01 k8s-ci-robot

/stage ga

danielvegamyhre avatar Jan 17 '24 00:01 danielvegamyhre

@danielvegamyhre: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

@salehsedghpour we will graduate this to GA

/label lead-opted-in /milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 17 '24 00:01 k8s-ci-robot

/label lead-opted-in /milestone v1.30

ahg-g avatar Jan 17 '24 00:01 ahg-g

/stage stable

ahg-g avatar Jan 17 '24 01:01 ahg-g

Hello @danielvegamyhre πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [X] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone and stage in kep.yaml
  • Update the PRR for stable

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

meganwolf0 avatar Jan 21 '24 18:01 meganwolf0

Hello @danielvegamyhre πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is still at risk for enhancement freeze. Please make sure you get all changes merged before the enhancement freeze deadline. Thank you!

meganwolf0 avatar Feb 08 '24 11:02 meganwolf0

Hello @danielvegamyhre πŸ‘‹, 1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.30, please file an exception request. Thanks!

meganwolf0 avatar Feb 09 '24 02:02 meganwolf0

/milestone clear

salehsedghpour avatar Feb 09 '24 02:02 salehsedghpour

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 09 '24 03:05 k8s-triage-robot

/remove-lifecycle stale

tenzen-y avatar May 09 '24 04:05 tenzen-y

Hi @tenzen-y πŸ‘‹, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

sreeram-venkitesh avatar May 15 '24 01:05 sreeram-venkitesh

@danielvegamyhre do you plan to graduate this feature in 1.31?

atiratree avatar May 28 '24 18:05 atiratree