enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Add CDI devices to device plugin API

Open klueska opened this issue 1 year ago • 72 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): An enhancement to the DevicePlugin API to include a field for CDI devices.

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4009-add-cdi-devices-to-device-plugin-api/

  • Discussion Link: Private slack messages

  • Primary contact (assignee): @klueska, @elezar

  • Responsible SIGs: /sig node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target: 1.28
    • Beta release target: 1.29
    • Stable release target: 1.31

  • [x] Alpha

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4011
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/118254
      • https://github.com/kubernetes/kubernetes/pull/119280
    • [x] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/42001

  • [x] Beta

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4238
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/121440
      • https://github.com/kubernetes/kubernetes/pull/121254
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/43435

  • [x] Stable

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4487
      • https://github.com/kubernetes/enhancements/pull/4446
      • https://github.com/kubernetes/enhancements/pull/4521
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/123315
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/45144

klueska avatar May 15 '23 20:05 klueska

/milestone v1.28

SergeyKanzhelev avatar May 26 '23 21:05 SergeyKanzhelev

/stage alpha

SergeyKanzhelev avatar Jun 06 '23 17:06 SergeyKanzhelev

/label lead-opted-in

SergeyKanzhelev avatar Jun 08 '23 07:06 SergeyKanzhelev

Hi @klueska 👋, 1.28 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise.)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.28
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like https://github.com/kubernetes/enhancements/pull/4011 will address most of these issues

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar Jun 11 '23 16:06 npolshakova

Hi @klueska, checking in once more as we approach the 1.28 enhancement freeze deadline on 01:00 UTC Friday, 16th June 2023. The status of this enhancement is marked as at risk. It looks like https://github.com/kubernetes/enhancements/pull/4011 will address most of the requirements. Let me know if I missed anything. Thanks!

npolshakova avatar Jun 14 '23 19:06 npolshakova

@npolshakova https://github.com/kubernetes/enhancements/pull/4011 has been merged

klueska avatar Jun 16 '23 15:06 klueska

Hey @klueska With all the KEP requirements in place and merged into k/enhancements, the status of this enhancement is now marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Atharva-Shinde avatar Jun 17 '23 02:06 Atharva-Shinde

Hello @klueska :wave:, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

VibhorChinda avatar Jun 22 '23 06:06 VibhorChinda

Hey again @klueska :wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • [x] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • [ ] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

  • https://github.com/kubernetes/kubernetes/pull/118254

Also please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

npolshakova avatar Jul 11 '23 22:07 npolshakova

Hey @klueska , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

Rishit-dagli avatar Jul 12 '23 15:07 Rishit-dagli

/cc @elezar who is working on this feature

klueska avatar Jul 12 '23 16:07 klueska

I have created a draft PR: https://github.com/kubernetes/website/pull/42001

elezar avatar Jul 12 '23 20:07 elezar

Hey @klueska 👋 Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/118254 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

Atharva-Shinde avatar Jul 19 '23 05:07 Atharva-Shinde

Hello @klueska @elezar wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: https://github.com/kubernetes/website/pull/42001

Rishit-dagli avatar Jul 23 '23 16:07 Rishit-dagli

/remove-label lead-opted-in

npolshakova avatar Aug 27 '23 22:08 npolshakova

I have added a KEP update link to this issue, to transition this feature to beta in 1.29

klueska avatar Sep 25 '23 10:09 klueska

Hello @klueska, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

npolshakova avatar Sep 26 '23 13:09 npolshakova

@mrunalp @SergeyKanzhelev Can you add lead-opted-in label to this issue, please? The issue was included into the SIG-Node 1.29 planning document long time ago.

bart0sh avatar Oct 03 '23 17:10 bart0sh

@mrunalp @SergeyKanzhelev can you also change milestone to 1.29 ?

bart0sh avatar Oct 03 '23 17:10 bart0sh

/milestone v1.29

SergeyKanzhelev avatar Oct 03 '23 18:10 SergeyKanzhelev

/label lead-opted-in

SergeyKanzhelev avatar Oct 03 '23 18:10 SergeyKanzhelev

Hello @klueska 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.29.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, it looks like merging of #4238 will be good to go for marking the KEP as tracked for enhancement freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

Thank you!

sanchita-07 avatar Oct 04 '23 10:10 sanchita-07

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀. The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank You!

sanchita-07 avatar Oct 05 '23 10:10 sanchita-07

Hey there @klueska ! 👋, v1.29 Docs team shadow here. Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release. Thank you!

Princesso avatar Oct 09 '23 19:10 Princesso

@Princesso done: https://github.com/kubernetes/website/pull/43435

bart0sh avatar Oct 11 '23 09:10 bart0sh

Hey again @klueska 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023:

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs of this KEP. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up ✌. Thanks :)

sanchita-07 avatar Oct 27 '23 05:10 sanchita-07

@klueska the code changes for this are in https://github.com/kubernetes/kubernetes/pull/121440 could you update the description?

elezar avatar Oct 30 '23 10:10 elezar

Hi @klueska , 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

kcmartin avatar Oct 30 '23 19:10 kcmartin

Hello @klueska 👋, 1.29 Enhancements team here.

Making sure are the following PRs related to the current KEP? With all the following implementation(code related) PRs merged into k/k, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀 Are there any other PRs other than the following ones? If there are any other PRs that need to be tracked, please let us know. Also please update the issue description with the following PR:

  • https://github.com/kubernetes/kubernetes/pull/121254

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PR for this KEP is:

  • https://github.com/kubernetes/kubernetes/pull/121440

Please let me know if there are additional test PRs we should track. Thanks!

sanchita-07 avatar Nov 01 '23 02:11 sanchita-07

@sanchita-07 Your PR list looks correct. Both PRs have been already merged. There is also one documentation PR. It's pending approval atm: https://github.com/kubernetes/website/pull/43435

bart0sh avatar Nov 06 '23 12:11 bart0sh