enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Add support for a drop-in kubelet configuration directory

Open haircommander opened this issue 1 year ago • 54 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add support for a kubelet drop-in configuration directory
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3983-drop-in-configuration
  • Discussion Link: SIG-Node April 25th meeting SIG-Arch May 4 meeting
  • Primary contact (assignee): @haircommander
  • Responsible SIGs: SIG-Node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.28
    • Beta release target (x.y): 1.30
    • Stable release target (x.y): 1.31
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4031, https://github.com/kubernetes/enhancements/pull/4242
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/119390, https://github.com/kubernetes/kubernetes/pull/121193
    • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/42013, https://github.com/kubernetes/website/pull/43542
  • [x] Beta
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4419
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/122907
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/45665

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

haircommander avatar May 04 '23 19:05 haircommander

/sig node

haircommander avatar May 04 '23 19:05 haircommander

/milestone v1.28

Adding to the milestone for tracking based on discussions at sig node meeting.

SergeyKanzhelev avatar May 05 '23 20:05 SergeyKanzhelev

+1!!! (non binding) @haircommander I'd love to help here to get this in kubelet

ffromani avatar May 09 '23 09:05 ffromani

/stage alpha

SergeyKanzhelev avatar Jun 06 '23 17:06 SergeyKanzhelev

/label lead-opted-in

SergeyKanzhelev avatar Jun 08 '23 07:06 SergeyKanzhelev

Hello @haircommander 👋, 1.28 Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.28
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to take care of:

  • Merging KEP update PR
  • The KEP number seems to be incorrect ie., should this be 3983 instead of 3893?

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Jun 13 '23 12:06 ruheenaansari34

Hi @ruheenaansari34 , I've updated the ID, thanks for pointing that out!

Is there anything else needed at the moment other than getting consensus to merge the enhancement?

yuqi-zhang avatar Jun 13 '23 19:06 yuqi-zhang

@yuqi-zhang Please take care of the following before the Enhancement freeze to meet the requirements:

  • The status in the kep.yaml should be implementable here - https://github.com/kubernetes/enhancements/blob/8e75faa941843f52b2fb15cbd5eec3ef5edd810e/keps/sig-node/3983-drop-in-configuration/kep.yaml#L7
  • Merging KEP update PR

The status of this enhancement is still marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Jun 15 '23 15:06 ruheenaansari34

Thanks! I've marked it as implementable after discussion with @haircommander . We will work to get it merged

yuqi-zhang avatar Jun 15 '23 16:06 yuqi-zhang

Thanks @yuqi-zhang :) With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀. The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

Atharva-Shinde avatar Jun 16 '23 01:06 Atharva-Shinde

Hello @haircommander :wave:, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Rishit-dagli avatar Jul 01 '23 10:07 Rishit-dagli

Hey @haircommander , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

Rishit-dagli avatar Jul 12 '23 15:07 Rishit-dagli

yes I will take care of it, thanks @Rishit-dagli !

haircommander avatar Jul 12 '23 17:07 haircommander

done! https://github.com/kubernetes/website/pull/42013

haircommander avatar Jul 13 '23 20:07 haircommander

Hey again @haircommander :wave: Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

ruheenaansari34 avatar Jul 17 '23 19:07 ruheenaansari34

Hey @haircommander 👋 Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/119390 merged as per the issue description I updated above, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

Atharva-Shinde avatar Jul 19 '23 05:07 Atharva-Shinde

Hello @haircommander wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: https://github.com/kubernetes/website/pull/42013

Rishit-dagli avatar Jul 23 '23 15:07 Rishit-dagli

thank you! I have moved it out of draft

haircommander avatar Jul 24 '23 20:07 haircommander

Hey y'all! I'm swinging by for the v1.28 Docs team. Today is the docs deadline. Is there anything we can help you with to get this merged?

katcosgrove avatar Aug 08 '23 17:08 katcosgrove

sorry I am updating it now, I will get this done soon.

haircommander avatar Aug 08 '23 19:08 haircommander

/remove-label lead-opted-in

npolshakova avatar Aug 27 '23 22:08 npolshakova

/milestone v1.29 /stage beta /label lead-opted-in

SergeyKanzhelev avatar Sep 15 '23 21:09 SergeyKanzhelev

@haircommander please send the PR to update KEP details for beta in 1.29

SergeyKanzhelev avatar Sep 15 '23 21:09 SergeyKanzhelev

Hello @haircommander 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.29.
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone: 1.29 in the kep.yaml file
  • Update the Readme perhaps

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

salehsedghpour avatar Sep 20 '23 21:09 salehsedghpour

/assign @sohankunkerkar

kannon92 avatar Sep 27 '23 13:09 kannon92

@kannon92: GitHub didn't allow me to assign the following users: sohankunkerkar.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @sohankunkerkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 27 '23 13:09 k8s-ci-robot

I'm working on this issue.

sohankunkerkar avatar Sep 27 '23 15:09 sohankunkerkar

/assign @sohankunkerkar

kannon92 avatar Sep 27 '23 15:09 kannon92

Hi @haircommander @sohankunkerkar , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like https://github.com/kubernetes/enhancements/pull/4242 will address all of the requirements.

Let me know if I missed anything. Thanks!

Please keep the issue description up-to-date with appropriate information such that PR.

salehsedghpour avatar Oct 04 '23 20:10 salehsedghpour

As #4242 is merged, the status of this enhancement is marked as tracked for enhancement freeze.

salehsedghpour avatar Oct 05 '23 08:10 salehsedghpour