enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Recursive Read-only (RRO) mounts

Open AkihiroSuda opened this issue 2 years ago • 42 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Recursive Read-only (RRO) mounts

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3857-rro-mounts

  • Discussion Link: none

  • Primary contact (assignee): @AkihiroSuda

  • Responsible SIGs: SIG-node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): v1.30
    • Beta release target (x.y): v1.31
    • Stable release target (x.y):
  • [x] Alpha

    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3858
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/123272
      • [x] https://github.com/kubernetes/kubernetes/pull/123180
      • [x] https://github.com/kubernetes-sigs/cri-tools/pull/1344
      • [x] https://github.com/containerd/containerd/pull/9787
    • [x] Docs (k/website) update PR(s):
      • [x] https://github.com/kubernetes/website/pull/45159
      • [x] https://github.com/kubernetes/website/pull/45238
  • [x] Beta

    • [X] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4668
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/125475

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

AkihiroSuda avatar Feb 08 '23 17:02 AkihiroSuda

/sig node

AkihiroSuda avatar Feb 08 '23 17:02 AkihiroSuda

adding sig storage as participating sig

/sig storage

SergeyKanzhelev avatar May 05 '23 21:05 SergeyKanzhelev

@AkihiroSuda do you want to target this KEP for 1.28?

SergeyKanzhelev avatar May 05 '23 21:05 SergeyKanzhelev

@AkihiroSuda do you want to target this KEP for 1.28?

Not necessary.

AkihiroSuda avatar May 06 '23 02:05 AkihiroSuda

@kubernetes/sig-node-leads Any chance to get this lead-opted-in for v1.29?

AkihiroSuda avatar Aug 16 '23 02:08 AkihiroSuda

ping @kubernetes/sig-node-leads 🙏

AkihiroSuda avatar Sep 18 '23 18:09 AkihiroSuda

@kubernetes/sig-node-leads Will this be considered for lead-opted-in in the v1.30 milestone?

AkihiroSuda avatar Oct 03 '23 21:10 AkihiroSuda

cc @mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev for the question above about v1.30 milestone

AkihiroSuda avatar Oct 10 '23 01:10 AkihiroSuda

+1 for v1.30

  • We may tag this as v1.30 and get some early input.

adding sig storage as participating sig

@SergeyKanzhelev do we have to check with sig storage leads about this KEP?

pacoxu avatar Oct 16 '23 09:10 pacoxu

@mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev

PTAL. If this KEP isn't going to be accepted, I'll just modify the default behavior of containerd to treat "readonly" as "recursive readonly". Small portion of users may find this to be a breaking change, but probably this is subtle enough. https://github.com/kubernetes/enhancements/pull/3858#discussion_r1351281024

AkihiroSuda avatar Jan 05 '24 04:01 AkihiroSuda

@SergeyKanzhelev added sig storage as participating sig for this KEP. The proposal makes sense to me, but I still want to hear from the sig storage members. cc @jsafrane @msau42 @xing-yang Can you please review the proposal and provide your feedback? Thanks! If accepted, this KEP may be able to have an alpha implement in 1.30.

carlory avatar Jan 17 '24 08:01 carlory

Didn't get lead-opted-in. Giving up.

Alternative:

  • https://github.com/containerd/containerd/pull/9713

AkihiroSuda avatar Jan 30 '24 19:01 AkihiroSuda

Reopening

https://github.com/kubernetes/enhancements/pull/3858#issuecomment-1925408678

AkihiroSuda avatar Feb 04 '24 04:02 AkihiroSuda

/milestone 1.30 /stage alpha /label lead-opted-in

mrunalp avatar Feb 05 '24 18:02 mrunalp

@mrunalp: The provided milestone is not valid for this repository. Milestones in this repository: [v1.25, v1.27, v1.28, v1.29, v1.30, v1.31]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.30 /stage alpha /label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 05 '24 18:02 k8s-ci-robot

/milestone v1.30

mrunalp avatar Feb 05 '24 18:02 mrunalp

Hello @AkihiroSuda 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.30.
  • [x] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • The production readiness review should be completed. One question appears unanswered.
  • Make sure the PR with the information get merged before enhancement freeze, I just found this PR.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

pnbrown avatar Feb 07 '24 16:02 pnbrown

KEP readme using the latest template has been merged into the k/enhancements repo.

Updated to the latest template

The production readiness review should be completed. One question appears unanswered.

Answered.

AkihiroSuda avatar Feb 07 '24 16:02 AkihiroSuda

Thank you. I will move it from At Risk when the PR gets merged.

pnbrown avatar Feb 07 '24 17:02 pnbrown

Draft PRs:

  • https://github.com/kubernetes/kubernetes/pull/123180
  • https://github.com/kubernetes-sigs/cri-tools/pull/1344
  • https://github.com/containerd/containerd/pull/9787

AkihiroSuda avatar Feb 07 '24 21:02 AkihiroSuda

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

pnbrown avatar Feb 09 '24 02:02 pnbrown

Hi @AkihiroSuda ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

Checksumz avatar Feb 15 '24 09:02 Checksumz

Hello @AkihiroSuda @johnbelamaric 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

Reading the KEP, this requires a good amount of documentation, marking this as Need Docs. Thanks!

Vyom-Yadav avatar Feb 15 '24 17:02 Vyom-Yadav

docs

Here:

  • https://github.com/kubernetes/website/pull/45159

AkihiroSuda avatar Feb 16 '24 01:02 AkihiroSuda

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

Opened a placeholder PR:

  • https://github.com/kubernetes/website/pull/45238

AkihiroSuda avatar Feb 21 '24 06:02 AkihiroSuda

Hey again @AkihiroSuda @johnbelamaric 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

  • https://github.com/kubernetes/kubernetes/pull/123180
  • https://github.com/kubernetes-sigs/cri-tools/pull/1344

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

pnbrown avatar Feb 29 '24 00:02 pnbrown

With the exception request being approved, this can now be marked as tracked for code freeze.

salehsedghpour avatar Mar 06 '24 18:03 salehsedghpour