enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Kube-proxy improved ingress connectivity reliability

Open alexanderConstantinescu opened this issue 2 years ago โ€ข 52 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Improve the reliability of ingress connectivity serviced by Kube-proxy
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3836-kube-proxy-improved-ingress-connectivity-reliability
  • Discussion Link:
  • Primary contact (assignee): @alexanderConstantinescu
  • Responsible SIGs: sig-network
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.28
    • Beta release target (x.y): 1.30
    • Stable release target (x.y): 1.31
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3837
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/116470
    • [ ] Docs (k/website) update PR(s):
  • [x] Beta
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4258,
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/122914
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/45678
  • [x] Stable
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/4656
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/125082
    • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig-network /cc @thockin @danwinship

alexanderConstantinescu avatar Feb 03 '23 16:02 alexanderConstantinescu

/sig network

alexanderConstantinescu avatar Feb 03 '23 16:02 alexanderConstantinescu

This enhancement meets all the requirements for inclusion in v1.27 and is now tracked for the release!

marosset avatar Feb 10 '23 02:02 marosset

Hi @alexanderConstantinescu :wave:,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

marosset avatar Mar 08 '23 20:03 marosset

Hi @alexanderConstantinescu ๐Ÿ‘‹ , Iโ€™m reaching out from the 1.27 Release Docs team. This enhancement is marked as โ€˜Needs Docsโ€™ for the 1.27 release. Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. Please feel free to reach out with any questions. Thanks!

taniaduggal avatar Mar 10 '23 14:03 taniaduggal

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear /remove-label tracked/yes /label tracked/no

marosset avatar Mar 15 '23 00:03 marosset

@alexanderConstantinescu https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3836-kube-proxy-improved-ingress-connectivity-reliability/kep.yaml still says Alpha and needs a PRR touch to move to beta

thockin avatar Jun 13 '23 20:06 thockin

Thanks for the reminder, sorry for being late. Here's the PR: https://github.com/kubernetes/enhancements/pull/4087

alexanderConstantinescu avatar Jun 13 '23 21:06 alexanderConstantinescu

Hello @alexanderConstantinescu ๐Ÿ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.28
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

aramase avatar Jun 14 '23 04:06 aramase

Hey @alexanderConstantinescu

This is a nit that needs to be addressed: Add the acknowledgement under the Test Plan section.

I won't decline this KEP for the Enhancements freeze because of this change but would be great to get a PR ready addressing them. The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Atharva-Shinde avatar Jun 15 '23 12:06 Atharva-Shinde

@Atharva-Shinde : Addressed for both 3458 and 3836 with https://github.com/kubernetes/enhancements/pull/4095

alexanderConstantinescu avatar Jun 15 '23 15:06 alexanderConstantinescu

Hello @alexanderConstantinescu! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

katcosgrove avatar Jun 21 '23 13:06 katcosgrove

Sorry for the late reply @katcosgrove :

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

No, it does not.

alexanderConstantinescu avatar Jul 05 '23 16:07 alexanderConstantinescu

Hey again @alexanderConstantinescu:wave:

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Hereโ€™s the enhancementโ€™s state for the upcoming code freeze:

  • [x] All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • [x] All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.
    • https://github.com/kubernetes/kubernetes/pull/116470

If there are any other k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

aramase avatar Jul 17 '23 23:07 aramase

Hey @alexanderConstantinescu ๐Ÿ‘‹ Enhancements Lead here, With https://github.com/kubernetes/kubernetes/pull/116470 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

Atharva-Shinde avatar Jul 19 '23 05:07 Atharva-Shinde

I am tracking this for beta in 1.29 - is that correct?

thockin avatar Aug 17 '23 17:08 thockin

I am tracking this for beta in 1.29 - is that correct?

Yes, that is correct.

alexanderConstantinescu avatar Aug 24 '23 14:08 alexanderConstantinescu

Hello @alexanderConstantinescu! ๐Ÿ‘‹ 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar Sep 21 '23 18:09 npolshakova

Hi @alexanderConstantinescu, just checking in once more as we approach the 1.29 enhancement freeze deadline this week on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.

It looks like https://github.com/kubernetes/enhancements/pull/4258 will address most of the requirements. Let me know if I missed anything. Thanks!

npolshakova avatar Oct 03 '23 13:10 npolshakova

It looks like https://github.com/kubernetes/enhancements/pull/4258 will address most of the requirements. Let me know if I missed anything. Thanks!

Hi @npolshakova ! That PR has merged and should fulfill all necessary requirements for progressing this KEP to the next phase. Let me know if anything is missing, but this KEP should be ready now for the next Kube release.

alexanderConstantinescu avatar Oct 05 '23 09:10 alexanderConstantinescu

Looks good! This enhancement is now tracked for enhancement freeze. ๐Ÿš€

npolshakova avatar Oct 05 '23 14:10 npolshakova

Hi @alexanderConstantinescu :wave:, v1.29 Docs Shadow here Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

harshitasao avatar Oct 11 '23 08:10 harshitasao

Hey again @alexanderConstantinescu ๐Ÿ‘‹, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs of this KEP (including https://github.com/kubernetes/enhancements/pull/4258) under a new beta section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

npolshakova avatar Oct 16 '23 23:10 npolshakova

Hi @alexanderConstantinescu ! ๐Ÿ‘‹ from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

kcmartin avatar Oct 30 '23 18:10 kcmartin

Hello @alexanderConstantinescu ๐Ÿ‘‹, 1.29 Enhancements team here.

With https://github.com/kubernetes/enhancements/pull/4258 merged, all the tracked implementation(code related) PRs are merged as per the issue description and this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! ๐Ÿš€

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. Please let me know if there are any test PRs we should track. Thanks!

npolshakova avatar Nov 01 '23 01:11 npolshakova

/remove-label lead-opted-in

salehsedghpour avatar Jan 06 '24 16:01 salehsedghpour

Hello ๐Ÿ‘‹ 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

salehsedghpour avatar Jan 16 '24 23:01 salehsedghpour

Pinging this after sig-net - let's decide if this moves to beta in 1.30

thockin avatar Jan 19 '24 00:01 thockin

Hello @alexanderConstantinescu ๐Ÿ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage beta for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • [x] Complete the PRR review process and merge it into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

tjons avatar Jan 31 '24 12:01 tjons

@tjons : I made a mistake in the last release and got a prr-review for Beta, but forgot to update the code afterwards. In this release we're only updating the code and the prr-review file already exists, see: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3836.yaml

Is this fine?

alexanderConstantinescu avatar Jan 31 '24 14:01 alexanderConstantinescu

@alexanderConstantinescu thanks for the update! This should be fine... With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze ๐Ÿš€

tjons avatar Feb 01 '24 11:02 tjons