enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

WIP: Update KEP with criteria for GA

Open mimowo opened this issue 2 years ago • 1 comments

  • One-line PR description: Update graduation criteria for GA
  • Issue link: https://github.com/kubernetes/enhancements/issues/3329
  • Other comments:

mimowo avatar Jan 19 '23 14:01 mimowo

/sig node as a participating sig + the proposed changes involve kubelet

mimowo avatar Jan 26 '23 14:01 mimowo

Please review

/assign @alculquicondor @soltysh for sig-apps POV /assign @bobbypage @SergeyKanzhelev for sig-node POV

mimowo avatar Jan 27 '23 10:01 mimowo

@bobbypage @rphillips @smarterclayton ptal

mrunalp avatar Jan 31 '23 18:01 mrunalp

I don't see any large issues with proposal here, but I suggested a few updates to the wording in the KEP to be a bit more precise on the changes here.

bobbypage avatar Feb 01 '23 02:02 bobbypage

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 02 '23 10:02 k8s-ci-robot

LGTM, but I think the official one belongs to SIG Node @SergeyKanzhelev

alculquicondor avatar Feb 02 '23 16:02 alculquicondor

/assign @johnbelamaric for update to Prod Readiness questionnaire

alculquicondor avatar Feb 03 '23 18:02 alculquicondor

@bobbypage @SergeyKanzhelev I've updated the PR, addressing the comments. PTAL and let me know if there is something more requiring an update.

mimowo avatar Feb 06 '23 11:02 mimowo

I have one more comment about the terminology used in the KEP (terminating vs deleting), but LGTM on the content, thank you for all of the updates and clarifying the scenarios.

bobbypage avatar Feb 07 '23 05:02 bobbypage

Thanks, this looks good from a PRR perspective, except we have added one question to the PRR this cycle: https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md?plain=1#L723 Can you answer that please?

Done, PTAL. The feature only introduces an additional API PATCH call, what is answered in the other point.

mimowo avatar Feb 07 '23 11:02 mimowo

Ok, PRR looks good and is approved (no prow command needed this time, but want to make it explicit for the enhancements team).

johnbelamaric avatar Feb 07 '23 17:02 johnbelamaric

Thanks for all the updates and clarifications in the KEP!

/lgtm

bobbypage avatar Feb 07 '23 23:02 bobbypage

Thanks @bobbypage

I also reviewed it.

/lgtm /approve from SIG Node perspective.

dchen1107 avatar Feb 07 '23 23:02 dchen1107

@bobbypage @dchen1107 thank you for completing the review!

mimowo avatar Feb 08 '23 07:02 mimowo