kubernetes
KEP-3695: extend pod resource API to for DRA
Signed-off-by: Moshe Levi [email protected]
- One-line PR description: Extend pod resource API to for Dynamic Resource Allocation
- Issue link: https://github.com/kubernetes/enhancements/issues/3695
- Other comments:
Hi @moshe010. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This PR seems to be missing the required file in keps/prod-readiness/sig-node following the template: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/template/nnnn.yaml
Just to make sure, did you also follow the latest template for the KEP itself?: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template
This PR seems to be missing the required file in
keps/prod-readiness/sig-nodefollowing the template: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/template/nnnn.yaml
I wasn't aware of it. Who should I put as the approver? should I just pick one from the list https://github.com/kubernetes/enhancements/blob/master/OWNERS_ALIASES#L191-L194?
Just to make sure, did you also follow the latest template for the KEP itself?: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template Yes I used the latest template.
This PR seems to be missing the required file in
keps/prod-readiness/sig-nodefollowing the template: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/template/nnnn.yamlI wasn't aware of it. Who should I put as the approver? should I just pick one from the list https://github.com/kubernetes/enhancements/blob/master/OWNERS_ALIASES#L191-L194?
Yes, please pick one. The PRR reviewers will rebalance the load internally and suggest a replacement should the one you picked turn out to be overloaded.
I see there are other reviewers still active in this KEP. I'll wait for them and then have my final pass (and likely add my real LGTM).
/cc @johnbelamaric Could we please get a PRR review by the deadline this Thursday.
I would argue this is actually an extension of the DRA feature, so maybe the right way to deal with this is to (additionally) gate this feature by the DynamicResourceAllocationFeatureGate. That way both feature gates must be enabled for this feature to be turned on.
I don’t want to block this work on DRA reaching beta, because these APIs are needed for an important use-case of DRA and are therefore useful in their own right to help test / influence changes to DRA before it reaches beta.
This KEP looks ready to go from my perspective. There are still 2 outstanding comments, but I am OK moving forward with the KEP in its current state if there are no futher comments:
- https://github.com/kubernetes/enhancements/pull/3738/files#r1096531863
- https://github.com/kubernetes/enhancements/pull/3738/files#r1096544300
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dchen1107, johnbelamaric, klueska, moshe010
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~keps/prod-readiness/OWNERS~~ [johnbelamaric]
- ~~keps/sig-node/OWNERS~~ [dchen1107,johnbelamaric]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment