enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Elastic Indexed Jobs

Open ahg-g opened this issue 2 years ago β€’ 35 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Indexed Jobs with unset completions

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3715-elastic-indexed-job/README.md

  • Discussion Link: https://github.com/kubernetes/kubernetes/issues/114862

  • Primary contact (assignee): ahg-g

  • Responsible SIGs: apps

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y):
    • Beta release target (x.y): 1.27
    • Stable release target (x.y): 1.31
  • [x] Beta

    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3724
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/115236
      • https://github.com/kubernetes/kubernetes/pull/115349
    • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/39999
  • [ ] Stable

    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4718
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/125751
    • [ ] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/46991

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

ahg-g avatar Jan 09 '23 23:01 ahg-g

/sig apps

sftim avatar Jan 10 '23 19:01 sftim

/wg batch

sftim avatar Jan 10 '23 19:01 sftim

/assign

ahg-g avatar Jan 11 '23 00:01 ahg-g

/stage alpha /milestone v1.27 /label lead-opted-in

soltysh avatar Jan 20 '23 13:01 soltysh

Hello @ahg-g πŸ‘‹, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27

~~There is a slight confusion here, the KEP states that this enhancement is targeting beta but it appears that there was no alpha stage in the first place to graduate to beta, and the lead has opted in for alpha. So is this enhancement targeting alpha or beta? Please take a look and I'll update the stage of this KEP accordingly.~~

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde avatar Jan 31 '23 19:01 Atharva-Shinde

@Atharva-Shinde can you point to what is missing from the test plan section? Note that the KEP is proposing to graduate to beta right away, so we don't have the integration and e2e tests yet.

ahg-g avatar Jan 31 '23 21:01 ahg-g

Note that the KEP is proposing to graduate to beta right away, so we don't have the integration and e2e tests yet.

ack. I've updated my comment. You don't need to update your test plan :)

Atharva-Shinde avatar Feb 01 '23 16:02 Atharva-Shinde

@ahg-g, With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde avatar Feb 08 '23 18:02 Atharva-Shinde

Hi @ahg-g, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as β€˜Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

LukeMwila avatar Mar 11 '23 05:03 LukeMwila

Hey again @ahg-g πŸ‘‹ Enhancements team here, Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [X] All PR/s are fully merged by the code freeze deadline.
    • https://github.com/kubernetes/kubernetes/pull/115236
    • https://github.com/kubernetes/kubernetes/pull/115349

Also please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

Atharva-Shinde avatar Mar 12 '23 16:03 Atharva-Shinde

Hi @Atharva-Shinde, yes all relevant PRs are merged, I updated the description.

ahg-g avatar Mar 12 '23 17:03 ahg-g

/stage beta

marosset avatar Mar 20 '23 17:03 marosset

@soltysh we will try to graduate this to GA in this release.

/label lead-opted-in /milestone v1.30

ahg-g avatar Jan 17 '24 00:01 ahg-g

/assign @danielvegamyhre

ahg-g avatar Jan 17 '24 00:01 ahg-g

/stage stable

ahg-g avatar Jan 17 '24 03:01 ahg-g

The newly proposed successPolicy changes the meaning of completions. That is we run number of pods according to completions, but we might mark the job as Complete/Succeeded earlier, before all the pods have finished (can also result in the pods to be discarded prematurely).

This might not affect Elastic Indexed Jobs feature, but there might be new cross-field validations (completions, successPolicy, indexes). And possible issues might come to light when implementing/testing the new feature with regards to mutable completions field.

I think it might be better to wait with graduating this feature to stable until we have a clearer picture.

What is your opinion on this? @ahg-g @danielvegamyhre @soltysh

atiratree avatar Jan 24 '24 14:01 atiratree

I am good with that, please feel free to remove it from the milestone.

ahg-g avatar Jan 26 '24 04:01 ahg-g

That makes sense, thanks for bringing this up.

danielvegamyhre avatar Jan 26 '24 04:01 danielvegamyhre

What is your opinion on this? @ahg-g @danielvegamyhre @soltysh

That's a good suggestion, thx Filip for catching this. /remove-label lead-opted-in /milestone clear

soltysh avatar Jan 26 '24 12:01 soltysh

@salehsedghpour fyi: this is being removed from 1.30

soltysh avatar Jan 26 '24 12:01 soltysh

/stage beta

soltysh avatar Jan 26 '24 12:01 soltysh

Hello @ahg-g πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

Just want to confirm that this work has been postponed. The status of this enhancement is marked as Removed from Milestone for v1.30 release. (correct me, if otherwise)

AnaMMedina21 avatar Feb 07 '24 18:02 AnaMMedina21

/milestone clear

salehsedghpour avatar Feb 09 '24 02:02 salehsedghpour

https://github.com/kubernetes/enhancements/pull/4062 scaled back and did not change the meaning of the Complete condition in the end. So this feature should be okay to graduate @ahg-g @danielvegamyhre

atiratree avatar May 29 '24 14:05 atiratree

I am ok with that, @soltysh do you want to opt this one in?

ahg-g avatar May 29 '24 15:05 ahg-g

@atiratree do you have the bandwidth to work on graduating it?

ahg-g avatar May 29 '24 15:05 ahg-g

Sorry, I do not.

atiratree avatar May 30 '24 11:05 atiratree

/label lead-opted-in /stage stable /milestone v1.31

soltysh avatar Jun 04 '24 17:06 soltysh

Hello @ahg-g πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting stage stable for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline of Thursday 6th June 2024 so that the PRR team has enough time to review your KEP.

For this KEP, it looks like we still need to do the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

prianna avatar Jun 05 '24 15:06 prianna

Hello @ahg-g πŸ‘‹, 1.31 Docs Shadow here.

Does the work related to this KEP planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

salaxander avatar Jun 12 '24 16:06 salaxander