enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Cloud Dual-Stack --node-ip Handling

Open danwinship opened this issue 2 years ago β€’ 28 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Synchronize --node-ip behavior between cloud-provider and non-cloud-provider clusters, to improve dual-stack behavior in clouds.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3705-cloud-node-ips
  • Discussion Link: https://github.com/kubernetes/kubernetes/issues/111695#issuecomment-1235429090 (and following comments), https://github.com/kubernetes/enhancements/pull/1665
  • Primary contact (assignee): @danwinship
  • Responsible SIGs: sig-network, with help from sig-node and sig-cloud-provider
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.27
    • Beta release target (x.y): 1.29
    • Stable release target (x.y): 1.30
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3706
      • https://github.com/kubernetes/enhancements/pull/3798
      • https://github.com/kubernetes/enhancements/pull/3849
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/116305
    • [x] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/40188
  • [x] Beta
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3898
      • https://github.com/kubernetes/enhancements/pull/3975
      • https://github.com/kubernetes/enhancements/pull/4170
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/118329
      • https://github.com/kubernetes/kubernetes/pull/120275
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/42875
  • [x] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4415
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/123134
    • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/45028

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

danwinship avatar Dec 30 '22 19:12 danwinship

/sig network /sig node /sig cloud-provider

danwinship avatar Dec 30 '22 19:12 danwinship

/label lead-opted-in

@thockin - FYI ^^

wojtek-t avatar Feb 02 '23 09:02 wojtek-t

Hello @danwinship @thockin πŸ‘‹, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme
  • Referring to this discussion, we need to add a reviewer.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde avatar Feb 06 '23 16:02 Atharva-Shinde

/stage alpha

Atharva-Shinde avatar Feb 06 '23 17:02 Atharva-Shinde

Thanks @danwinship, with all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well :)

Atharva-Shinde avatar Feb 08 '23 13:02 Atharva-Shinde

Hi @danwinship :wave:, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as β€˜Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. Please feel free to reach out with any questions. Thanks!

Rishit-dagli avatar Mar 10 '23 04:03 Rishit-dagli

Hey again @danwinship πŸ‘‹ Enhancements team here, Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PR/s are fully merged by the code freeze deadline.
    • https://github.com/kubernetes/kubernetes/pull/115338
    • https://github.com/kubernetes/kubernetes/pull/112184
    • https://github.com/kubernetes/kubernetes/pull/116305

Also please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

Atharva-Shinde avatar Mar 12 '23 16:03 Atharva-Shinde

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear /remove-label tracked/yes /label tracked/no

marosset avatar Mar 15 '23 00:03 marosset

@marosset: Those labels are not set on the issue: tracked/yes

In response to this:

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear /remove-label tracked/yes /label tracked/no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 15 '23 00:03 k8s-ci-robot

/label tracked/yes /milestone v1.27

salaxander avatar Mar 15 '23 23:03 salaxander

Hey folks! With that last PR merged I've marked the exception as complete in our tracking. Thanks!!

salaxander avatar Mar 16 '23 14:03 salaxander

@danwinship @thockin was there a Docs PR opened against dev-1.27 branch in the k/website repo?

If not, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

mickeyboxell avatar Mar 21 '23 03:03 mickeyboxell

Marked this KEP as having a merged Docs PR.

Ref: https://github.com/kubernetes/website/pull/40188

cc: @mickeyboxell

Rishit-dagli avatar Apr 03 '23 21:04 Rishit-dagli

Milestoning for 1.28 but @danwinship to make a call on next goal.

thockin avatar Apr 27 '23 16:04 thockin

/assign

danwinship avatar Aug 17 '23 16:08 danwinship

this targets beta:

/stage beta

SergeyKanzhelev avatar Sep 15 '23 19:09 SergeyKanzhelev

Hello @danwinship, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

npolshakova avatar Sep 22 '23 19:09 npolshakova

Hello @danwinship πŸ‘‹, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: v1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sreeram-venkitesh avatar Sep 27 '23 19:09 sreeram-venkitesh

Hi @danwinship πŸ‘‹, v1.29 Docs Shadow here Does this enhancement work planned for v1.29 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

harshitasao avatar Oct 11 '23 08:10 harshitasao

@harshitasao The only docs work needed was https://github.com/kubernetes/website/pull/42875 which has merged since the last time I looked at this enhancement. I updated the checklist to reflect that.

danwinship avatar Oct 16 '23 14:10 danwinship

Hey again @danwinship πŸ‘‹ v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [x] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

This KEP is tracked for code freeze since all the associated code PRs have been merged for the beta stage and has been updated in the issue description πŸŽ‰

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

sreeram-venkitesh avatar Oct 27 '23 18:10 sreeram-venkitesh

Hi @danwinship ! πŸ‘‹ from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

kcmartin avatar Oct 30 '23 19:10 kcmartin

/remove-label lead-opted-in

salehsedghpour avatar Jan 06 '24 16:01 salehsedghpour

Hello πŸ‘‹ 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

salehsedghpour avatar Jan 16 '24 23:01 salehsedghpour

Hello @danwinship πŸ‘‹, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [X] KEP readme has up-to-date graduation criteria.
  • [X] KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

pnbrown avatar Feb 07 '24 15:02 pnbrown

Hi @danwinship,

πŸ‘‹ from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

a-mccarthy avatar Feb 15 '24 13:02 a-mccarthy

Hey again @danwinship πŸ‘‹ Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [x] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

pnbrown avatar Feb 29 '24 00:02 pnbrown

GA'd in 30, cleanup in 32

thockin avatar May 08 '24 16:05 thockin

Hi! v1.31 Enhancements lead here πŸ‘‹πŸΌ

I'm assuming the status will be updated to implemented in v1.32 along with the cleanup, right? I'll remove the lead-opted-in label and remove this KEP from the v1.31 tracking board. Please let me know if this works.

/remove-label lead-opted-in

sreeram-venkitesh avatar May 15 '24 03:05 sreeram-venkitesh

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 13 '24 04:08 k8s-triage-robot