Reserve Nodeport Ranges For Dynamic And Static Port Allocation

[xuzhenglun]

• One-line PR description: KEP-3668: adding KEP

• Issue link: https://github.com/kubernetes/enhancements/issues/3668

• Other comments: https://github.com/kubernetes/kubernetes/issues/114129

[k8s-ci-robot]

Welcome @xuzhenglun!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

/ok-to-test

some comments that need to be addressed, but overall is LGTM

/assign @thockin

[xuzhenglun]

/ok-to-test

some comments that need to be addressed, but overall is LGTM

/assign @thockin

Thanks for reviewing, I'll take a look and fix it right now.

[xuzhenglun]

/retest

[xuzhenglun]

/retest

[thockin]

I have no objections to this, but I think @aojea will take ownership for it. :)

/assign aojea /unassign thockin

[aojea]

I think that you need a PRR entry too , like https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3070.yaml

@wojtek-t do you want to take on this from the PRR side? is just a copy of https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3070-reserved-service-ip-range , but nodePorts are less trickier since the range are smaller and there are only one range

[xuzhenglun]

I think that you need a PRR entry too , like https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3070.yaml

@wojtek-t do you want to take on this from the PRR side? is just a copy of https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/3070-reserved-service-ip-range , but nodePorts are less trickier since the range are smaller and there are only one range

@aojea Thank you, It's done.

@wojtek-t Forgive me for taking the liberty of putting you on the list before I get a confirmation in order to move this along quickly. If it doesn't fit let me know and I'll revise it.

[aojea]

/lgtm /approve

[wojtek-t]

@wojtek-t Forgive me for taking the liberty of putting you on the list before I get a confirmation in order to move this along quickly. If it doesn't fit let me know and I'll revise it.

I'm fine with taking this. Please work with the SIG leadership to get SIG-level approval first and I will take a look at it after that.

[aojea]

I'm fine with taking this. Please work with the SIG leadership to get SIG-level approval first and I will take a look at it after that.

I have no objections to this, but I think @aojea will take ownership for it. :)

@thockin can you approve? I've already reviewed it

[xuzhenglun]

@thockin please take a look if you have time.

[thockin]

/approve

on behalf of @aojea

[aojea]

I'm fine with taking this. Please work with the SIG leadership to get SIG-level approval first and I will take a look at it after that.

@wojtek-t this is ready for PRR

[xuzhenglun]

@wojtek-t ping friendly

please take a look at this KEP. if there is anything that needs to change, I'm happy for revising.

[xuzhenglun]

Just two minor nits, and you will be good to go for Alpha.

thanks for your review and they should all be fixed now. Is that now good for you?

[wojtek-t]

Yes - it looks good.

/lgtm /approve PRR

Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin, wojtek-t, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~keps/prod-readiness/OWNERS~~ [wojtek-t]
• ~~keps/sig-network/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment