enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Kubelet Resource Plugin Manager Refactor

Open obiTrinobiIntel opened this issue 3 years ago • 6 comments

Enhancement Description

  • One-line enhancement description: Kubelet Resource Plugin Manager Refactor

  • Kubernetes Enhancement Proposal:

  • Discussion Link: https://docs.google.com/document/d/1O5G4HMhfyC9AdaGai1eV5OJpCugV3vFIW19_FCuMOaY/edit?resourcekey=0-qLkKucnl3Y2wJ_WEfZPRVQ#heading=h.xgjl2srtytjt

  • Primary contact (assignee): @obiTrinobiIntel @catblade

  • Responsible SIGs: SIG Node

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.27
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [x ] Alpha

    • [x ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

obiTrinobiIntel avatar Dec 05 '22 14:12 obiTrinobiIntel

/sig sig-node /assign @obiTrinobiIntel

catblade avatar Dec 05 '22 19:12 catblade

@catblade: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them.

In response to this:

/sig sig-node /assign @obiTrinobiIntel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 05 '22 19:12 k8s-ci-robot

/sig node

catblade avatar Dec 05 '22 19:12 catblade

/assign @catblade

catblade avatar Dec 05 '22 19:12 catblade

Would a refactor need a KEP?

(if this issue is about changing behavior in a way that's visible to end users, that's not a refactor)

sftim avatar Jan 10 '23 21:01 sftim

so it has 2 components: 1 absolutely is a refactor, mostly to clean up the underlying code. But the other part is to enable us to use managers as plugins that may also manage CPUs and Memory. We can rename the issue if necessary, if you think that worthwhile.

catblade avatar Jan 10 '23 21:01 catblade

/label lead-opted-in /milestone v1.27

dchen1107 avatar Jan 31 '23 19:01 dchen1107

/label lead-opted-in

due to large scope of a change and many open questions leads have doubt it will make it. Do you think you can find PRR reviewer/approver before the PRR freeze?

SergeyKanzhelev avatar Feb 02 '23 18:02 SergeyKanzhelev

/stage alpha

SergeyKanzhelev avatar Feb 03 '23 01:02 SergeyKanzhelev

Hello @obiTrinobiIntel 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.27
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like https://github.com/kubernetes/enhancements/pull/3803 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

marosset avatar Feb 03 '23 20:02 marosset

Unfortunately, this exception hasn't satisfied all of the requirements by the v1.27 code freeze and will be removed from the milestone.

If you feel it is important to include this exception in v1.27 please consider filing an exception as outlined at https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

marosset avatar Feb 10 '23 02:02 marosset

based on sig node meeting 5/2/2023 this is being worked on for 1.28. Adding the milestone to track

/milestone v1.28

SergeyKanzhelev avatar May 05 '23 21:05 SergeyKanzhelev

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now, If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

salehsedghpour avatar Jan 16 '24 23:01 salehsedghpour

@salehsedghpour , unfortunately, we do not have the staff to do this right now, so if we want to leave it open, we can. Or we can close it for now.

catblade avatar Jan 17 '24 13:01 catblade

/close

as discussed during SIG Node triage meeting, closing this for now. Please reopen if this will be continued

SergeyKanzhelev avatar Jan 26 '24 23:01 SergeyKanzhelev