enhancements
enhancements copied to clipboard
Add CPU Manager to kubelet
Enhancement Description
- One-line enhancement description (can be used as a release note): graduate CPUManager to GA
- Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/3350
- Discussion Link: https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#
- Primary contact (assignee): @fromanirh
- Responsible SIGs: sig-node
- Enhancement target (which target equals to which milestone):
- Alpha release target: 1.8
- Beta release target: 1.10
- Stable release target: 1.26
- [X] Stable
- [X] KEP (
k/enhancements
) update PR(s): https://github.com/kubernetes/enhancements/pull/3350 - [X] Code (
k/k
) update PR(s):- https://github.com/kubernetes/kubernetes/pull/112855
- https://github.com/kubernetes/kubernetes/pull/113018
- [X] Docs (
k/website
) update(s):- https://github.com/kubernetes/website/pull/37686
- https://github.com/kubernetes/website/pull/37435
- [X] KEP (
Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The original issue (https://github.com/kubernetes/enhancements/issues/375) is closed and missed the proper labeling. Fixing with this one.
CPU Manager is consumed by multiple parties and trated as GA. We want to avoid the perma-beta status
/sig node
/label lead-opted-in /milestone v1.26
@derekwaynecarr @dchen1107 @SergeyKanzhelev adding labels based on request on slack thread - https://kubernetes.slack.com/archives/C0BP8PW9G/p1664537014576579
please clear them if it is not appropriate.
/label tracked/yes /stage stable
/label lead-opt-in
volunteer identified in sig to see this to stable in sig-node.
@derekwaynecarr: The label(s) `/label lead-opt-in
cannot be applied. These labels are supported:
api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes`
In response to this:
/label lead-opt-in
volunteer identified in sig to see this to stable in sig-node.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/label lead-opted-in
Hello @fromanirh 👋, 1.26 Enhancements team here.
Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.
This enhancement is targeting for stage stable
for 1.26 (correct me, if otherwise)
Here's where this enhancement currently stands:
- [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
- [ ] KEP status is marked as
implementable
forlatest-milestone: 1.26
- [ ] KEP readme has a updated detailed test plan section filled out
- [ ] KEP readme has up-to-date graduation criteria
- [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.
For this KEP, we would just need to update:
- the latest milestone to 1.26, here
- update the PR https://github.com/kubernetes/enhancements/pull/3350 to meet the requirements for enhancement freeze, and then get it merged.
The status of this enhancement is marked as at risk
. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
With #3350 merged, this is tracked
for v1.26
I recommend cracking on with early work on a docs update so that these are GA quality (or have PRs open to make them be) by the appropriate review deadline.
Reflects the KEP update already merged: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3570-cpumanager/kep.yaml#L35-L38
/approve /lgtm
Hey @fromanirh 👋,
Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.
Please ensure the following items are completed:
- [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the issue description above(for tracking purposes). If there are any other PRs beyond: https://github.com/kubernetes/kubernetes/pull/113018 and https://github.com/kubernetes/kubernetes/pull/112855, please include them in the issue description too.
- [ ] All PRs are fully merged by the code freeze deadline.
As always, we are here to help should questions come up. Thanks :)
With those PRs merged, we have this marked as tracked
for code freeze.
Hello @fromanirh 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.26
branch in the k/website
repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
Any doubt, reach us! Thank you!
Hi @fromanirh - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3570-cpumanager/kep.yaml setting the status to implemented
and then close this issue.
Thanks!
Hi @fromanirh - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3570-cpumanager/kep.yaml setting the status to
implemented
and then close this issue. Thanks!
sure thing: https://github.com/kubernetes/enhancements/pull/3687 Thanks!
Maybe the title of this issue should be “Add CPU Manager to kubelet”
(because it's odd to have a kep.yaml
with GA in the enhancement title, rather than just the phase)
/retitle Add CPU Manager to kubelet
/milestone v1.27
/label lead-opted-in
/milestone v1.26
sorry, I saw opened PR and confused with topology manager being graduated this release. Sorry
Hello @ffromani 👋, 1.27 Enhancements team here.
Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.
This enhancement is targeting for stage stable
for 1.27 (correct me, if otherwise)
Here's where this enhancement currently stands:
- [x] KEP readme using the latest template has been merged into the k/enhancements repo.
- [ ] KEP status is marked as
implementable
forlatest-milestone: 1.27
- [x] KEP readme has a updated detailed test plan section filled out
- [x] KEP readme has up to date graduation criteria
- [x] KEP has a production readiness review that has been completed and merged into k/enhancements.
It looks like https://github.com/kubernetes/enhancements/pull/3687 will address the last issue.
The status of this enhancement is marked as at risk
. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
hi @npolshakova ! this enhancement was done in the 1.26 cycle and labeled by mistake (https://github.com/kubernetes/enhancements/issues/3570#issuecomment-1414950639). We only need to mark the related KEP implementable to complete, but AFAIK that simple PR can be merged right away (https://github.com/kubernetes/enhancements/pull/3687)
Thanks for the update- I'll remove this from the 1.27 tracking then!
/remove-label lead-opted-in