enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Pod Scheduling Readiness

Open Huang-Wei opened this issue 2 years ago • 97 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add a schedulingGates field to the Pod spec that marks a Pod's scheduling readiness.
  • Kubernetes Enhancement Proposal: 3521-pod-scheduling-readiness/README.md
  • Discussion Link: https://docs.google.com/document/d/1cPxF3wIbGRw_inv4CCG6z6qC4WjHAPR5GLT__dRBx7I/edit#
  • Primary contact (assignee): @Huang-Wei
  • Responsible SIGs: sig-scheduling
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.26
    • Beta release target (x.y): 1.27
    • Stable release target (x.y):
# Alpha
- [ ] #3522 
- [ ] https://github.com/kubernetes/kubernetes/pull/113274
- [ ] https://github.com/kubernetes/kubernetes/pull/113275
- [ ] https://github.com/kubernetes/kubernetes/pull/113442
- [ ] https://github.com/kubernetes/kubernetes/pull/113946
- [ ] https://github.com/kubernetes/website/pull/37675
# Beta
- [ ] #3739
- [ ] https://github.com/kubernetes/kubernetes/issues/113608
- [ ] https://github.com/kubernetes/website/pull/39773
# Stable
- [ ] #4455
- [ ] https://github.com/kubernetes/kubernetes/pull/123575
- [ ] Docs (`k/website`) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

Huang-Wei avatar Sep 16 '22 18:09 Huang-Wei

/sig scheduling

Huang-Wei avatar Sep 16 '22 18:09 Huang-Wei

/label lead-opted-in

ahg-g avatar Sep 19 '22 17:09 ahg-g

/milestone v1.26

ahg-g avatar Sep 19 '22 17:09 ahg-g

Hey @kerthcet 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [X] KEP has an updated detailed test plan section filled out
  • [X] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to:

  • Change the status of kep.yaml to implementable (I've also added a comment review)
  • Include the new updated PR of this KEP in the Issue Description and get it merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Atharva-Shinde avatar Sep 22 '22 05:09 Atharva-Shinde

Thanks @Atharva-Shinde.

  • The KEP is updated to marked as implementable
  • Waiting for @johnbelamaric or @wojtek-t to be the approver of PRR: https://github.com/kubernetes/enhancements/pull/3522#discussion_r976590269

Huang-Wei avatar Sep 23 '22 04:09 Huang-Wei

Hello @Huang-Wei 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the PR #3522 merged before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

Atharva-Shinde avatar Oct 05 '22 16:10 Atharva-Shinde

Thanks for the reminder. It's 99% accomplished atm, just some final comments waiting for the approver to +1.

Huang-Wei avatar Oct 05 '22 21:10 Huang-Wei

With #3522 merged, we have this marked as tracked for v1.26.

rhockenbury avatar Oct 06 '22 21:10 rhockenbury

Hi @Huang-Wei 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

  • https://github.com/kubernetes/kubernetes/pull/113274
  • https://github.com/kubernetes/kubernetes/pull/113275
  • https://github.com/kubernetes/kubernetes/pull/113442

Please ensure all of these PRs are linked to this issue as well and mentioned in the initial issue description.

As always, we are here to help should questions come up. Thanks!

marosset avatar Oct 31 '22 19:10 marosset

@marosset yes, those 3 PRs are code implementation for this KEP in alpha stage. I just updated the issue description to get them linked.

Huang-Wei avatar Oct 31 '22 19:10 Huang-Wei

Hello @huang-Wei 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

krol3 avatar Nov 07 '22 18:11 krol3

Hi @Huang-Wei 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

  • https://github.com/kubernetes/kubernetes/pull/113275
  • https://github.com/kubernetes/kubernetes/pull/113442

As always, we are here to help should questions come up. Thanks!

marosset avatar Nov 07 '22 18:11 marosset

@marosset ACK, I'm working with reviewers to get 2 pending PRs merged by tomorrow.

Huang-Wei avatar Nov 07 '22 19:11 Huang-Wei

I'm working with reviewers to get 2 pending PRs merged by tomorrow.

All dev work has been merged.

Huang-Wei avatar Nov 08 '22 23:11 Huang-Wei

I'm working with reviewers to get 2 pending PRs merged by tomorrow.

All dev work has been merged.

Great! I'm marking this enhancement as Tracked for v1.26 release. Thanks!

marosset avatar Nov 09 '22 00:11 marosset

Hello @Huang-Wei :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

krol3 avatar Nov 11 '22 02:11 krol3

Hi @Huang-Wei, Thank you for the draft doc PR here, Please update to Ready for Review, the deadline it's on Tuesday 15th November 2022. Thank you!

krol3 avatar Nov 14 '22 00:11 krol3

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

marosset avatar Dec 14 '22 18:12 marosset

Not sure if I should post this here or #2926, but it would be nice if scheduling gates are mutable in the job template.

alculquicondor avatar Jan 09 '23 17:01 alculquicondor

Not sure if I should post this here or #2926, but it would be nice if scheduling gates are mutable in the job template.

Part of the KEP update for mutable scheduling directives already: https://github.com/kubernetes/enhancements/pull/3709

ahg-g avatar Jan 09 '23 23:01 ahg-g

/label lead-opted-in

Huang-Wei avatar Jan 09 '23 23:01 Huang-Wei

If we graduate this to beta, we'll need to update https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ and maybe other Pod pages, to mention / link to the details about it.

sftim avatar Jan 18 '23 10:01 sftim

/stage beta /milestone v1.27 /label lead-opted-in

ahg-g avatar Jan 23 '23 15:01 ahg-g

Hello @Huang-Wei 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.27
  • [x] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up to date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like https://github.com/kubernetes/enhancements/pull/3739 will address these issues.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar Feb 02 '23 18:02 npolshakova

Looks like with https://github.com/kubernetes/enhancements/pull/3739 merged this enhancement as tracked for v1.27. Thanks!

/remove-label tracked/no /label tracked/yes

npolshakova avatar Feb 09 '23 20:02 npolshakova

Hi @Huang-Wei,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [x] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

  • [x] https://github.com/kubernetes/kubernetes/pull/116201

Please let me know if there are any other PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks!

npolshakova avatar Mar 09 '23 14:03 npolshakova

@npolshakova I will have my eye on https://github.com/kubernetes/kubernetes/pull/116201 to ensure it's completed before code freeze.

Huang-Wei avatar Mar 10 '23 00:03 Huang-Wei

https://kubernetes.io/docs/concepts/workloads/pods/#pod-update-and-replacement a document update here may be needed for spec.schedulingGates that is updatable.

pacoxu avatar May 08 '23 07:05 pacoxu

@Huang-Wei, is it still the plan to graduate this feature in 1.29?

vladikr avatar Dec 06 '23 20:12 vladikr

No, it's still beta in 1.29.

Do you have any feedback for the feature? :)

alculquicondor avatar Dec 06 '23 21:12 alculquicondor