enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Extend metrics stability

Open logicalhan opened this issue 3 years ago • 13 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note):
  • Kubernetes Enhancement Proposal:
  • Discussion Link: wg-reliability meeting notes
  • Primary contact (assignee): logicalhan
  • Responsible SIGs: instrumentation
  • Enhancement target (which target equals to which milestone):
    • Alpha release target: 1.26
    • Beta release target: 1.28
    • Stable release target: 1.31
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3499
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/112676
      • [x] https://github.com/kubernetes/kubernetes/pull/113027
      • [x] https://github.com/kubernetes/kubernetes/pull/113022
      • [x] https://github.com/kubernetes/kubernetes/pull/113014
      • [x] https://github.com/kubernetes/kubernetes/pull/112995
      • [x] https://github.com/kubernetes/kubernetes/pull/112992
      • [x] https://github.com/kubernetes/kubernetes/pull/112991
      • [x] https://github.com/kubernetes/kubernetes/pull/112907
      • [x] https://github.com/kubernetes/kubernetes/pull/113123
      • [x] https://github.com/kubernetes/kubernetes/pull/113117
      • [x] https://github.com/kubernetes/kubernetes/pull/113115
    • [x] Docs (k/website) update PR(s):
      • [x] https://github.com/kubernetes/website/pull/37522

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

logicalhan avatar Sep 07 '22 13:09 logicalhan

/sig instrumentation

logicalhan avatar Sep 07 '22 14:09 logicalhan

/lead-opted-in

logicalhan avatar Sep 07 '22 14:09 logicalhan

/assign @logicalhan

dashpole avatar Sep 08 '22 16:09 dashpole

/milestone v1.26

rhockenbury avatar Sep 11 '22 19:09 rhockenbury

Hello @logicalhan 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [ ] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Update the PR https://github.com/kubernetes/enhancements/pull/3499 to meet the requirements for Enhancements freeze and get it merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Sep 20 '22 23:09 ruheenaansari34

@ruheenaansari34 I've updated the KEP to use the new template. Would you mind reassessing it? I also have a PRR reviewer actively conducting reviews.

logicalhan avatar Sep 21 '22 18:09 logicalhan

@logicalhan Thanks for updating it. Looks like all the requirements for the Enhancements freeze would be met once the PR is merged.

ruheenaansari34 avatar Sep 21 '22 19:09 ruheenaansari34

Here’s where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.26
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Sep 27 '22 01:09 ruheenaansari34

Hi @logicalhan 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [X] All PRs are fully merged by the code freeze deadline.

Let me know if there's any PRs that we should be tracking that aren't mentioned in the issue description.

As always, we are here to help should questions come up. Thanks!

rhockenbury avatar Oct 29 '22 18:10 rhockenbury

Hello @logicalhan 👋 1.26 Release Docs shadow here!

This enhancement is marked as ‘Needs Docs’ for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

cathchu avatar Nov 02 '22 03:11 cathchu

This enhancement is marked as ‘Needs Docs’ for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

This isn't a traditional feature, so it isn't actually guarded by a feature gate but one of the outputs of this work is documentation which I have already merged.

logicalhan avatar Nov 07 '22 23:11 logicalhan

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

marosset avatar Dec 14 '22 19:12 marosset

/lead-opted-in

logicalhan avatar Jan 19 '23 17:01 logicalhan

/milestone v1.27

logicalhan avatar Jan 25 '23 20:01 logicalhan

Hello @logicalhan 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

  • Update kep.yaml to reflect current stage information.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

fsmunoz avatar Feb 01 '23 12:02 fsmunoz

I've kept this at risk do the the need to update the latest-milestone. @logicalhan, there is a new question in the PRR Scalability that you might want to address:

Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

The Scalability section of the PRR is mandatory for beta, and I didn't mark this as a lack of latest template but I should've (I hadn't noticed myself).

fsmunoz avatar Feb 05 '23 17:02 fsmunoz

I've kept this at risk do the the need to update the latest-milestone. @logicalhan, there is a new question in the PRR Scalability that you might want to address:

Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

Updated to include this question. I've actually already gotten PRR reviewed though.

logicalhan avatar Feb 06 '23 18:02 logicalhan

The Scalability section of the PRR is mandatory for beta, and I didn't mark this as a lack of latest template but I should've (I hadn't noticed myself).

It's filled out.

logicalhan avatar Feb 06 '23 18:02 logicalhan

Thank you @logicalhan !

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to beta in v1.27.

/label tracked/yes /remove-label tracked/no

fsmunoz avatar Feb 08 '23 16:02 fsmunoz

@fsmunoz: Those labels are not set on the issue: tracked/no

In response to this:

Thank you @logicalhan !

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to beta in v1.27.

/label tracked/yes /remove-label tracked/no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 08 '23 16:02 k8s-ci-robot

Hi @logicalhan, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

LukeMwila avatar Mar 11 '23 05:03 LukeMwila

/stage beta

logicalhan avatar Mar 11 '23 19:03 logicalhan

Hi @logicalhan 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [X] All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like there are no code changes.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

fsmunoz avatar Mar 13 '23 10:03 fsmunoz

Hi @logicalhan, as @LukeMwila mentioned, please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

mickeyboxell avatar Mar 16 '23 18:03 mickeyboxell

/lead-opted-in

logicalhan avatar May 22 '23 21:05 logicalhan

Hello @logicalhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

~~Is this enhancement staying to stage beta for v1.28?~~ This enhancement is targeting stage stable

Here's where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone:v1.28
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

  • Update kep.yaml with latest information.
  • Add response for this question in the Scalability questionnaire of the KEP readme.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Atharva-Shinde avatar May 23 '23 11:05 Atharva-Shinde

/milestone v1.28

logicalhan avatar May 30 '23 17:05 logicalhan

Hey @logicalhan With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Atharva-Shinde avatar Jun 15 '23 11:06 Atharva-Shinde

Hello @logicalhan :wave:, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

VibhorChinda avatar Jun 22 '23 06:06 VibhorChinda

Hey @logicalhan , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

Rishit-dagli avatar Jul 12 '23 15:07 Rishit-dagli