VolumeGroupSnapshot

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note): Introduce a VolumeGroupSnapshot API to take a snapshot of multiple volumes together.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3476-volume-group-snapshot/README.md

• Discussion Link:

• Primary contact (assignee): @xing-yang

• Responsible SIGs: sig-storage

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.27
  • Beta release target (x.y): 1.32
  • Stable release target (x.y):

• [x] Alpha

  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/1551
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update PR(s): Placeholder blog PR: https://github.com/kubernetes/website/pull/39415

• [ ] Beta

  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4734
  • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/test-infra/pull/33417, https://github.com/kubernetes/test-infra/pull/33567, https://github.com/kubernetes/kubernetes/pull/126326
  • [ ] Docs (k/website) update(s): doc PR: https://github.com/kubernetes/website/pull/48419, blog PR: https://github.com/kubernetes/website/pull/48420

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[xing-yang]

/sig storage

[xing-yang]

/milestone v1.26

[ruheenaansari34]

Hello @xing-yang 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise).

Here's where this enhancement currently stands:

• [ ] KEP file using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable
• [ ] KEP has a updated detailed test plan section filled out
• [ ] KEP has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update README.md on PR https://github.com/kubernetes/enhancements/pull/1551 to include test plan details as per the latest template
• Include Design Details section and move Test Plan and Graduation Criteria sections into Design Details.
• Merge PR https://github.com/kubernetes/enhancements/pull/1551 which will take care of meeting the above requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[ruheenaansari34]

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the kep.yaml, and README and get the PR merged.

[xing-yang]

@ruheenaansari34 Thanks for the reminder! I updated the KEP and moved test plan and graduation criteria under design details section.

[ruheenaansari34]

@xing-yang Thank you. I've re-assessed it and looks like we still need

• KEP owner's acknowledgment in the Test plan section of KEP's README.

Specifically, this statement:

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

• "Drawbacks" and "Alternatives" sections (if applicable) are added after "Implementation History".

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

[xing-yang]

@ruheenaansari34 I've updated the KEP PR with the owner's acknowledgment and also moved "Alternatives" after "Implementation History". PTAL. Thanks.

[ruheenaansari34]

Thank you. Please ensure the PR is merged before enhancements freeze at 18:00 PDT today and that will fulfill requirements.

[xing-yang]

Hi @ruheenaansari34, we need more time to finalize the design details so the KEP won't be merged today. Since the implementation is completely out-of-tree, we will continue to work on it. When you remove the tracked/yes label, can you please also add the tracked/out-of-tree label? Thanks!

[rhockenbury]

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[Atharva-Shinde]

Hello @xing-yang 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for latest-milestone: 1.27
• [X] KEP readme has a updated detailed test plan section filled out
• [X] KEP readme has up to date graduation criteria
• [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[johnbelamaric]

The new question is not needed for alpha but would be nice to have. The PRR approval is still in place from last cycle, and I went through commit-by-commit and all the answers on the updated KEP look consistent with the previous discussions. So PRR is approved.

[johnbelamaric]

@Atharva-Shinde I updated the PRR checkbox above

[Atharva-Shinde]

Hey again @xing-yang Please try to get the KEP PR #1551, merged before tomorrow's Enhancement Freeze :) The status of this enhancement is still marked as at risk

[xing-yang]

@Atharva-Shinde The KEP is merged.

[Atharva-Shinde]

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[LukeMwila]

Hi @xing-yang, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

[Atharva-Shinde]

Hey @xing-yang 👋 Enhancements team here, Can you please include the kubernetes/kubernetes code PRs related to this KEP in the Issue description, this will make it easier to track the code related PRs of this KEP.

[xing-yang]

Hi @Atharva-Shinde, all code development are out of tree in this repo: https://github.com/kubernetes-csi/external-snapshotter. So we don't need to follow the k/k code freeze deadline. It already has a "tracked/out-of-tree" label. Thanks!

[xing-yang]

Hi @LukeMwila, since all the code will be developed out of tree, the docs will also be out of tree here: https://kubernetes-csi.github.io/docs/. So I think we don't need to add docs in k/website. Thanks!

[marosset]

/remove-label tracked/no

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[andyzhangx]

@xing-yang what's the status of this feature? is it still alpha in 1.29?

[xing-yang]

This is still alpha. We may target beta in 1.32 as we still need to add metrics, e2e tests, etc.

[xing-yang]

/remove-lifecycle stale

[Madhu-1]

@xing-yang can we target this for beta in 1.31 as we are already working on metrics and the e2e test? will you be taking care of updating the KEP, docs etc? please let me know if you need any help with it. Thank you.