enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Kubernetes Component Health SLIs

Open logicalhan opened this issue 3 years ago • 19 comments

Enhancement Description

  • Exposing healthchecks in metric format
  • Kubernetes Enhancement Proposal: N/A (in progress)
  • Discussion Link:
  • Primary contact (assignee): logicalhan
  • Responsible SIGs: sig-instrumentation
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.26):
    • Beta release target (1.27):
    • Stable release target (1.28):
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3469
    • [x] Code (k/k) update PR(s):
      • [x] https://github.com/kubernetes/kubernetes/pull/111771
      • [x] https://github.com/kubernetes/kubernetes/pull/112741
      • [x] https://github.com/kubernetes/kubernetes/pull/112740
      • [x] https://github.com/kubernetes/kubernetes/pull/112978
      • [x] https://github.com/kubernetes/kubernetes/pull/113026
      • [x] https://github.com/kubernetes/kubernetes/pull/113030
      • [x] https://github.com/kubernetes/kubernetes/pull/113340
    • [x] Docs (k/website) update PR(s):
      • [x] https://github.com/kubernetes/website/pull/37767

logicalhan avatar Aug 16 '22 19:08 logicalhan

Hey @logicalhan, can you give some more context on this issue? I might can work on this

Kanika637 avatar Aug 24 '22 07:08 Kanika637

/sig instrumentation

logicalhan avatar Sep 07 '22 14:09 logicalhan

/assign @logicalhan

dashpole avatar Sep 08 '22 16:09 dashpole

/milestone 1.26

rhockenbury avatar Sep 11 '22 19:09 rhockenbury

@rhockenbury: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 11 '22 19:09 k8s-ci-robot

/milestone v1.26

rhockenbury avatar Sep 11 '22 19:09 rhockenbury

/assign @wojtek-t

logicalhan avatar Sep 14 '22 20:09 logicalhan

👋 Hello @logicalhan , 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022. This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [ ] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we need to update the PR https://github.com/kubernetes/enhancements/pull/3469 to meet the requirements for enhancement freeze, and then get it merged.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Sep 16 '22 19:09 ruheenaansari34

Looks like for this one, we need to update the PR #3469 to meet the requirements for enhancement freeze, and then get it merged.

@ruheenaansari34 I've updated the KEP using the template. Would you mind re-assessing it?

logicalhan avatar Sep 21 '22 18:09 logicalhan

@logicalhan Thank you. I've re-assessed it and looks like we still need KEP owner's acknowledgement in the Test plan section of KEP's README. Specifically, this statement:

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

ruheenaansari34 avatar Sep 27 '22 16:09 ruheenaansari34

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Would you mind reviewing this: https://github.com/kubernetes/enhancements/pull/3564?

logicalhan avatar Sep 28 '22 16:09 logicalhan

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Done.

logicalhan avatar Sep 28 '22 17:09 logicalhan

Excellent. Here’s where this enhancement currently stands:

  • [X] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.26
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

ruheenaansari34 avatar Sep 29 '22 20:09 ruheenaansari34

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

jberkus avatar Oct 18 '22 00:10 jberkus

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

Sure done.

logicalhan avatar Oct 18 '22 00:10 logicalhan

Hi @logicalhan 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [X] All PRs are fully merged by the code freeze deadline.

Let me know if there's any PRs that aren't mentioned in the issue description that we should be tracking.

As always, we are here to help should questions come up. Thanks!

rhockenbury avatar Oct 29 '22 18:10 rhockenbury

Hello @logicalhan 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

krol3 avatar Nov 07 '22 17:11 krol3

Hello @logicalhan 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Done and merged.

logicalhan avatar Nov 08 '22 22:11 logicalhan

/remove-label lead-opted-in /remove-label tracked/yes /label tracked/no /milestone clear

marosset avatar Dec 14 '22 19:12 marosset

Hello @logicalhan 👋, 1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.27
  • [x] KEP readme has a updated detailed test plan section filled out
  • [x] KEP readme has up to date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar Feb 02 '23 18:02 npolshakova

Hi @logicalhan,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [x] All PRs are fully merged by the code freeze deadline.
    • [x] https://github.com/kubernetes/kubernetes/pull/114997

Please let me know if there are any other PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks!

npolshakova avatar Mar 09 '23 14:03 npolshakova

/stage beta

logicalhan avatar Mar 11 '23 19:03 logicalhan

Hi @logicalhan :wave:, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by tomorrow, March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

mickeyboxell avatar Mar 15 '23 13:03 mickeyboxell

Hi @logicalhan please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

mickeyboxell avatar Mar 16 '23 18:03 mickeyboxell

Hi @logicalhan please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

https://github.com/kubernetes/website/pull/40064

logicalhan avatar Mar 16 '23 19:03 logicalhan

/stage stable

logicalhan avatar Sep 22 '23 16:09 logicalhan

Hello @logicalhan 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone to 1.29 in the kep.yaml

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

npolshakova avatar Sep 22 '23 17:09 npolshakova

Hello @logicalhan 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone to 1.29 in the kep.yaml

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Done

logicalhan avatar Sep 25 '23 17:09 logicalhan

Thanks! With https://github.com/kubernetes/enhancements/pull/4241/files merged in, this KEP is now tracked for enhancement freeze! 🚀

npolshakova avatar Sep 30 '23 18:09 npolshakova

Hey there @logicalhan ! 👋, v1.29 Docs team shadow here. Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs? If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023. Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release. Thank you!

Princesso avatar Oct 09 '23 19:10 Princesso