enhancements
enhancements copied to clipboard
Update KEP-3329 "Retriable and non-retriable Pod failures for Jobs" for Beta
- One-line PR description: KEP updates for Beta
- Issue link: https://github.com/kubernetes/enhancements/issues/3329
- Other comments:
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/assign
/sig node
LGTM from my side, but I'm not an approver :)
Thanks, squashed changes. You may also tag it with lgtm :)
/assign @johnbelamaric
Left a few small comments/suggestions from node side, but overall makes sense!
/lgtm
Thanks for the updating based on the comments.
/approve from sig-apps pov, not sure why it didn't pick the last one
Squashed after the small changes. @johnbelamaric PTAL.
/lgtm
/approve
/approve
Thank you, although it seems the approval isn't picked by the automation (after 10min), wondering maybe this is the same issue as @soltysh mentioned: https://github.com/kubernetes/enhancements/pull/3463#issuecomment-1267254343
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: johnbelamaric, mimowo, soltysh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~keps/prod-readiness/OWNERS~~ [johnbelamaric]
- ~~keps/sig-apps/OWNERS~~ [johnbelamaric,soltysh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment