enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Update KEP-3329 "Retriable and non-retriable Pod failures for Jobs" for Beta

Open mimowo opened this issue 3 years ago • 2 comments

  • One-line PR description: KEP updates for Beta
  • Issue link: https://github.com/kubernetes/enhancements/issues/3329
  • Other comments:

mimowo avatar Aug 12 '22 14:08 mimowo

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Aug 12 '22 14:08 k8s-ci-robot

/assign

alculquicondor avatar Sep 12 '22 14:09 alculquicondor

/sig node

alculquicondor avatar Sep 20 '22 17:09 alculquicondor

LGTM from my side, but I'm not an approver :)

Thanks, squashed changes. You may also tag it with lgtm :)

mimowo avatar Sep 27 '22 08:09 mimowo

/assign @johnbelamaric

mimowo avatar Sep 29 '22 17:09 mimowo

Left a few small comments/suggestions from node side, but overall makes sense!

bobbypage avatar Sep 30 '22 01:09 bobbypage

/lgtm

Thanks for the updating based on the comments.

bobbypage avatar Oct 03 '22 22:10 bobbypage

/approve from sig-apps pov, not sure why it didn't pick the last one

soltysh avatar Oct 04 '22 16:10 soltysh

Squashed after the small changes. @johnbelamaric PTAL.

mimowo avatar Oct 05 '22 07:10 mimowo

/lgtm

soltysh avatar Oct 05 '22 08:10 soltysh

/approve

johnbelamaric avatar Oct 05 '22 15:10 johnbelamaric

/approve

Thank you, although it seems the approval isn't picked by the automation (after 10min), wondering maybe this is the same issue as @soltysh mentioned: https://github.com/kubernetes/enhancements/pull/3463#issuecomment-1267254343

mimowo avatar Oct 05 '22 15:10 mimowo

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, mimowo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 05 '22 16:10 k8s-ci-robot