enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Kubelet Evented PLEG for Better Performance

Open harche opened this issue 2 years ago β€’ 47 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Kubelet Evented PLEG for Better Performance
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3386-kubelet-evented-pleg/README.md
  • Discussion Link: https://kubernetes.slack.com/archives/C03HA69L6R1 ,https://github.com/kubernetes/kubernetes/pull/110165
  • Primary contact (assignee): @harche, @haircommander, @ruiwen-zhao
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.25
    • Beta1 release target (x.y): 1.27 (default false)
    • Revert to alpha: 1.30 (v1.27.9、v1.28.6、v1.29.1)
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [x] Alpha
    • [x] API Changes - https://github.com/kubernetes/kubernetes/pull/111642
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3387
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/111384
  • [x] Beta (default disabled)
    • [x] KEP (k/enhancements) update
      • PR(s): https://github.com/kubernetes/enhancements/pull/3817
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/115967
      • https://github.com/kubernetes/test-infra/pull/28366
      • https://github.com/kubernetes/test-infra/pull/28592
    • [x] Docs (k/website) updates(s):
      • https://github.com/kubernetes/website/pull/39913
  • [ ] Revert to alpha
    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
      • [x] v1.30(backported): https://github.com/kubernetes/kubernetes/pull/122697
      • [x] v1.29: https://github.com/kubernetes/kubernetes/pull/120942
      • [x] v1.30: https://github.com/kubernetes/kubernetes/pull/122475/
    • [ ] Docs (k/website) update(s):
  • [ ] Beta
    • [ ] Issues to fix before re-promoting it to beta:
      • [ ] https://github.com/kubernetes/kubernetes/issues/121003
      • [ ] https://github.com/kubernetes/kubernetes/issues/121349 WIP in : https://github.com/kubernetes/kubernetes/pull/122124
    • [ ] KEP (k/enhancements) update PR(s):
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

harche avatar Jun 13 '22 07:06 harche

/sig-node

harche avatar Jun 13 '22 07:06 harche

Hello @harche πŸ‘‹, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable
  • [X] KEP has a updated detailed test plan section filled out
  • [X] KEP has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

  • update the kep.yaml file in the merged KEP to add latest-milestone: "v1.25”

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

Priyankasaggu11929 avatar Jun 17 '22 16:06 Priyankasaggu11929

I opened https://github.com/kubernetes/enhancements/pull/3410 to target at 1.25

haircommander avatar Jun 17 '22 18:06 haircommander

/sig node

Priyankasaggu11929 avatar Jun 21 '22 10:06 Priyankasaggu11929

With KEP PR https://github.com/kubernetes/enhancements/pull/3410 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! πŸ™‚

Priyankasaggu11929 avatar Jun 23 '22 05:06 Priyankasaggu11929

Hello @haircommander @harche πŸ‘‹

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.
    • https://github.com/kubernetes/kubernetes/pull/111384

I was able to find the following draft k/k PRs for the KEP:

  • https://github.com/kubernetes/kubernetes/pull/110911
  • https://github.com/kubernetes/kubernetes/pull/110912

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open/draft k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Thank you for keeping the issue description up-to-date!

Priyankasaggu11929 avatar Jul 21 '22 12:07 Priyankasaggu11929

Thanks @Priyankasaggu11929 for reaching out. I am planning to raise a PR by coming Monday.

harche avatar Jul 22 '22 07:07 harche

@Priyankasaggu11929 I just raised a PR - https://github.com/kubernetes/kubernetes/pull/111384

harche avatar Jul 25 '22 07:07 harche

Hello @harche πŸ‘‹

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022 (which is almost 2 days from now)

Please plan to have the open k/k PR merged before then.

The status of this enhancement is currently marked as at risk

Thank you

Priyankasaggu11929 avatar Aug 01 '22 03:08 Priyankasaggu11929

API Changes PR - https://github.com/kubernetes/kubernetes/pull/111642

harche avatar Aug 02 '22 18:08 harche

Hello :wave:, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

Priyankasaggu11929 avatar Aug 03 '22 01:08 Priyankasaggu11929

@Priyankasaggu11929 Request for the exception has been raised - https://groups.google.com/g/kubernetes-sig-node/c/H_jmCppaurU/m/vwOzc-EFAAAJ

harche avatar Aug 03 '22 10:08 harche

/milestone v1.26 /label lead-opted-in (I'm doing this on behalf of @ruiwen-zhao / SIG-node)

marosset avatar Sep 30 '22 18:09 marosset

/stage alpha /label tracked/yes /remove-label tracked/no

rhockenbury avatar Oct 01 '22 01:10 rhockenbury

/milestone v1.26 /label lead-opted-in

(this is a carry over from prior release, hope it makes alpha)

derekwaynecarr avatar Oct 03 '22 19:10 derekwaynecarr

Hello @harche, @haircommander, and @ruiwen-zhao πŸ‘‹, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: 1.26
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to open a PR to make changes to the KEP yaml and KEP readme.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

rhockenbury avatar Oct 03 '22 21:10 rhockenbury

@rhockenbury Link to the PR - https://github.com/kubernetes/enhancements/pull/3575

harche avatar Oct 04 '22 14:10 harche

Thanks, please plan to get https://github.com/kubernetes/enhancements/pull/3575 merged up before enhancements freeze.

rhockenbury avatar Oct 05 '22 03:10 rhockenbury

@rhockenbury https://github.com/kubernetes/enhancements/pull/3575 is now merged and it should check all the boxes in https://github.com/kubernetes/enhancements/issues/3386#issuecomment-1266093148

ruiwen-zhao avatar Oct 06 '22 19:10 ruiwen-zhao

Thanks, I have it marked as tracked now.

rhockenbury avatar Oct 06 '22 20:10 rhockenbury

Hey @harche @ruiwen-zhao @haircommander πŸ‘‹,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the issue description above(for tracking purposes). If there are any other PRs beyond:
    https://github.com/kubernetes/kubernetes/issues/111384 and https://github.com/kubernetes/kubernetes/issues/111642 please include them in the issue description too.
  • [ ] All PRs are fully merged by the code freeze deadline.

As always, we are here to help should questions come up. Thanks :)

Atharva-Shinde avatar Oct 31 '22 17:10 Atharva-Shinde

Hello @harche ! πŸ‘‹πŸΎ,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as β€˜Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. As a reminder, please link all of your docs PR to this issue so we can easily track it.

katmutua avatar Nov 01 '22 14:11 katmutua

@katmutua Considering this feature is just alpha, I am not sure if we need to have docs.

cc @haircommander @ruiwen-zhao

harche avatar Nov 03 '22 13:11 harche

Hi @harche , here Carol from the Doc Lead of 1.26, I think we need to update the Kubernetes documentation features with alpha, for example here cc @reylejano

krol3 avatar Nov 03 '22 14:11 krol3

@harche , For 1.26, since this enhancement has a feature gate of EventedPLEG, this should be added to the feature gates page in the Feature gates for Alpha or Beta features table: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

reylejano avatar Nov 04 '22 00:11 reylejano

Thanks @katmutua @krol3 and @reylejano. I have created a doc PR https://github.com/kubernetes/website/pull/37715 to add EventedPLEG in the features table.

harche avatar Nov 04 '22 13:11 harche

cc @swghosh @rphillips

harche avatar Nov 04 '22 13:11 harche

Hey @harche @ruiwen-zhao @haircommander πŸ‘‹, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: https://github.com/kubernetes/kubernetes/pull/111384 (any other PRs?) merged before the code-freeze.

Atharva-Shinde avatar Nov 07 '22 16:11 Atharva-Shinde

With https://github.com/kubernetes/kubernetes/pull/111384 merged, we have this marked as tracked for code freeze.

rhockenbury avatar Nov 09 '22 00:11 rhockenbury

Hey @harche @ruiwen-zhao @haircommander wave, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: kubernetes/kubernetes#111384 (any other PRs?) merged before the code-freeze.

Not directly a code PR, but there is this doc PR - https://github.com/kubernetes/website/pull/37715

harche avatar Nov 09 '22 16:11 harche