enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-3370: add native PodGroup api

Open denkensk opened this issue 3 years ago • 11 comments

Signed-off-by: Alex Wang [email protected]

  • One-line PR description: Add Native PodGroup api
  • Issue link: https://github.com/kubernetes/enhancements/issues/3370
  • Other comments:

denkensk avatar Jun 09 '22 09:06 denkensk

/cc

alculquicondor avatar Jun 09 '22 13:06 alculquicondor

Can you add sig-autoscaling as a participating sig and have an approver from it? In the high level, we should have an implementation path that is compatible with the cluster autoscaler.

alculquicondor avatar Jun 09 '22 14:06 alculquicondor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: denkensk To complete the pull request process, please assign ahg-g, wojtek-t after the PR has been reviewed. You can assign the PR to them by writing /assign @ahg-g @wojtek-t in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 16 '22 07:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 09 '22 13:10 k8s-triage-robot

/remove-lifecycle stale

kerthcet avatar Oct 09 '22 14:10 kerthcet

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 07 '23 14:01 k8s-triage-robot

/remove-lifecycle stale

denkensk avatar Jan 08 '23 15:01 denkensk

Any plans of an updated proposal? I was thinking that the new PreEnqueue endpoint might help have a more reliable implementation than the current QueueSort approach. But we also need more clarity around compatibility with cluster-autoscaler.

alculquicondor avatar Jan 09 '23 13:01 alculquicondor

/cc

tenzen-y avatar Jan 12 '23 18:01 tenzen-y

Key points from today's SIG meeting:

This KEP needs more work, specifically:

  • Clarify how PodGroup could be supported by cluster-autoscaler.
  • Evaluate using the PreEnqueue endpoint for better sorting and overall performance.

alculquicondor avatar Jan 12 '23 18:01 alculquicondor

Key points from today's SIG meeting:

This KEP needs more work, specifically:

Clarify how PodGroup could be supported by cluster-autoscaler.

Thanks. @alculquicondor Ok. I will continue to work on this part. It's worth to rethink how to integrate with cluster-autoscaler again.

Evaluate using the PreEnqueue endpoint for better sorting and overall performance.

Yes. One of the original goals of PreEnqueue was also to optimize the performance of coscheduling.

denkensk avatar Jan 13 '23 09:01 denkensk

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 13 '23 09:04 k8s-triage-robot

/remove-lifecycle stale

denkensk avatar Apr 14 '23 02:04 denkensk

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: denkensk Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t and additionally assign ahg-g for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 22 '23 11:05 k8s-ci-robot

hey @denkensk is there any reason you stopped working on this? We would find this highly useful for one of our needs.

vsoch avatar Jan 09 '24 15:01 vsoch

hey @denkensk is there any reason you stopped working on this? We would find this highly useful for one of our needs.

+1 for having this. Would like to know the status of this KEP.

AxeZhan avatar Feb 19 '24 11:02 AxeZhan

hey @denkensk is there any reason you stopped working on this? We would find this highly useful for one of our needs.

+1 for having this. Would like to know the status of this KEP.

I guess that we need to move the cluster-autoscaler ProvisioningRequest forward more and more before we work on this.

tenzen-y avatar Feb 19 '24 13:02 tenzen-y

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 19 '24 13:05 k8s-triage-robot

/remove-lifecycle stale

tenzen-y avatar May 19 '24 14:05 tenzen-y