enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard
verified publisher icon kubernetes

KEP-3322: add a new field maxRestartTimesOnFailure to podSpec

Open kerthcet opened this issue 3 years ago • 27 comments

Signed-off-by: kerthcet [email protected]

  • One-line PR description: Add a new field maxRestartTimes to podSpec when running into RestartPolicyOnFailure
  • Issue link: https://github.com/kubernetes/enhancements/issues/3322
  • Other comments:

kerthcet avatar Jun 06 '22 09:06 kerthcet

cc @wojtek-t PTAL, thanks a lot.

kerthcet avatar Jun 09 '22 06:06 kerthcet

cc @wojtek-t PTAL, thanks a lot.

We're generally doing PRR once you already have SIG approval.

wojtek-t avatar Jun 09 '22 09:06 wojtek-t

cc @dchen1107 for sig-node side review, also cc @hex108

kerthcet avatar Jun 13 '22 03:06 kerthcet

This KEP is helpful especially for those pods that holds a large resource set such as the JVM based pod . We give these kinds of pods a high limit threshold to speed up their startup , restart always policy will make this worse , even the node crash. In the old days , daemon control tools like supervisorctl has its startretries mechanism to limit the max startup retries , but for k8s deployments there is no replacement for it .

scbizu avatar Jun 16 '22 05:06 scbizu

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 27 '22 19:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 27 '22 19:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Nov 26 '22 20:11 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 26 '22 20:11 k8s-ci-robot

Any traction on this?

bdevcich avatar Jan 17 '23 15:01 bdevcich

/reopen

kerthcet avatar Apr 24 '23 10:04 kerthcet

@kerthcet: Failed to re-open PR: state cannot be changed. The feat/add-maxRetries-to-podSpec branch has been deleted.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 24 '23 10:04 k8s-ci-robot

/reopen /remove-sig node /sig apps

kerthcet avatar May 05 '23 06:05 kerthcet

@kerthcet: Reopened this PR.

In response to this:

/reopen /remove-sig node /sig apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 05 '23 06:05 k8s-ci-robot

cc @soltysh would you mind to take a look?

kerthcet avatar May 08 '23 12:05 kerthcet

kindly ping @kubernetes/sig-node-leads

kerthcet avatar May 18 '23 06:05 kerthcet

/cc

alculquicondor avatar May 23 '23 19:05 alculquicondor

I'll polish this design doc with more details ASAP, thanks all.

kerthcet avatar May 30 '23 12:05 kerthcet

/remove-lifecycle rotten

SergeyKanzhelev avatar Jun 08 '23 07:06 SergeyKanzhelev

Deadline is in ~8 hours -- Is this still hoping to land?

thockin avatar Jun 15 '23 16:06 thockin

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drinktee, kerthcet Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t and additionally assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 16 '23 03:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 22 '24 02:01 k8s-triage-robot

/remove-lifecycle stale

kerthcet avatar Feb 19 '24 08:02 kerthcet

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 19 '24 09:05 k8s-triage-robot

hey, it's 2024, any update?

/lifecycle frozen

adampl avatar May 24 '24 18:05 adampl

@adampl: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

hey, it's 2024, any update?

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 24 '24 18:05 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 23 '24 18:06 k8s-triage-robot

/remove-lifecycle rotten

adampl avatar Jun 24 '24 13:06 adampl

@kerthcet Are you going to work on this?

kannon92 avatar Aug 20 '24 21:08 kannon92

FYI on a somewhat related KEP #4603

alculquicondor avatar Aug 21 '24 12:08 alculquicondor

@alculquicondor I'm trying to see if this is a KEP that sig-node should help review for 1.32.

kannon92 avatar Aug 22 '24 13:08 kannon92