enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

CSI Differential Snapshot for Block Volumes

Open phuongatemc opened this issue 2 years ago • 71 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add Differential Snapshot to CSI to provide a common method get differential snapshots of two arbitrary CSI VolumeSnapshots for PersistentVolumes that are backed by Block volumes in the backend storage.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3314-csi-changed-block-tracking/README.md CSI spec PR: https://github.com/container-storage-interface/spec/pull/551
  • Discussion Link: https://hackmd.io/VN_TBl3NSLaeiD8BLeeCfw?view
  • Primary contact (assignee): @ihcsim @braganza @PrasadG193
  • Responsible SIGs: SIG-Storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.32
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4082, https://github.com/kubernetes/enhancements/pull/4909
    • [ ] Code (k/k) update PR(s):
    • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

phuongatemc avatar May 17 '22 17:05 phuongatemc

/sig storage

xing-yang avatar May 17 '22 18:05 xing-yang

/wg data-protection

xing-yang avatar May 17 '22 18:05 xing-yang

/milestone v1.25

xing-yang avatar May 17 '22 18:05 xing-yang

Hello @phuongatemc 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [ ] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

  • Have a KEP with all the above checkpoints included and a completed PRR, merged in kubernetes/enhancements repo

Open KEP PR https://github.com/kubernetes/enhancements/pull/3367

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

jasonbraganza avatar Jun 06 '22 12:06 jasonbraganza

Hello @phuongatemc, @ihcsim 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the above done before enhancements freeze on Thursday, June 16, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

jasonbraganza avatar Jun 13 '22 12:06 jasonbraganza

@jasonbraganza I have updated the issue description with the PR https://github.com/kubernetes/enhancements/pull/3367 This is still an work in progress so we don't have the code ready yet but here is our repository https://github.com/phuongatemc/diffsnapcontroller/

phuongatemc avatar Jun 13 '22 13:06 phuongatemc

Thank you so much for the updates, @phuongatemc 🙂

Could you please, make the following updates in you open PR https://github.com/kubernetes/enhancements/pull/3367

  1. Update the status from provisional to implementable in the kep.yaml file.
  2. Please update the test plan section, to add the test information in the requested format, as described in the template

Please plan to have the PR merged, before the updated enhancements freeze date on Thursday, June 23, 2022.

jasonbraganza avatar Jun 14 '22 11:06 jasonbraganza

@jasonbraganza thanks - we added the test plan section yesterday. I thought the KEP must be approved before we can update it to implementable.

ihcsim avatar Jun 14 '22 14:06 ihcsim

Hello @ihcsim. Just checking in, as we are four days away from the enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

I thought the KEP must be approved before we can update it to implementable.

For a KEP to be tracked in release cycle, it should be marked as implementable.

Kindly plan to have the PR merged by the freeze date.

Please note: the current status of the enhancement is at-risk. Thank you.

jasonbraganza avatar Jun 20 '22 08:06 jasonbraganza

Hello, 1.25 Enhancements Lead here 👋. With Enhancements Freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

  • KEP file using the latest template has been merged into the k/enhancements repo, with up to date latest milestone and stage
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

Priyankasaggu11929 avatar Jun 24 '22 01:06 Priyankasaggu11929

/milestone v1.26

xing-yang avatar Sep 07 '22 19:09 xing-yang

Hey @phuongatemc 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [X] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.26
  • [X] KEP has an updated detailed test plan section filled out
  • [X] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to:

  • Edit the Issue Description with updated Enhancement Target
  • Get the PR #3367 merged before Enhancements Freeze to make this enhancement eligible for 1.26 release

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Atharva-Shinde avatar Sep 20 '22 11:09 Atharva-Shinde

/label tracked/yes

Atharva-Shinde avatar Sep 20 '22 14:09 Atharva-Shinde

/assign @ihcsim

ihcsim avatar Sep 21 '22 16:09 ihcsim

Hello @phuongatemc @ihcsim 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

Atharva-Shinde avatar Oct 05 '22 16:10 Atharva-Shinde

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

rhockenbury avatar Oct 07 '22 01:10 rhockenbury

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 05 '23 01:01 k8s-triage-robot

/remove-lifecycle stale

xing-yang avatar Jan 05 '23 01:01 xing-yang

Hello @ihcsim @phuongatemc 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for latest-milestone: 1.27
  • [X] KEP readme has a updated detailed test plan section filled out
  • [X] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Atharva-Shinde avatar Jan 31 '23 19:01 Atharva-Shinde

Hey again @ihcsim @phuongatemc
Please try to get the KEP PR #3367 (addressing the changes mentioned above), merged before tomorrow's Enhancement Freeze :) The status of this enhancement is still marked as at risk

Atharva-Shinde avatar Feb 08 '23 18:02 Atharva-Shinde

Hi @Atharva-Shinde, this KEP https://github.com/kubernetes/enhancements/pull/3367 is not merged yet. We are still going through design discussions. Thanks.

xing-yang avatar Feb 09 '23 18:02 xing-yang

Oops my bad @xing-yang thank you for notifying I'll delete my comment and I have changed the status back to at risk

Atharva-Shinde avatar Feb 09 '23 18:02 Atharva-Shinde

Unfortunately, this exception hasn't satisfied all of the requirements by the v1.27 code freeze and will be removed from the milestone.

If you feel it is important to include this exception in v1.27 please consider filing an exception as outlined at https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

marosset avatar Feb 10 '23 02:02 marosset

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 11 '23 02:05 k8s-triage-robot

/remove-lifecycle stale

xing-yang avatar May 13 '23 18:05 xing-yang

/milestone v1.29

xing-yang avatar Aug 31 '23 20:08 xing-yang

Hello @phuongatemc @ihcsim 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage `alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • [x] KEP readme has up-to-date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Please fill out the missing fields in the KEP readme file, like Rollout, Upgrade and Rollback Planning, Scalability and the missing questions in Monitoring
  • Ensure that your PR is merged.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

sreeram-venkitesh avatar Sep 26 '23 20:09 sreeram-venkitesh

Hi @phuongatemc @ihcsim, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC Friday, 6th October 2023. The status of this enhancement is marked as at risk. It looks like https://github.com/kubernetes/enhancements/pull/4082 will address most of the requirements. Please make sure that the changes are merged in time. Let me know if I missed anything. Thanks!

sreeram-venkitesh avatar Oct 04 '23 15:10 sreeram-venkitesh

Hello 👋, 1.29 Enhancements Lead here. Unfortunately, this enhancement did not meet requirements for v1.29 enhancements freeze. Feel free to file an exception to add this back to the release tracking process. Thanks!

https://github.com/kubernetes/enhancements/pull/4082 still needs SIG approval to complete the enhancement freeze requirements.

/milestone clear

npolshakova avatar Oct 06 '23 01:10 npolshakova

@npolshakova Can you please add a label "tracked/out-of-tree"? The implementation for this feature is completely out-of-tree.

xing-yang avatar Oct 06 '23 19:10 xing-yang