enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KMS v2 Improvements

Open ritazh opened this issue 3 years ago • 13 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Introduce KMS v2alpha1 API to add performance, rotation, and observability improvements
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3299-kms-v2-improvements
  • Discussion Link:
    • https://github.com/kubernetes/enhancements/pull/3302
    • Sig Auth meetings for 20220608: https://youtu.be/SNnvZVvk5VQ
  • Primary contact (assignee): @ritazh @aramase
  • Responsible SIGs: sig-auth
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.25
    • Beta release target (x.y): 1.26
    • Stable release target (x.y): 1.27
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3302
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/111126
    • [ ] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/35046

ritazh avatar May 09 '22 00:05 ritazh

/sig auth

ritazh avatar May 09 '22 00:05 ritazh

/triage accepted

ritazh avatar May 31 '22 15:05 ritazh

/milestone v1.25

enj avatar Jun 06 '22 16:06 enj

Hello @ritazh 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands: (updated on June 9, 2022)

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [ ] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following in the open KEP PR https://github.com/kubernetes/enhancements/pull/3302:

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

Priyankasaggu11929 avatar Jun 09 '22 05:06 Priyankasaggu11929

Hello @ritazh 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the pending items done before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

Priyankasaggu11929 avatar Jun 17 '22 17:06 Priyankasaggu11929

With KEP PR https://github.com/kubernetes/enhancements/pull/3302 merged, the enhancement is ready for 1.25 enhancements freeze.

For note, the status is now marked as tracked in the enhancements tracking sheet. Thank you!

Priyankasaggu11929 avatar Jun 21 '22 07:06 Priyankasaggu11929

Hello @ritazh 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

didicodes avatar Jul 13 '22 13:07 didicodes

Hi @ritazh, Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

Currently, the status of the enhancement is marked as at-risk

Thanks :)

Atharva-Shinde avatar Jul 25 '22 15:07 Atharva-Shinde

Hey @ritazh reaching out again as we approach Code Freeze at 01:00 UTC on this Wednesday i.e 3rd August 2022. Try to get the action items done which are mentioned in the comment above before the code-freeze :) The status of the enhancement is still marked as at-risk

Atharva-Shinde avatar Aug 01 '22 15:08 Atharva-Shinde

Thanks @Atharva-Shinde! https://github.com/kubernetes/kubernetes/pull/111126 is currently waiting to be reviewed again by the approvers.

ritazh avatar Aug 01 '22 16:08 ritazh

Hello :wave:, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

Priyankasaggu11929 avatar Aug 03 '22 01:08 Priyankasaggu11929

@Priyankasaggu11929 FYI the exception request has been approved. https://github.com/kubernetes/kubernetes/pull/111126#issuecomment-1204295268

ritazh avatar Aug 03 '22 18:08 ritazh

Thanks for the update @ritazh.

With the k/k PR also merged, I am marking it as tracked for 1.25 release cycle. Thank you so much!

Priyankasaggu11929 avatar Aug 04 '22 04:08 Priyankasaggu11929

Hello @ritazh 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.26
  • [ ] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following before the enhancements freeze:

  • Complete the process of updating the KEP Readme according to the latest test plan, I see TBD in those sections of the readme.
  • Complete and merge the PRR for beta stage.
  • Update the stage and milestone to beta and 1.26 in the kep.yaml file.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Let us know if you have any queries. Thank you!

parul5sahoo avatar Sep 22 '22 14:09 parul5sahoo

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

@parul5sahoo Thanks for reaching out. This enhancement will remain alpha in v1.26 and beta is planned for v1.27. We have merged a PR to update the milestones in the kep.yaml.

aramase avatar Sep 26 '22 21:09 aramase

@parul5sahoo Is the change in kep.yaml https://github.com/kubernetes/enhancements/pull/3551 sufficient? We have moved the beta milestone for this enhancement to v1.27.

aramase avatar Oct 03 '22 23:10 aramase

@parul5sahoo Is the change in kep.yaml #3551 sufficient? We have moved the beta milestone for this enhancement to v1.27.

yes @aramase that works, I've updates the status for this KEP!

parul5sahoo avatar Oct 04 '22 06:10 parul5sahoo

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

rhockenbury avatar Oct 06 '22 01:10 rhockenbury

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 04 '23 02:01 k8s-triage-robot

/remove-lifecycle stale

salaxander avatar Jan 04 '23 02:01 salaxander

@enj does this need to be added to the 1.27 milestone to capture work being done on it?

liggitt avatar Jan 05 '23 23:01 liggitt

/milestone v1.27

Thanks for the reminder @liggitt!

ritazh avatar Jan 06 '23 01:01 ritazh

Hello @ritazh & @aramase 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP readme using the latest template has been merged into the k/enhancements repo.
  • [ ] KEP status is marked as implementable for latest-milestone: v1.27
  • [x] KEP readme has a updated detailed test plan section filled out
  • [ ] KEP readme has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Get a PRR for graduation to beta
  • Update the latest-milestone in the kep.yaml to v1.27
  • Add beta graduation criteria to the README.me

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

marosset avatar Jan 31 '23 01:01 marosset

Is there a KEP update I can review for PRR?

logicalhan avatar Jan 31 '23 18:01 logicalhan

Is there a KEP update I can review for PRR?

Here is the PR for beta update: https://github.com/kubernetes/enhancements/pull/3804

aramase avatar Jan 31 '23 20:01 aramase

Hello @ritazh & @aramase This enhancement meets all the requirements for progressing to beta in v1.27.

Thanks!

/remove-label tracked/no /label tracked/yes

marosset avatar Feb 07 '23 22:02 marosset

Hi @ritazh & @aramase :wave:,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.

Please let me know if there are any PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

marosset avatar Mar 08 '23 20:03 marosset

Hello @ritazh and @aramase

@katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

If you already have existing open PRs please link them to the description so we can easily track them. Thanks!

katmutua avatar Mar 09 '23 23:03 katmutua

These are the PRs we're tracking for beta:

  • https://github.com/kubernetes/kubernetes/pull/116155
  • https://github.com/kubernetes/kubernetes/pull/116345
  • https://github.com/kubernetes/kubernetes/pull/115123

aramase avatar Mar 13 '23 23:03 aramase

The remaining PRs are approved and in the merge queue.

enj avatar Mar 14 '23 23:03 enj