Respect PodTopologySpread after rolling upgrades

[denkensk]

trafficstars

Enhancement Description

• One-line enhancement description (can be used as a release note): Respect PodTopologySpread after rolling upgrades
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md
• Discussion Link: https://docs.google.com/document/d/12F1YXsvy4SmumPiL3LHMLnuMHvyMqSzDqF-L9J37ZfA/edit?usp=sharing
• Primary contact (assignee): @denkensk
• Responsible SIGs: /sig scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.25
  • Beta release target (x.y): 1.27
  • Stable release target (x.y): 1.29
• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3244
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/111441
  • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/35165
• [x] Beta
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3740
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes/kubernetes/pull/116291
    • https://github.com/kubernetes/kubernetes/pull/129874
  • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/39826

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[denkensk]

/sig scheduling

[denkensk]

/assign

[ahg-g]

/milestone v1.25

[Priyankasaggu11929]

Hello @denkensk 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [X] KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable
• [X] KEP has a updated detailed test plan section filled out
• [X] KEP has up to date graduation criteria
• [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[Atharva-Shinde]

Hi @denkensk Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

• [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [ ] All PRs are fully merged by the code freeze deadline.

Currently, the status of the enhancement is marked as at-risk

Thanks :)

[Atharva-Shinde]

Hey @denkensk as https://github.com/kubernetes/kubernetes/pull/111441 PR is now merged and included in the issue description, I have marked this enhancement as tracked :)

[ahg-g]

@denkensk can you please open a docs PR?

[denkensk]

Sorry. I created it before, forgot to link it with this issue. https://github.com/kubernetes/website/pull/35165

[kerthcet]

Hope to see this feature promoting to beta in v1.27, we delayed our blog about the improvements of PodTopologySpread in recent several releases, and we hope to post one in v1.27, including minDomains, nodeInclusionPolicy.

If you're out of bandwidth, I can help with you @denkensk

[denkensk]

Thanks. I will promote it to beta in v1.27.

[alculquicondor]

@denkensk note that the Enhancements freeze has been set for February 10th.

[ahg-g]

@denkensk are you planning to move this to beta? @kerthcet would you like to pick it up if @denkensk can't?

[kerthcet]

@denkensk are you planning to move this to beta? @kerthcet would you like to pick it up if @denkensk can't?

I can help, but up to @denkensk

[denkensk]

@denkensk note that the Enhancements freeze has been set for February 10th.

OK Thanks. I am working on this and will submit PR this week.

[ahg-g]

/label lead-opted-in /milestone v1.27

[ahg-g]

/stage beta

[fsmunoz]

Hello @denkensk 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

• [X] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.27
• [X] KEP readme has a updated detailed test plan section filled out
• [X] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Update kep.yaml to reflect current stage information.
• Complete the missing PRR sections

#3740 might address this, once it's merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[denkensk]

Update kep.yaml to reflect current stage information.

Done @fsmunoz

[fsmunoz]

Thank you @denkensk ! This is almost there, there is a new question in the PRR Scalability that you might want to address:

Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

The Scalability section of the PRR is mandatory for beta, hence why I am mentioning it.

[denkensk]

This is almost there, there is a new question in the PRR Scalability that you might want to address:

Done @fsmunoz

[fsmunoz]

Thank you @denkensk !

• [X] KEP readme using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for latest-milestone: 1.27
• [X] KEP readme has a updated detailed test plan section filled out
• [X] KEP readme has up to date graduation criteria
• [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to beta in v1.27. /label tracked/yes /remove-label tracked/no

[fsmunoz]

Hi @denkensk 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [X] All PRs are fully merged by the code freeze deadline.

• https://github.com/kubernetes/kubernetes/pull/116291

For this enhancement, it looks like all linked PRs are merged.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[alculquicondor]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale