Prevent unauthorised volume mode conversion during volume restore

[RaunakShah]

Enhancement Description

• One-line enhancement description (can be used as a release note): Prevent unauthorised volume mode conversion during volume restore.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3141-prevent-volume-mode-conversion

• Primary contact (assignee): @RaunakShah @xing-yang

• Responsible SIGs: SIG-Storage

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.24
  • Beta release target (x.y): 1.27
  • Stable release target (x.y): 1.30

• [x] Alpha

  • [x] KEP (k/enhancements) update PR(s):
    • https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3141-prevent-volume-mode-conversion
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes-csi/external-snapshotter/pull/665
    • https://github.com/kubernetes-csi/external-snapshotter/pull/670
  • [x] Docs (k/website) update PR(s):
    • https://github.com/kubernetes/website/pull/32673

• [x] Beta

  • [x] KEP (k/enhancements) update PR(s):
    • https://github.com/kubernetes/enhancements/pull/3556
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes-csi/external-provisioner/pull/867
    • https://github.com/kubernetes-csi/external-provisioner/pull/832
    • https://github.com/kubernetes-csi/external-provisioner/pull/793
    • https://github.com/kubernetes-csi/external-provisioner/pull/792
    • https://github.com/kubernetes-csi/external-provisioner/pull/791
    • https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/pull/128
    • https://github.com/kubernetes/test-infra/pull/28307
  • [x] Docs (k/website) update(s):
    • https://github.com/kubernetes/website/pull/39367

• [x] Stable

  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4459, https://github.com/kubernetes/enhancements/pull/4497

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[RaunakShah]

/sig storage

[gracenng]

Hi @RaunakShah ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting alpha for 1.24, is that correct?. Here’s where this enhancement currently stands:

• [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [x] KEP status is marked as implementable for this release with latest-milestone: 1.24
• [x] KEP has a test plan section filled out.
• [x] KEP has up to date graduation criteria.
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk Thanks!

[xing-yang]

/milestone v1.24

[xing-yang]

@gracenng Yes, this is targeting Alpha in 1.24.

[gracenng]

Hi @RaunakShah , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd. Updated some points on the check list above, let me know if I missed anything. I'm monitoring #3151 and current status is at risk

[gracenng]

All good for 1.24 Enhancements Freeze

[xing-yang]

@gracenng Should this have a Tracked/Yes label?

[didicodes]

Hi @xing-yang & @RaunakShah, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

[gracenng]

Hi @RaunakShah 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

[xing-yang]

PRs are submitted here: https://github.com/kubernetes-csi/external-snapshotter/pull/665 https://github.com/kubernetes-csi/external-snapshotter/pull/670

[xing-yang]

@gracenng It might be better to label this feature as "tracked/out-of-tree" as all the code changes are out-of-tree.

[gracenng]

All good for Code Freeze!

[nate-double-u]

Hi @RaunakShah, reminder that tomorrow (April 5th) is the deadline for 1.24 Docs Ready for Review.

Please open a PR (and link it back here), push your docs content for this enhancement, and remove the work-in-progress label when ready for review.

We have a tight turnaround to getting docs reviewed and approved for the release, and we’re hoping to have all docs in for review by tomorrow. Thank you!

[xing-yang]

Here's the doc PR: https://github.com/kubernetes/website/pull/32673

[RaunakShah]

@nate-double-u @xing-yang I've removed the WIP label from the doc PR.

[sftim]

This enhancement proposal mentions the annotation snapshot.storage.kubernetes.io/allowVolumeModeChange. Would it be possible to deprecate that in favor of a more conventional snapshot.storage.kubernetes.io/allow-volume-mode-change?

[xing-yang]

This enhancement proposal mentions the annotation snapshot.storage.kubernetes.io/allowVolumeModeChange. Would it be possible to deprecate that in favor of a more conventional snapshot.storage.kubernetes.io/allow-volume-mode-change?

We could do that in 1.25.

[nate-double-u]

A note for when this KEP goes to beta (targeting v1.25): the documentation that was added in v1.24 needs to be updated.

[Priyankasaggu11929]

/milestone clear

[RaunakShah]

Updated the KEP description to target beta in 1.26 (as opposed to 1.25).

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[RaunakShah]

/remove-lifecycle stale

[xing-yang]

/milestone v1.26

[parul5sahoo]

Hello @RaunakShah 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.26
• [ ] KEP readme has a updated detailed test plan section filled out
• [x] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following before the enhancements freeze:

• Edit the test plan section in the KEP's README to include the agreement mentioned in the latest template linked above.
• update the status from provisional to implementable in the kep.yaml and change the stage from alpha to beta.
• complete the PRR and merge it for the beta stage.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Let us know if you have any queries. Thank you!

[parul5sahoo]

Hello @RaunakShah just a quick remainder the enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

[xing-yang]

Hi @parul5sahoo, e2e tests are still WIP so we can't get the KEP merged today. Since the implementation is completely out-of-tree, we will continue to work on it. Please keep the tracked/out-of-tree label.

[parul5sahoo]

Hey @xing-yang there isn't a tracked/out-of-tree label available for KEPs at the moment, so maybe you can just file an exception request post enhancement freeze.

[rhockenbury]

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale