Introduce nodeExpandSecret in CSI PV source

[humblec]

Enhancement Description

CSI spec 1.5 enhanced the spec to add optional secrets field to NodeExpandVolumeRequest. To support this, we need to have NodeExpandSecret to the CSI PV source and also derive the expansion secret in csiclient to send it out as part of the nodeexpand request.

• Kubernetes Enhancement Proposal:

• Discussion Link: https://github.com/kubernetes/kubernetes/pull/105963#discussion_r751464740

• Primary contact (assignee): @humblec

• Responsible SIGs: sig storage

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.25
  • Beta release target (x.y): 1.26
  • Stable release target (x.y): 1.27

• [ ] Alpha

  • [ ] KEP (k/enhancements) update PR(s):
  • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/105963
  • [ ] Docs (k/website) update PR(s): https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/556-csi-volume-resizing/README.md https://github.com/kubernetes/enhancements/pull/3038

• Additional Ref: https://github.com/kubernetes/kubernetes/issues/95367 https://github.com/container-storage-interface/spec/pull/457

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[humblec]

/sig storage

[humblec]

Cc @xing-yang @msau42 @jsafrane @gnufied

[humblec]

Cc @zhucan

[xing-yang]

/milestone v1.24

[msau42]

@humblec do you plan to put together a kep for this?

[humblec]

@humblec do you plan to put together a kep for this?

Yeah, thats the plan @msau42 .

[rhockenbury]

Hi @humblec! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Here’s where this enhancement currently stands:

• [x] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [x] KEP status is marked as implementable for latest-milestone: 1.24
• [x] KEP has a test plan section filled out.
• [x] KEP has up to date graduation criteria.
• [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

Please plan to submit a KEP and PRR to satisfy this list of requirements. The status of this enhancement is at risk. Thanks!

[rhockenbury]

With #3173 merged, I've updated this to tracked for enhancement freeze.

[didicodes]

Hi @humblec, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

[salaxander]

Hi @humblec 👋

Checking in once more as we approach 1.24 code freeze at 01:00 UTC Wednesday 30th March 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this one, it looks like we're currently waiting on https://github.com/kubernetes/kubernetes/pull/105963 and https://github.com/kubernetes/kubernetes/issues/95367 to merge?

As always, we are here to help should questions come up.

Thanks!!

[gracenng]

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

https://github.com/kubernetes/kubernetes/pull/105963 needs approval

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

[xing-yang]

/milestone v1.25

[Atharva-Shinde]

Hello @humblec 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 release

Here's where this enhancement currently stands:

• [ ] KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for latest milestone: 1.25
• [ ] KEP has an updated detailed test plan section filled out
• [X] KEP has up to date graduation criteria
• [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

So it looks like for this one, we would just need to update the following:

• The KEP needs updating it's Test Plan Section to incorporate more details as stated in the updated detailed test plan

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[humblec]

@Atharva-Shinde ok, let me update the test plan section ,that should be it

[Atharva-Shinde]

Hello @humblec 👋, just a quick check-in again.

The enhancements freeze for 1.25 starts on this Thursday, June 16, 2022 at 18:00 PM PT.

Currently the status of the Pull Request #3359 is-

• DONE ~~The KEP needs updating it's Test Plan Section to incorporate more details as stated in the updated detailed test plan~~

Now you just need to get the pull request #3359 merged before the enhancements freeze commence :)

Note: For now the current status of the enhancement is still marked at-risk.

[humblec]

Its done!

[Atharva-Shinde]

Hey @humblec

With the KEP PR #3359 merged, this enhancement is all set for the 1.25 Enhancements Freeze! (which is now extended to next week till Thursday June 23, 2022)

The status of the enhancement is now marked as tracked.🥳

[krol3]

Hello @humblec 👋, 1.25 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

[Priyankasaggu11929]

Hi @humblec 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

• [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• [X] All PRs are fully merged by the code freeze deadline.
  • https://github.com/kubernetes/kubernetes/pull/105963

Please verify, if there are any additional k/k PRs besides the ones listed above.

Since, the above listed PRs are merged, the status of the enhancement is currently marked as tracked. Thank you so much!

[krol3]

@humblec It was added this PR about documentation dev-1.25 release. https://github.com/kubernetes/website/pull/35334

[humblec]

@humblec It was added this PR about documentation dev-1.25 release. kubernetes/website#35334

Thanks @krol3 , hope nothing is pending on this feature for 1.25. I also have a blog PR for this feature https://github.com/kubernetes/website/pull/33979

[Atharva-Shinde]

Hey @humblec 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [X] KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable
• [X] KEP has an updated detailed test plan section filled out
• [ ] KEP has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to:

• Update the kep.yaml to reflect the current stage information
• Update the production readiness review with latest information
• Include the new updated PR of this KEP in the Issue Description and get it merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[Atharva-Shinde]

Hello @humblec 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

[rhockenbury]

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[fsmunoz]

Hello @humblec 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage ~~alpha~~ beta for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.27
• [X] KEP readme has a updated detailed test plan section filled out
• [ ] KEP readme has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Update kep.yaml to reflect current stage information.
• Update Graduation Criteria
• Complete the missing PRR sections

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[humblec]

This enhancement is targeting for stage alpha for 1.27 (please correct me, if otherwise)

@fsmunoz we are targeting beta with 1.27 release Ref # https://github.com/kubernetes/enhancements/pull/3531

The main work of adding e2e has been covered here https://github.com/kubernetes/kubernetes/pull/115451

cc @xing-yang @msau42

[fsmunoz]

@humblec apologies, corrected! I'll take another look during the weekend.

[fsmunoz]

@humblec could you update the issue description to point to the KEP and show the beta checkboxes?

Looking at the KEP there is a new question in the PRR Scalability that you might want to address:

Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

The Scalability section of the PRR is mandatory, for beta enhancements. The rest is as per my latest comment.