Take taints/tolerations into consideration when calculating PodTopologySpread skew

[kerthcet]

Enhancement Description

• One-line enhancement description (can be used as a release note): Take taints/tolerations into consideration when calculating PodTopologySpread skew
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/3105
• Discussion Link: https://github.com/kubernetes/kubernetes/issues/106127
• Primary contact (assignee): @kerthcet
• Responsible SIGs: sig-scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.25
  • Beta release target (x.y): 1.26
  • Stable release target (x.y): TBD
• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3105
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/108492 https://github.com/kubernetes/kubernetes/pull/108884
  • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/35044
• [ ] Beta
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3539
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kerthcet]

/sig scheduling /cc @Huang-Wei @alculquicondor @ahg-g

The milestone should still be discussed about.

[kerthcet]

/assign

[ahg-g]

/milestone v1.24

[kerthcet]

Tip: When we time to graduate this to Beta, don't forget this advices. @kerthcet https://github.com/kubernetes/enhancements/pull/3105#discussion_r788736845

[Priyankasaggu11929]

Hello @kerthcet 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

For note, This enhancement is targeting for stage alpha for 1.24 (correct me, if otherwise)

Here’s where this enhancement currently stands:

• [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for this release
• [X] KEP has a test plan section filled out.
• [X] KEP has up to date graduation criteria.
• [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[alculquicondor]

Hi, is there any progress on the implementation PR?

[kerthcet]

Hi, is there any progress on the implementation PR?

Yes, but I'm waiting for this https://github.com/kubernetes/kubernetes/pull/107421 merged first for some potential conflicts.

[PI-Victor]

Hi @kerthcet 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[kerthcet]

Hi all, the api part of this kep has been finished in https://github.com/kubernetes/kubernetes/pull/108492, please take a look if you guys have time.

[Priyankasaggu11929]

Hello @kerthcet 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• [ ] All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • https://github.com/kubernetes/kubernetes/pull/108492
• [ ] Have a documentation placeholder PR open by Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Kindly please let me know if I'm missing any open PRs other than the ones I linked above. Thank you so much!

[kerthcet]

Thanks @Priyankasaggu11929 , no PR missed. I'll focus on this kep these days.

[gracenng]

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

[kerthcet]

Exception was rejected and I'd like to merge this one to release 1.25 then.

[alculquicondor]

@ahg-g can you please add to milestone?

[ahg-g]

/milestone v1.25

[Priyankasaggu11929]

Hello @ahg-g @alculquicondor 👋 could you please add this enhancement to the tracking sheet so that the release team can begin tracking it? Thanks so much!

[alculquicondor]

Done. Thanks for the reminder!

[jasonbraganza]

Hello @kerthcet 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable
• [ ] KEP has a updated detailed test plan section filled out
• [X] KEP has up to date graduation criteria
• [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to do the following:

• update the KEP README.md to add more details in the Test Plan section, in furtherance of the goal of increasing reliability across the project.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[kerthcet]

I'll update this later tomorrow.

[kerthcet]

Hi @jasonbraganza I have update the KEP with the latest template and add the missed test plans.

[jasonbraganza]

Thank you very much @kerthcet. I will mark the KEP as tracked in our enhancements sheet.

[parul5sahoo]

Hi @kerthcet 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

• [x] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

• [x] All PRs are fully merged by the code freeze deadline.

  • https://github.com/kubernetes/kubernetes/pull/108492
  • https://github.com/kubernetes/kubernetes/pull/108884

All PRs seem to be merged. And since you've checked the code k/k item in the issue description, the enhancement is marked as tracked.

As always, we are here to help should questions come up.

Thanks!!

[alculquicondor]

@kerthcet can you reopen the website PR?

[kerthcet]

I already created the placeholder pr here https://github.com/kubernetes/website/pull/35044, would like to finish it next week.

[kerthcet]

I'd like to upgrade this to beta in v1.26.

[alculquicondor]

/label lead-opted-in

[k8s-ci-robot]

@alculquicondor: Can not set label lead-opted-in: Must be member in one of these teams: [sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahg-g]

/label lead-opted-in

[k8s-ci-robot]

@ahg-g: Can not set label lead-opted-in: Must be member in one of these teams: [sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

/label lead-opted-in