enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

PodHealthyPolicy for PodDisruptionBudget

Open mortent opened this issue 2 years ago โ€ข 53 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add PodHealthyPolicy to PodDisruptionBudget
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md
  • Discussion Link: https://www.youtube.com/watch?v=rP-XUjyCaps&list=PL69nYSiGNLP2LMq7vznITnpd2Fk1YIZF3
  • Primary contact (assignee): @ravisantoshgudimetla @atiratree
  • Responsible SIGs: sig-apps
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.26
    • Beta release target (x.y): 1.27
    • Stable release target (x.y): 1.30
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3018
      • https://github.com/kubernetes/enhancements/pull/3546
      • https://github.com/kubernetes/enhancements/pull/3584
      • https://github.com/kubernetes/enhancements/pull/3677
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/113375
    • [x] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/37768
  • [x] Beta
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3777
      • https://github.com/kubernetes/enhancements/pull/3883
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/115363
      • https://github.com/kubernetes/kubernetes/pull/115914
      • https://github.com/kubernetes/kubernetes/pull/115861
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/40017
  • [ ] Stable
    • [ ] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4469
    • [ ] Code:
      • https://github.com/kubernetes/kubernetes/pull/123428
    • [ ] Docs:
      • https://github.com/kubernetes/website/pull/45263
      • https://github.com/kubernetes/website/pull/45269

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

mortent avatar Oct 24 '21 22:10 mortent

/sig apps

mortent avatar Oct 24 '21 22:10 mortent

/cc

shivanshuraj1333 avatar Oct 27 '21 10:10 shivanshuraj1333

/milestone v1.24

soltysh avatar Jan 21 '22 12:01 soltysh

Hello @mortent

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Hereโ€™s where this enhancement currently stands:

  • [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for this release
  • [X] KEP has a test plan section filled out.
  • [X] KEP has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue KEP link and the description up-to-date.
Thanks!

hosseinsalahi avatar Jan 28 '22 16:01 hosseinsalahi

Hi @mortent ๐Ÿ‘‹๐Ÿป 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

mehabhalodiya avatar Feb 12 '22 05:02 mehabhalodiya

Hello @mortent

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • [X] Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

  • https://github.com/kubernetes/kubernetes/pull/108233

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

hosseinsalahi avatar Mar 21 '22 17:03 hosseinsalahi

Hi @mortent Weโ€™re reminding people with KEPs that need docs to open a placeholder PR. Although the deadline for this is March 31, we have more than 30 that have yet to be opened, so weโ€™re trying to get ahead of it. Let me know if you have any questions. Thanks!

mehabhalodiya avatar Mar 23 '22 12:03 mehabhalodiya

@mehabhalodiya I have created a placeholder PR for the docs: https://github.com/kubernetes/website/pull/32567

@encodeflush Yes, I can confirm that https://github.com/kubernetes/kubernetes/pull/108233 is the implementation of this feature.

mortent avatar Mar 28 '22 00:03 mortent

Hi, 1.24 Enhancements Lead here ๐Ÿ‘‹. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

gracenng avatar Mar 30 '22 01:03 gracenng

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 28 '22 01:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jul 28 '22 02:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Aug 27 '22 02:08 k8s-triage-robot

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 27 '22 02:08 k8s-ci-robot

/milestone v1.26 /label lead-opted-in /remove-lifecycle rotten

soltysh avatar Sep 29 '22 17:09 soltysh

/stage alpha

soltysh avatar Sep 29 '22 17:09 soltysh

/label tracked/yes /remove-label tracked/no

rhockenbury avatar Sep 30 '22 00:09 rhockenbury

Hey @mortent ๐Ÿ‘‹, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable
  • [ ] KEP has an updated detailed test plan section filled out
  • [ ] KEP has up to date graduation criteria
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to:

  • The KEP needs updating it's Test Plan Section to incorporate details as stated in the updated detailed test plan
  • Update the kep.yaml to reflect the current milestone information
  • Include the new updated PR of this KEP in the Issue Description and get it merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Atharva-Shinde avatar Oct 02 '22 12:10 Atharva-Shinde

The KEP needs updating it's Test Plan Section to incorporate details as stated in the updated detailed test plan

opened a PR for the test plan update: https://github.com/kubernetes/enhancements/pull/3584

Update the kep.yaml to reflect the current milestone information

the milestone information should be correct in the kep.yaml already: https://github.com/kubernetes/enhancements/pull/3546

atiratree avatar Oct 05 '22 14:10 atiratree

@Atharva-Shinde with #3584 in this should all be good.

soltysh avatar Oct 05 '22 15:10 soltysh

Hey @atiratree @soltysh @mortent, as #3584 is merged with required changes, I've updated the status of this KEP to tracked for v1.26 release cycle :)

Atharva-Shinde avatar Oct 05 '22 16:10 Atharva-Shinde

Hey @mortent @atiratree ๐Ÿ‘‹,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are linked in the issue description above(for tracking purposes). If there are any other PRs beyond: https://github.com/kubernetes/kubernetes/pull/113375 and https://github.com/kubernetes/kubernetes/pull/113376, please include them in the issue description too.
  • [ ] All PRs are fully merged by the code freeze deadline.

As always, we are here to help should questions come up. Thanks :)

Atharva-Shinde avatar Oct 31 '22 17:10 Atharva-Shinde

Hello @mortent and @atiratree ๐Ÿ‘‹ 1.26 Release Docs shadow here!

This enhancement is marked as โ€˜Needs Docsโ€™ for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

cathchu avatar Nov 02 '22 03:11 cathchu

Hey @mortent @atiratree ๐Ÿ‘‹, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow. Looks like we would at least need to get the code PR/s: https://github.com/kubernetes/kubernetes/pull/113375 and https://github.com/kubernetes/kubernetes/pull/113376 (any more PRs?) merged before the code-freeze. Could you also please update the Issue Description with related PRs:)

Atharva-Shinde avatar Nov 07 '22 16:11 Atharva-Shinde

@cathchu thanks, I have opened a placeholder PR https://github.com/kubernetes/website/pull/37768

@mortent: could you please update the description?

@Atharva-Shinde: yes it is only these two PRs. I have also created an exception request for a 5 day extension.

atiratree avatar Nov 07 '22 21:11 atiratree

Hello ๐Ÿ‘‹, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in

rhockenbury avatar Nov 09 '22 01:11 rhockenbury

@rhockenbury based on the exception granted I think we should bring this back to 1.26 milestone

soltysh avatar Nov 10 '22 13:11 soltysh

/milestone v1.26 /label tracked/yes /label lead-opted-in /remove-label tracked/no

leonardpahlke avatar Nov 10 '22 18:11 leonardpahlke

Hey @atiratree, 1.26 Docs Shadow here ๐Ÿ‘‹ !

Just a gentle reminder that the deadline (November 15th) for PRs ready to review has passed.

Please complete https://github.com/kubernetes/website/pull/37768 and request a review as soon as possible.

Thanks you!

CC @krol3

cathchu avatar Nov 18 '22 20:11 cathchu

Hi @atiratree here Doc Lead 1.26, I need help with this PR, the deadline has passed.

krol3 avatar Nov 21 '22 17:11 krol3

I have created PRs for the blog update https://github.com/kubernetes/website/pull/37627 and the KEP update https://github.com/kubernetes/enhancements/pull/3677

atiratree avatar Dec 08 '22 00:12 atiratree