enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Track Ready Pods in Job status

Open alculquicondor opened this issue 3 years ago • 21 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add a ready field to the Job status that track the number of Pods with the Ready condition.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2879-ready-pods-job-status
  • Discussion Link: kubernetes/kubernetes#104422
  • Primary contact (assignee): @alculquicondor
  • Responsible SIGs: sig-apps
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.23
    • Beta release target (x.y): 1.24
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s): #2880
    • [x] Code (k/k) update PR(s): kubernetes/kubernetes#104915
    • [x] Docs (k/website) update PR(s): kubernetes/website#30593
  • [ ] Beta
    • [x] KEP (k/enhancements) update PR(s): #3111, #3249
    • [x] Code (k/k) update PR(s): kubernetes/kubernetes#107476
    • [x] Docs (k/website) update PR(s): kubernetes/website#32396

alculquicondor avatar Aug 19 '21 15:08 alculquicondor

/assign /sig apps

alculquicondor avatar Aug 19 '21 15:08 alculquicondor

/milestone v1.23

salaxander avatar Sep 01 '21 15:09 salaxander

Hi @alculquicondor! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • ~~[X ] KEP status is marked as implementable~~
  • ~~[X ] KEP has a test plan section filled out.~~
  • ~~[X ] KEP has up to date graduation criteria.~~
  • ~~[ X] KEP has a production readiness review that has been completed and merged into k/enhancements.~~

Looks like for this one we would just need the KEP to merge by enhancements freeze :)

Thanks!

salaxander avatar Sep 01 '21 16:09 salaxander

Hi @alculquicondor :wave: 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

jlbutler avatar Sep 22 '21 19:09 jlbutler

Hi @alculquicondor :wave: 1.23 Docs shadow here. This enhancement is marked as ‘Needs Docs’ for the 1.23 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT. Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thanks!

chrisnegus avatar Nov 17 '21 20:11 chrisnegus

Hi @alculquicondor and @kubernetes/sig-apps-misc , 1.23 Release Lead here. We're a day past the 1.23 Docs Placeholder PR deadline and this enhancement is marked as 'Needs Docs' for 1.23 and is without a linked Doc PR to the dev-1.23 branch in k/website.

Since this feature is going to be alpha in 1.23, is this enhancement feature-gated? Does the Feature Gates page need to be updated with this enhancement? Does other documentation on kubernetes.io need to be updated or created? If so, please create a PR to the dev-1.23 branch in k/website ASAP

reylejano avatar Nov 19 '21 19:11 reylejano

The PR is up. Sorry about the delay. I missed this before going on vacation.

alculquicondor avatar Nov 22 '21 14:11 alculquicondor

The PR is up. Sorry about the delay. I missed this before going on vacation.

Not a problem. Thanks so much for getting this done! Is the feature gate information all that needs to be updated or are more docs needed? If that's it, I'll work on getting it looked at and merged.

chrisnegus avatar Nov 22 '21 15:11 chrisnegus

that's all that's needed. The rest is already part of the API reference.

alculquicondor avatar Nov 22 '21 15:11 alculquicondor

/milestone v1.24

soltysh avatar Jan 18 '22 14:01 soltysh

Hi @alculquicondor ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting beta for 1.24 Here’s where this enhancement currently stands:

  • [x] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for this release with latest-milestone: 1.24
  • [x] KEP has a test plan section filled out.
  • [x] KEP has up to date graduation criteria.
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as tracked. ~~I think there's a mistake in this issue description, it should be beta instead of stable right?~~ Thanks!

gracenng avatar Jan 22 '22 03:01 gracenng

KEP PR is merged and description is up to date

alculquicondor avatar Jan 24 '22 14:01 alculquicondor

Hi @alculquicondor 👋🏻 1.24 Docs shadow here. The Docs status for this enhancement is marked as 'None Required' for the 1.24 release. Are you targeting any changes that would affect docs for this KEP for the upcoming 1.24 release? Please confirm. Thanks!

mehabhalodiya avatar Feb 22 '22 02:02 mehabhalodiya

Yes, we just need to update the graduation status to beta.

alculquicondor avatar Feb 22 '22 15:02 alculquicondor

@alculquicondor Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

mehabhalodiya avatar Feb 22 '22 16:02 mehabhalodiya

Hello @alculquicondor

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • [X] Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.
    • https://github.com/kubernetes/website/pull/32396

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

  • https://github.com/kubernetes/kubernetes/pull/107476
  • https://github.com/kubernetes/enhancements/pull/3249

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

hosseinsalahi avatar Mar 21 '22 17:03 hosseinsalahi

yes, they are both part of the enhancement and there are no more PRs.

alculquicondor avatar Mar 21 '22 17:03 alculquicondor

Added documentation PR

alculquicondor avatar Mar 21 '22 19:03 alculquicondor

@Priyankasaggu11929 I changed the stage to beta. Should we mark this tracked in 1.24?

janetkuo avatar May 13 '22 19:05 janetkuo

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 11 '22 19:08 k8s-triage-robot

/remove-lifecycle stale

alculquicondor avatar Aug 11 '22 19:08 alculquicondor

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 21 '22 10:12 k8s-triage-robot

/remove-lifecycle stale

alculquicondor avatar Dec 21 '22 14:12 alculquicondor

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 21 '23 14:03 k8s-triage-robot

/remove-lifecycle stale

We can graduate to GA in 1.28

alculquicondor avatar Mar 21 '23 14:03 alculquicondor

/remove-lifecycle stale

We can graduate to GA in 1.28

What items is needed for this?

kannon92 avatar May 11 '23 09:05 kannon92

https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2879-ready-pods-job-status#ga

Given that there were no bug reports, the only item left is exploring different batch sizes to see if we get better scale without sacrificing latency.

alculquicondor avatar May 11 '23 15:05 alculquicondor

Ah, I may need someone else to do that. I don't really have a good k8 environment for doing performance testing.

kannon92 avatar May 11 '23 15:05 kannon92

/milestone v1.29 /label lead-opted-in

soltysh avatar Sep 27 '23 11:09 soltysh

@soltysh should we change the stage on this to stable?

jeremyrickard avatar Sep 29 '23 15:09 jeremyrickard