Keystone containers KEP

[adisky]

Enhancement Description

• One-line enhancement description (can be used as a release note): Terminate pods on the basis of keystone(main/app/essential) containers completion status.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/2869
• Discussion Link: https://kubernetes.slack.com/archives/C0BP8PW9G/p1620304727344300
• Primary contact (assignee): @adisky @matthyx
• Responsible SIGs: SIG Node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.25
  • Stable release target (x.y):
• [ ] Alpha
  • [ ] KEP (k/enhancements) update PR(s):
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[adisky]

/sig node

[adisky]

This KEP will be helpful in solving the blocking Job issue without making complex changes to pod lifecycle and kubelet code. We are planning to achieve with an annotation for alpha and depending on further feedback move it to pod API and proceed towards sidecar proposal

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[adisky]

/remove-lifecycle stale

[will-wang-jx]

@adisky What is the status of this effort?

[yuzhiquan]

/cc

[hosseinsalahi]

Hello @adisky

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

• [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo. - KEP file PR is pending.
• [ ] KEP status is marked as implementable for this release
• [ ] KEP has a test plan section filled out.
• [ ] KEP has up to date graduation criteria.
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date for release v1.24. Thanks!

[gracenng]

The Enhancements Freeze is now in effect and this enhancement is removed from the release. Please feel free to file an exception.

/milestone clear

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[matthyx]

/remove-lifecycle stale

[alculquicondor]

Is there anyone still working on this?

[matthyx]

Yes please expect my code proposal in the next days.

On Wed, Jul 13, 2022, 19:47 Aldo Culquicondor @.***> wrote:

Is there anyone still working on this?

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/2872#issuecomment-1183508629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5ZVENMDJASOVE2XHH6FODVT36KFANCNFSM5CLNNEBQ . You are receiving this because you were assigned.Message ID: @.***>

[matthyx]

Here is my proposal, I did it this way to minimize disruption in the code: https://github.com/matthyx/kubernetes/tree/keystone-kep

[alculquicondor]

Is the KEP PR up-to-date?

[matthyx]

Is the KEP PR up-to-date?

Nope, I probably need to change at least the target release, which is 1.26 And there is also the new PRR process to fill, etc...

[InbarRose]

Here is my proposal, I did it this way to minimize disruption in the code: https://github.com/matthyx/kubernetes/tree/keystone-kep

Looking at your current commit https://github.com/matthyx/kubernetes/commit/3de76f30e71264243277201c84d116788d25b1ac it seems that this still does not address the jobs issue, ie: a job with multiple containers will not mark as complete if the sidecar is still running. is that planned to be solved here?

[matthyx]

It should... Can you write a test case for it?

[matthyx]

It should... Can you write a test case for it?

Actually it's exactly this test IMHO: https://github.com/matthyx/kubernetes/commit/3de76f30e71264243277201c84d116788d25b1ac#diff-371558f28f06f65eb2a800352c298a651ea1f08bdf0107c4cc05d21d80a41965R1545-R1556

[alculquicondor]

This might be relevant for /wg-batch

[rlnrln]

What's the current status of this? Can we expect this to go into Kubernetes v1.26?

Something like this has been much-needed for 5 years now. Is there anything I, who is not a kubernetes or Go developer, can help move this along so we don't have to rely on various workarounds for our CronJobs?

[alculquicondor]

You can leave your thoughts in #2869

[matthyx]

@dchen1107 how to make it leald-opted-in in https://github.com/orgs/kubernetes/projects/98/views/1 ?

[matthyx]

@marosset can you track this one for 1.26 please?

[marosset]

/milestone v1.26 /label lead-opted-in (I'm doing this on behalf of @ruiwen-zhao / SIG-node)

[rhockenbury]

/stage alpha /label tracked/yes

[Atharva-Shinde]

Hey @matthyx @adisky 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26

Here's where this enhancement currently stands:

• [X] KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable
• [X] KEP has an updated detailed test plan section filled out
• [X] KEP has up to date graduation criteria
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to:

• Get this PR #2869 merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[Atharva-Shinde]

A quick follow-up question, is there any reason to include #753 's production readiness review file in this Enhancement Proposal pull request?

[derekwaynecarr]

i am fine leaving this as tracked, but we still have not reached consensus on the kep.

hopeful across @thockin and @SergeyKanzhelev we can find a path forward.

[Atharva-Shinde]

Hello @matthyx @adisky 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

[rhockenbury]

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in