enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Kubelet OpenTelemetry Tracing

Open sallyom opened this issue 4 years ago β€’ 96 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Instrument kubelet to generate and export OpenTelemetry trace data.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/2831-kubelet-tracing/README.md
  • Discussion Link:
  • Primary contacts (assignee): @sallyom, @dashpole
  • Responsible SIGs: SIG-Instrumentation
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.25)
    • Beta release target (1.27)
    • Stable release target (1.33)
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/2832
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/105126
    • [x] Docs (k/website) update PR(s):
      • https://github.com/kubernetes/website/pull/35137
  • [x] Beta
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3714
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/114504
      • https://github.com/kubernetes/kubernetes/pull/115750
    • [x] Docs (k/website) update(s):
      • https://github.com/kubernetes/website/pull/39904
  • [ ] Stable
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/5134
    • [ ] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/132341
    • [ ] Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

sallyom avatar Jul 21 '21 03:07 sallyom

@sallyom can you please add the mandatory discussion link to this issue?

kikisdeliveryservice avatar Jul 26 '21 17:07 kikisdeliveryservice

/sig node instrumentation

ehashman avatar Sep 08 '21 17:09 ehashman

/assign

logicalhan avatar Oct 28 '21 16:10 logicalhan

/cc

shivanshuraj1333 avatar Oct 28 '21 16:10 shivanshuraj1333

/cc

yangjunmyfm192085 avatar Jan 14 '22 08:01 yangjunmyfm192085

/cc

249043822 avatar Jan 14 '22 08:01 249043822

Hello @sallyom

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

  • [X] Updated KEP file using the latest template has been merged into the k/enhancements repo. ~~- KEP file PR is pending.~~
  • [X] KEP status is marked as implementable for this release
  • [X] KEP has a test plan section filled out.
  • [X] KEP has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date for release v1.24. Thanks!

hosseinsalahi avatar Jan 20 '22 10:01 hosseinsalahi

@encodeflush thanks for the check-in - ~I'm not sure what the production readiness review is~ edit: found it, will add the questionnaire, I don't see it on the enhancements README ~can you point me to the steps to get that done~? Thanks again. Also, am I meant to check those off as they are done or are they for someone else to decide?

sallyom avatar Jan 20 '22 13:01 sallyom

@sallyom Thanks for the update. Those criterion should be fulfilled form your side. From enhancements team point of view, we go through them and check if your KEP meets the requirements.

hosseinsalahi avatar Jan 28 '22 15:01 hosseinsalahi

Hi @sallyom πŸ‘‹ 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

chrisnegus avatar Feb 11 '22 19:02 chrisnegus

Hi @sallyom :wave: 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

valaparthvi avatar Mar 21 '22 04:03 valaparthvi

Hello @sallyom

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • [ ] All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • [ ] Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

  • https://github.com/kubernetes/kubernetes/pull/105126
  • https://github.com/kubernetes/enhancements/pull/3087

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

hosseinsalahi avatar Mar 21 '22 16:03 hosseinsalahi

https://github.com/kubernetes/enhancements/pull/3087 is not directly related to the overall OpenTelemetry enhancements.

ddebroy avatar Mar 22 '22 17:03 ddebroy

https://github.com/kubernetes/kubernetes/pull/105126 is the initial implementation for this enhancement

sallyom avatar Mar 23 '22 12:03 sallyom

Hi @sallyom :wave: 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

Hey @sallyom, can you please add a placeholder PR for this feature in https://github.com/kubernetes/website by March 30, that is our extended deadline for feature blog freeze?

Example of a feature blog PR: https://github.com/kubernetes/website/pull/30538 Example of a feature blog: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md

valaparthvi avatar Mar 29 '22 06:03 valaparthvi

Hi, 1.24 Enhancements Lead here πŸ‘‹. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

gracenng avatar Mar 30 '22 01:03 gracenng

Hi @sallyom a question about Kubelet Tracing. Is there any trace information about the PLEG of the kubelet itself?

wondywang avatar Apr 20 '22 03:04 wondywang

KEP will need to be updated with the new release versions since 1.24 was missed.

logicalhan avatar May 12 '22 16:05 logicalhan

/milestone v1.25

Priyankasaggu11929 avatar Jun 10 '22 02:06 Priyankasaggu11929

Hello @sallyom πŸ‘‹, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • [x] KEP file using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [x] KEP has up to date graduation criteria
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

marosset avatar Jun 10 '22 19:06 marosset

Hello @marosset please see the PR to KEP-2831 https://github.com/kubernetes/enhancements/pull/3404, where I've updated

  • implentation history
  • testing plan
  • milestones

Thank you!

sallyom avatar Jun 16 '22 20:06 sallyom

Hi @sallyom #3404 has everything required to track this enhancement for v1.25.

Please note that enhancement freeze is on 18:00 PST on Thursday June 23, 2022

Thanks!

marosset avatar Jun 17 '22 23:06 marosset

Hello πŸ‘‹, just a quick check-in again, as we approach the 1.25 enhancements freeze.

The Open PR https://github.com/kubernetes/enhancements/pull/3404 is waiting on a SIG approval/lgtm.

Please plan to get the PR merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT (which is just over 3 days away from now)

For note, the current status of the enhancement is atat-risk. Thank you!

Priyankasaggu11929 avatar Jun 21 '22 05:06 Priyankasaggu11929

Hello @somalley, @husky-parul πŸ‘‹, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable for this release
  • [X] KEP has a updated detailed test plan section filled out
  • [X] KEP has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place & merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. πŸš€

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

marosset avatar Jun 22 '22 17:06 marosset

Hello @sallyom and @husky-parul! :wave:,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

sethmccombs avatar Jul 12 '22 22:07 sethmccombs

Hi @sallyom, @husky-parul πŸ‘‹

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

  • [X] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [ ] All PRs are fully merged by the code freeze deadline.
    • https://github.com/kubernetes/kubernetes/pull/105126

Please verify, if there are any additional k/k PRs besides the ones listed above. Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk. Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

jasonbraganza avatar Jul 25 '22 06:07 jasonbraganza

Hi @jasonbraganza

@sallyom has a PR WIP for this. She is on PTO but will close this before the said deadline. Thank you for following up with us. :)

husky-parul avatar Jul 25 '22 20:07 husky-parul

Hello @sallyom, @husky-parul πŸ‘‹πŸΏ

Just a gentle reminder from the enhancement team as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022, tomorrow.

Please plan to get the open k/k PRs merged by then

The status of this enhancement is currently marked as at risk

Thank you!

jasonbraganza avatar Aug 02 '22 05:08 jasonbraganza

With k/k PR https://github.com/kubernetes/kubernetes/pull/105126 merged now, this enhancement is marked as tracked for 1.25 code freeze. Thank you so much @sallyom @husky-parul.

Priyankasaggu11929 avatar Aug 03 '22 00:08 Priyankasaggu11929

/assign @dashpole

logicalhan avatar Sep 22 '22 16:09 logicalhan