enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Reduction of Secret-based Service Account Tokens

Open zshihang opened this issue 4 years ago β€’ 45 comments

Enhancement Description

  • One-line enhancement description: reduce secret-based service account tokens
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/2799-reduction-of-secret-based-service-account-token
  • Discussion Link: sig-auth
  • Primary contact (assignee): @zshihang
  • Responsible SIGs: sig-auth
  • Enhancement target (which target equals to which milestone):
    • LegacyServiceAccountTokenNoAutoGeneration feature gate
      • Beta release target (x.y): 1.24
      • Stable release target (x.y): 1.26
    • LegacyServiceAccountTokenTracking feature gate
      • Alpha release target (x.y): 1.26
      • Beta release target (x.y): 1.27
      • Stable release target (x.y): 1.28
    • LegacyServiceAccountTokenCleanUp feature gate
      • Alpha release target (x.y): 1.27
      • Beta release target (x.y): 1.28
      • Stable release target (x.y): 1.29
  • [x] 1.24
    • [x] KEP (k/enhancements) update PR(s):
      • [x] https://github.com/kubernetes/enhancements/pull/2800
    • [x] Code (k/k) update PR(s):
      • [x] LegacyServiceAccountTokenNoAutoGeneration - https://github.com/kubernetes/kubernetes/pull/108309
    • [x] Docs (k/website) update PR(s):
      • [x] https://github.com/kubernetes/website/pull/31845
      • [x] https://github.com/kubernetes/website/pull/31894
      • [x] https://github.com/kubernetes/website/pull/32339
  • [x] 1.25
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/3393
  • [x] 1.26
    • [x] KEP (k/enhancements) update PR(s):
      • [x] https://github.com/kubernetes/enhancements/pull/3536
    • [x] Code (k/k) update PR(s):
      • [x] LegacyServiceAccountTokenNoAutoGeneration
        • https://github.com/kubernetes/kubernetes/pull/112838
      • [x] LegacyServiceAccountTokenTracking
        • https://github.com/kubernetes/kubernetes/pull/108858
    • [x] Docs (k/website) update(s):
      • [x] https://github.com/kubernetes/website/pull/37483
  • [ ] 1.27
    • [x] KEP (k/enhancements) update PR(s):
      • [x] https://github.com/kubernetes/enhancements/pull/3696
    • [ ] Code (k/k) update PR(s):
      • [x] LegacyServiceAccountTokenNoAutoGeneration
        • https://github.com/kubernetes/kubernetes/pull/114522
      • [x] LegacyServiceAccountTokenTracking
        • https://github.com/kubernetes/kubernetes/pull/114523
      • [ ] LegacyServiceAccountTokenCleanUp
        • TBD
    • [ ] Docs (k/website) update(s):
      • [ ] TBD

zshihang avatar Jun 25 '21 22:06 zshihang

/sig auth

zshihang avatar Jul 29 '21 16:07 zshihang

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 09 '21 21:12 k8s-triage-robot

/remove-lifecycle stale /lifecycle frozen

enj avatar Dec 13 '21 17:12 enj

Hi @zshihang , 1.24 Enhancements Lead here. Will this enhancement (both features) be in alpha for 1.24? Thanks

gracenng avatar Jan 20 '22 14:01 gracenng

LegacyServiceAccountTokenNoAutoGeneration would be beta in 1.24; LegacyServiceAccountTokenTracking and LegacyServiceAccountTokenCleanUp would be alpha in 1.24.

zshihang avatar Jan 20 '22 17:01 zshihang

Cross posted in PR Hi @zshihang ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. I'll mark this as beta while awaiting your confirmation Here’s where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo #2800
  • [x] KEP status is marked as implementable for this release with latest-milestone: 1.24
  • [x] KEP has a test plan section filled out.
  • [x] KEP has up to date graduation criteria.
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk. @zshihang, you replied "done" in the PR but it has not been merged. Did I miss something? Thanks!

gracenng avatar Jan 22 '22 02:01 gracenng

@gracenng the linked PR has now merged. can you confirm this is in good shape for enhancements freeze?

liggitt avatar Jan 27 '22 19:01 liggitt

Thanks for the ping @liggitt . Updated status to tracked, all good for enhancements freeze

gracenng avatar Jan 27 '22 20:01 gracenng

Hi @zshihang πŸ‘‹ 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

chrisnegus avatar Feb 11 '22 19:02 chrisnegus

Hi @zshihang 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

gracenng avatar Mar 16 '22 05:03 gracenng

updated description with code and docs PRs

liggitt avatar Mar 16 '22 18:03 liggitt

@liggitt Thanks for adding links to the docs PRs. Is that all the documentation required for this KEP in 1.24?

chrisnegus avatar Mar 19 '22 14:03 chrisnegus

the unchecked items represent work yet to be done

liggitt avatar Mar 19 '22 14:03 liggitt

Hey y'all! We're approaching last call for feature blogs, as the freeze is Wednesday, March 23. If you would like to have a feature blog for this, please add it to the tracking sheet and reach out to me if you have any questions. Thank you!

katcosgrove avatar Mar 21 '22 18:03 katcosgrove

Hey @liggitt , with Code Freeze coming in a few days. Will the portions marked TBD be added as part of this feature?

gracenng avatar Mar 26 '22 19:03 gracenng

Unclear, fixing other regressions in the project and other reviews have consumed a lot of the bandwidth the past couple weeks. If nothing else merges for 1.24, the already merged piece is good to go standalone and we'll shift the other bits to 1.25. Will update Monday.

liggitt avatar Mar 26 '22 19:03 liggitt

Hi @liggitt , is it safe to assume that the TBD pieces are not coming and this feature is good for Code Freeze?

gracenng avatar Mar 29 '22 07:03 gracenng

Yes

liggitt avatar Mar 29 '22 12:03 liggitt

updated description

liggitt avatar Mar 29 '22 13:03 liggitt

Hi @liggitt ! I see that the LegacyServiceAccountTokenNoAutoGeneration feature is still listed as needing documentation for 1.24. If that is still true, could you open a placeholder PR against the docs before tomorrow's deadline? Thanks so much!

chrisnegus avatar Mar 30 '22 14:03 chrisnegus

@zshihang Thanks for opening the docs placeholder PR!

chrisnegus avatar Mar 30 '22 22:03 chrisnegus

According to PR #32654, documentation has for this KEP has been done in PR #32339 and merged.

chrisnegus avatar Mar 31 '22 15:03 chrisnegus

I've raised a bug because I don't think the documentation is done.

sftim avatar Mar 31 '22 16:03 sftim

Hello @zshihang πŸ‘‹, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

Q: Would you kindly help me understand, what stage does the KEP target in the 1.25 release cycle? Is it staying in beta or targeting stable?

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable
  • [ ] KEP has a updated detailed test plan section filled out
  • [X] KEP has up to date graduation criteria
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

jasonbraganza avatar Jun 03 '22 07:06 jasonbraganza

Hello @zshihang πŸ‘‹, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the above pending items, done before enhancements freeze on Thursday, June 16, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

jasonbraganza avatar Jun 13 '22 12:06 jasonbraganza

Q: Would you kindly help me understand, what stage does the KEP target in the 1.25 release cycle? Is it staying in beta or targeting stable?

LegacyServiceAccountTokenNoAutoGeneration remains in beta in 1.25.

LegacyServiceAccountTokenTracking and LegacyServiceAccountTokenCleanUp feature gates are in alpha for 1.25.

liggitt avatar Jun 13 '22 18:06 liggitt

Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.

Included in https://github.com/kubernetes/enhancements/pull/3393

Included in https://github.com/kubernetes/enhancements/pull/3393

  • [ ] KEP has up to date graduation criteria

This is complete

  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

This is complete

liggitt avatar Jun 14 '22 01:06 liggitt

Thank you, for the updates @liggitt.

I’ll go ahead and track this enhancement, as targeting beta as mentionend in the kep.yaml file in the open PR https://github.com/kubernetes/enhancements/pull/3393

jasonbraganza avatar Jun 14 '22 11:06 jasonbraganza

https://github.com/kubernetes/enhancements/pull/3393 is now merged

liggitt avatar Jun 15 '22 15:06 liggitt

Thanks so much for the update, @liggitt! πŸ™‚

I'll update the status to tracked in the Enhancements tracking sheet.

Priyankasaggu11929 avatar Jun 15 '22 15:06 Priyankasaggu11929