Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe

[bowei]

Enhancement Description

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe

• Kubernetes Enhancement Proposal:
  • PR: https://github.com/kubernetes/enhancements/pull/2728
  • Original PR: https://github.com/kubernetes/enhancements/pull/1667
• Discussion Link: kubernetes/kubernetes#89797
• Primary contact (assignee): bowei@ (PxyUp@ was original author)
• Responsible SIGs:
  • SIG-NETWORK
  • SIG-NODE
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.22 (target)
  • Beta release target (x.y): 1.23 (TBD)
  • Stable release target (x.y): TBD
• [ ] Alpha
  • [ ] KEP (k/enhancements) update PR(s):
  • [ ] Code (k/k) update PR(s):
  • [ ] Docs (k/website) update PR(s):

[bowei]

/sig network

[bowei]

/assign

[bowei]

@PxyUp

[bowei]

/sig node

[SergeyKanzhelev]

for the quick reference of the reviewer, currently supported solutions:

• https://github.com/grpc-ecosystem/grpc-health-probe/
• https://kubernetes.io/blog/2018/10/01/health-checking-grpc-servers-on-kubernetes/

This solution is in high demand:

• https://github.com/search?q=grpc_health_probe+extension%3Ayaml

[ehashman]

@bowei can you start filing an exception request if you want this in 1.22? It seems very unlikely this feature will make the deadline of tomorrow given that it has not been opted in to the release, is missing PRR, etc.

[JamesLaverack]

/milestone v1.22 /stage alpha

[JamesLaverack]

Hi @bowei, 1.22 Enhancements Lead here. We're not removing this from 1.22, but can you address John's comment about updating your kep.yaml metadata to match your KEP README?

[yuzhiquan]

/cc

[bowei]

Got it, updating.

[bowei]

@ehashman do we need an exception request?

[SergeyKanzhelev]

@ehashman do we need an exception request?

It is in the tracking document: https://docs.google.com/spreadsheets/d/1mlui0brYypOAsgS2D13fvcs3At1uMq4i1gWfneq-jxY/edit#gid=1954476102 and was merged in time. Also @ehashman counted it in the Slack message =).

We generally not encouraging last minute KEPs so we have a proper planning and be respectful for reviewers time. I think this one is not controversial and it is great that it got merged in time.

[PxyUp]

@bowei thanks for leading that, sadly i haven't time to finish my proposal. I did MR for prober long time ago may be commits will be also useful:

https://github.com/kubernetes/kubernetes/pull/89832

If you need it, i will rebase and update MR

[yuzhiquan]

@bowei do you working on this now?

If not, i would like to take this from here, and base on @PxyUp work https://github.com/kubernetes/kubernetes/pull/89832.

[bowei]

I can review if you are willing to commit to getting this into 1.22

[yuzhiquan]

I can review if you are willing to commit to getting this into 1.22

Sure, we will keep in touch for this feature.

[PI-Victor]

Hello @bowei 👋, 1.22 Docs release lead here. This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 
Thank you!

p.s.: please don't forget to add GRPCContainerProbe to the feature gates table to reflect this change.

[bowei]

Docs draft: https://github.com/kubernetes/website/pull/28105

[jrsapi]

Greetings @bowei , Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you link which k/k PR/s are needed to implement this enhancement for the 1.22 milestone?

Thanks!

[jrsapi]

Greetings @bowei, A reminder that the code freeze is this Thursday, July 8th and all PR's must be code complete and merged. Can you link the k/k PR's for this KEP? The KEP status is marked "At Risk" for the 1.22 milestone.

Also, the Docs PR deadline is this Friday, July 9th. kubernetes/website/28105 is in place.

Thanks!

[jrsapi]

Greetings @bowei, Sending a reminder that we have just one more day to get all open PRs merged before the code freeze deadline tomorrow on Thursday, July 8th, at 18:00 Pacific Time.

Thanks!

[JamesLaverack]

Hi, v1.22 Enhancements Lead here. Unfortunately this enhancement has not met the requirements for code freeze as https://github.com/kubernetes/kubernetes/pull/102162 is unmerged and unapproved.

If you still wish to progress this enhancement in v1.22, then please file an exception request.

/milestone clear

[yuzhiquan]

Hi, v1.22 Enhancements Lead here. Unfortunately this enhancement has not met the requirements for code freeze as kubernetes/kubernetes#102162 is unmerged and unapproved.

If you still wish to progress this enhancement in v1.22, then please file an exception request.

/milestone clear

Ok, i will send an exception request.

[yuzhiquan]

Hi, v1.22 Enhancements Lead here. Unfortunately this enhancement has not met the requirements for code freeze as kubernetes/kubernetes#102162 is unmerged and unapproved.

If you still wish to progress this enhancement in v1.22, then please file an exception request.

/milestone clear

Exception request was send, and https://github.com/kubernetes/kubernetes/pull/102162 is close to be merge. @JamesLaverack /cc @bowei @SergeyKanzhelev @PxyUp

[yuzhiquan]

We are aim to v1.23 now.

[dchen1107]

Marking this for v1.23 and hope this request wouldn't miss the release again. The KEP was merged and the implementation is under reviewing.

[salaxander]

Hi @bowei! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09. Here's where this enhancement currently stands:

• [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [X] ~~KEP status is marked as implementable~~
• [X] ~~KEP has a test plan section filled out.~~
• [X] ~~KEP has up to date graduation criteria.~~
• [X] ~~KEP has a production readiness review that has been completed and merged into k/enhancements.~~

For this one, it looks like we just need the kep.yaml file updated to reference the correct latest milestone, then we're good to go.

Thanks!

[supriya-premkumar]

Hi @bowei, 1.23 Enhancements Shadow here 👋🏽 This issue is currently marked as atRisk. I am following up on this one as we are approaching the enhancements freeze deadline at 23:59:59 PDT on Thursday, September 9th.

For this issue to be included in the 1.23 milestone, please update your kep.yaml to reflect the latest milestone.

Enhancements missing this deadline will require an exception

Thank you!

[supriya-premkumar]

Thank you @SergeyKanzhelev! This enhancement is all set for the freeze deadline 🎉 Updating the tracking sheet as well.

[jlbutler]

Hi @bowei @SergeyKanzhelev :wave: 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!