enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Pod Priority Based Node Graceful Shutdown

Open mrunalp opened this issue 4 years ago • 37 comments

Enhancement Description

  • One-line enhancement description: Stop based based on their priority during node shutdown
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/2713
  • Discussion Link:
  • Primary contact (assignee): @mrunalp
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.22
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2713
    • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/102915
    • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/30611

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

mrunalp avatar May 11 '21 16:05 mrunalp

/sig node

mrunalp avatar May 11 '21 16:05 mrunalp

/milestone v1.22

ehashman avatar May 11 '21 17:05 ehashman

Greetings @mrunalp! 1.22 Enhancement shadow checking in. After reviewing the KEP and PRR this KEP will be marked tracked. A reminder that the enhancement freeze starts 5/13 23:59:59 PST.

Thanks!

jrsapi avatar May 13 '21 03:05 jrsapi

Hello @mrunalp 👋, 1.22 Docs release lead here. This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 
Thank you!

PI-Victor avatar May 26 '21 19:05 PI-Victor

Greetings @mrunalp, Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you confirm if the following k/k PR is all that is needed for the implementation of this enhancement for the 1.22 milestone?

Thanks!

jrsapi avatar Jun 24 '21 18:06 jrsapi

Greetings @mrunalp, A reminder that this Thursday, July 8th is code freeze, and all PR's must be code complete and merged. This KEP is marked "At Risk" for the 1.22 milestone.

Also this Friday, July 9th is the Docs placeholder deadline and to open a PR follow the instructions above.

Thanks!

jrsapi avatar Jul 06 '21 06:07 jrsapi

Greetings @mrunalp, Sending a reminder that we have just one more day to get all open PRs merged before the code freeze deadline tomorrow Thursday, July 8th at 18:00 Pacific Time.

jrsapi avatar Jul 08 '21 03:07 jrsapi

https://github.com/kubernetes/kubernetes/pull/102915 is open for the implementation.

mrunalp avatar Jul 08 '21 23:07 mrunalp

Hi, v1.22 Enhancements Lead here. Unfortunately this enhancement has not met the requirements for code freeze as https://github.com/kubernetes/kubernetes/pull/102915 is unmerged and unapproved.

If you still wish to progress this enhancement in v1.22, then please file an exception request.

/milestone clear

JamesLaverack avatar Jul 09 '21 02:07 JamesLaverack

We requested an exception for this.

mrunalp avatar Jul 09 '21 15:07 mrunalp

/milestone v1.23

salaxander avatar Aug 31 '21 18:08 salaxander

Hi @mrunalp! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable
  • [X] KEP has a test plan section filled out.
  • [X] KEP has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need the following to update:

Thank you!

Priyankasaggu11929 avatar Sep 07 '21 11:09 Priyankasaggu11929

@Priyankasaggu11929 I have opened a PR to update the milestone for the KEP.

mrunalp avatar Sep 07 '21 21:09 mrunalp

@mrunalp, thank you so much for the PR.

Could you please update this issue description as well with the latest Enhancement target. Would be really helpful to track the enhancement for the team. Thanks once again! :)

Priyankasaggu11929 avatar Sep 08 '21 05:09 Priyankasaggu11929

Thanks so much for the changes, @mrunalp. With the KEP PR merged now, this enhancement is ready for the 1.23 enhancements freeze. :)

Priyankasaggu11929 avatar Sep 09 '21 13:09 Priyankasaggu11929

Hi @mrunalp :wave: 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

jlbutler avatar Sep 17 '21 18:09 jlbutler

PR for alpha: https://github.com/kubernetes/kubernetes/pull/102915

ehashman avatar Oct 12 '21 21:10 ehashman

Hello @mrunalp 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thank you so much! 🙂

Priyankasaggu11929 avatar Nov 08 '21 14:11 Priyankasaggu11929

The Release Team received an exception request for the 1.23 Code Freeze for 3 additional days. We APPROVE the exception request for the 1.23 Code Freeze for 3 additional days. Reference: approval email

reylejano avatar Nov 17 '21 02:11 reylejano

Docs placeholder PR - https://github.com/kubernetes/website/pull/30558

mrunalp avatar Nov 18 '21 21:11 mrunalp

Docs merged here - https://github.com/kubernetes/website/pull/30611

mrunalp avatar Dec 01 '21 22:12 mrunalp

/stage beta

gracenng avatar Jan 17 '22 04:01 gracenng

Hi @mrunalp! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. I believe this enhancement is targeting beta for 1.24 - is that correct?

Here’s where this enhancement currently stands:

  • [x] Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • [x] KEP status is marked as implementable for latest-milestone: 1.24
  • [x] KEP has a test plan section filled out.
  • [x] KEP has up to date graduation criteria.
  • [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is at risk. Thanks!

rhockenbury avatar Jan 20 '22 19:01 rhockenbury

Let me know if there are any updates on whether this is planned for beta for v1.24.

rhockenbury avatar Jan 27 '22 02:01 rhockenbury

Hi yes we want to move this to beta. I will open a PR to update tomorrow.

On Jan 26, 2022, at 6:20 PM, Ryler Hockenbury @.***> wrote:

 Let me know if there are any updates on whether this is planned for beta for v1.24.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

mrunalp avatar Jan 27 '22 05:01 mrunalp

I opened a PR: https://github.com/kubernetes/enhancements/pull/3194

mrunalp avatar Jan 27 '22 18:01 mrunalp

Thanks, please plan to merge #3194 before enhancements freeze at 18:00pm PT on Thursday Feb 3rd.

rhockenbury avatar Jan 31 '22 03:01 rhockenbury

I've moved this KEP to tracked for enhancement freeze. Thanks!

rhockenbury avatar Feb 03 '22 03:02 rhockenbury

Hi @mrunalp 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

PI-Victor avatar Feb 19 '22 13:02 PI-Victor

Hi @mrunalp :wave: 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

valaparthvi avatar Mar 21 '22 05:03 valaparthvi