Always Honor PersistentVolume Reclaim Policy

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note): PersistentVolume reclaim policy should always be honored
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy
• Discussion Link: https://github.com/kubernetes-csi/external-provisioner/issues/546
• Primary contact (assignee): @deepakkinni @xing-yang
• Responsible SIGs: SIG-Storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.31
  • Stable release target (x.y): 1.32
• [X] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2680
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/105773
  • [ ] Docs (k/website) update(s): PR submitted
• [x] Beta
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4397
  • [x] e2e tests: https://github.com/kubernetes/kubernetes/pull/123151
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/124842
  • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/46794
  • [x] Blog: https://github.com/kubernetes/website/pull/46890

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[xing-yang]

/sig storage

[JamesLaverack]

/milestone v1.22

[gracenng]

Hi @xing-yang, 1.22 Enhancements Shadow here.

The KEP looks all good, however, the status of the KEP on Enhancement track sheet will be at risk until the KEP is merged into master.

Thanks!

[gracenng]

Hi @xing-yang 👋 1.22 Enhancements shadow here. To help SIG's be aware of their workload, I just wanted to check to see if SIG-Storage will need to do anything for this enhancement and if so, are they OK with it? Thanks!

[JamesLaverack]

Hi @deepakkinni, 1.22 Enhancements Lead here. :wave: With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

[xing-yang]

KEP is here but not merged yet: https://github.com/kubernetes/enhancements/pull/2680

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[xing-yang]

/milestone v1.23

[lauralorenz]

Hi @xing-yang, @deepakkinni! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly, you are targeting alpha stage in release 1.23.

Here's where this enhancement currently stands:

• [ ] KEP file using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable (filled out in PR, not merged)
• [ ] KEP has a test plan section filled out. (filled out in PR, not merged)
• [ ] KEP has up to date graduation criteria. (filled out in PR, not merged)
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (filled out in PR, not merged)

Starting with 1.23, we have implemented a soft freeze on production readiness reviews beginning tomorrow, Thursday 09/02. It looks like you already have the questionnaire filled out in your PR and have a PRR reviewer associated, so you are on track for tomorrow's soft freeze!

Thanks!

[ramrodo]

Hi @xing-yang, @deepakkinni :wave: 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[xing-yang]

Hi @ramrodo, We looked at this again and decided that this does not need a doc change. Can you please help remove "Need Docs" from the feature tracking sheet? Thanks!

[xing-yang]

Also the required in-tree PR for this KEP is merged: https://github.com/kubernetes/kubernetes/pull/105773 We are on-track for 1.23.

[lauralorenz]

Hi @xing-yang, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

• ~all PRs to the Kubernetes repo related to your enhancement are fully merged by the code freeze deadline~ (It looks like you've already got https://github.com/kubernetes/kubernetes/pull/105773 merged. :tada:)
• ~have a documentation placeholder PR open by Thursday, November 18.~ (Based on the comment above https://github.com/kubernetes/enhancements/issues/2644#issuecomment-969254951 it looks like you are expecting not to open one but will let @ramrodo speak to that from their side.)

Thanks!!

[ramrodo]

Confirmed this doesn't need docs and I updated the tracking sheet. Thanks for the heads up.

[xing-yang]

/milestone v1.24

[hosseinsalahi]

Hello @deepakkinni

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for v1.24, is this correct?

Here’s where this enhancement currently stands:

• [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for this release
• [X] KEP has a test plan section filled out.
• [X] KEP has up to date graduation criteria.
• [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

~~In the kep.yaml please update the latest-milestone according to the release version.~~

The status of this enhancement is marked as tracked. Please update the issue description up-to-date with a link to the KEP and appropriate stages. Thanks!

[xing-yang]

@encodeflush The KEP is merged and on track to target Beta in 1.24. The issue description is updated. Can you add Tracked/Yes label?

[mehabhalodiya]

@xing-yang please update the issue description. The PR from kubernetes/kubernetes got merged. Also, there is docs PR opened up.

[hosseinsalahi]

Hello @deepakkinni @xing-yang

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

• [X] All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
• [X] Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.
• https://github.com/kubernetes/website/pull/32570

For note, the status of this enhancement is currently marked as tracked.

~Both above-mentioned criterion are awaiting for this PR:~ ~- https://github.com/kubernetes/website/pull/32338~

~Kindly please let me know if I'm missing any related PRs other than the ones I linked above.~ Thank you so much!

[xing-yang]

@encodeflush, all implementation PRs are merged.

[xing-yang]

@encodeflush, we decided to keep this feature in Alpha because e2e test didn't get merged by the test freeze deadline. All code enhancement PRs are merged and will stay merged. We just reverted the feature gate to Alpha again. https://github.com/kubernetes/kubernetes/pull/109362/

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[xing-yang]

/remove-lifecycle stale

[rhockenbury]

/milestone v1.26

[ruheenaansari34]

Hello @xing-yang @deepakkinni 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

• [ ] KEP readme using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable for latest-milestone: 1.26
• [ ] KEP readme has a updated detailed test plan section filled out
• [x] KEP readme has up to date graduation criteria
• [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update KEP's README.md to include test plan details as per the latest template
• Update latest-milestone and milestone details on kep.yml
• Create a PR to meet the above requirements for Enhancements freeze and get it merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[ruheenaansari34]

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and README and get the PR merged.

[deepakkinni]

Hello @xing-yang @deepakkinni 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

We have decided to not move the KEP to beta in 1.26. Instead, we are going for KEP update(for additional changes) and target the beta next release.

[rhockenbury]

Thanks for the update.

/milestone clear /label tracked/no /remove-label tracked/yes /remove-label lead-opted-in