Portworx file in-tree to CSI driver migration

[trierra]

Enhancement Description

• One-line enhancement description (can be used as a release note):
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
• Primary contact (assignee): @trierra
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.25 (off-by-default)
  • Beta release target (x.y): 1.31 (on-by-default)
  • Stable release target (x.y): 1.32

Parent enhancement: #625

• [x] Alpha
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2964
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/103447
  • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/30445
• [x] Beta(off-by-default)
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3345
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/110411
  • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/34886
• [x] Beta(on-by-default)
  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4467
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/125016
  • [x] Docs (k/website) update(s): https://github.com/kubernetes/website/pull/46506

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[trierra]

/sig storage

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

[trierra]

/remove-lifecycle stale

[SergeyKanzhelev]

was this enhancement approved for 1.22?

[trierra]

it was planned to get to 1.22

On Wed, Jul 7, 2021 at 10:18 PM Sergey Kanzhelev @.***> wrote:

was this enhancement approved for 1.22?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/2589#issuecomment-876135150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX3S75OZLTLP4UMEZNMWXDTWUYMFANCNFSM42DXZYOA .

--

Best regards,

Oksana Naumov // MTS @ CNBU

[SergeyKanzhelev]

I cannot find the KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage and this issue is not in the milestone. I'm confused.

[trierra]

Sorry for confusion, I was told KEP is not needed, I only have an open issue for that https://github.com/kubernetes/enhancements/issues/2589

On Thu, Jul 8, 2021 at 10:36 AM Sergey Kanzhelev @.***> wrote:

I cannot find the KEP here: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage and this issue is not in the milestone https://github.com/kubernetes/enhancements/issues?q=is%3Aissue+is%3Aopen+label%3Asig%2Fstorage+milestone%3Av1.22. I'm confused.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/enhancements/issues/2589#issuecomment-876621080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX3S73XEZXZGNCIJVCU3MLTWXO3JANCNFSM42DXZYOA .

--

Best regards,

Oksana Naumov // MTS @ CNBU

[trierra]

oh, I see what you mean. Apparently, it's not approved.

[SergeyKanzhelev]

I was told KEP is not needed,

It may not be. Change seems to be quite straightforward and likely already covered with some other KEP. Either way the code freeze for 1.22 is in 40 minutes. There is still some work left on the PR

[salaxander]

/milestone v1.23

[lauralorenz]

Hi @trierra! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze at 11:59pm PST on Thursday 09/09.

It looks like the proposal was written using the design proposal format, but as of release 1.14, they now must use the KEP format which among other things includes a metadata file that is used by some release automation. In particular as of 1.19 a particular approval process called PRR review is also required which must be requested for each KEP separately.

This is all to say that though I've included the formal checklist used by enhancements team below, I think in reality you will need to migrate this into the KEP format and request a PRR reviewer for us to accept it into a milestone.

I also notice from the OP and prior comments that there is a parent enhancement which is in KEP format. You may wish to close this enhancements issue in favor of that one, *IF* that KEP is the way that your SIG is targeting milestones and communicating with enhancements team for this feature. (I didn't read the proposals in detail so apologies if that is wildly incorrect.)

Thanks!!

--

Here's where this enhancement currently stands:

• [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [ ] KEP status is marked as implementable
• [x] KEP has a test plan section filled out.
• [ ] KEP has up to date graduation criteria.
• [ ] KEP has a production readiness review that has been completed and merged into k/enhancements.

[msau42]

@lauralorenz This is the KEP that we're using to track all csi migration implementations: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration

The design and test plan is the same for each cloud provider, the only difference is that each cloud provider has its own feature gate and implementation and own release timeline.

[Jiawei0227]

A dedicated KEP for this is out for review: https://github.com/kubernetes/enhancements/pull/2964

[lauralorenz]

Thanks everyone! Between comments here, comments on the new KEP PR, and the discussion in Slack in #sig-release, just confirming from my side that the new PR #2964 meets the criteria for enhancements freeze (using latest KEP template, set as implementable, inherits its parent's filled out test plan section, inherits its parent's up to date graduation criteria, and has a PRR review file artifact matching this enhancement issue number) so as long as it is merged by the deadline tonight at 11:59pm PST we are good to go!

[salaxander]

Hi, 1.23 Enhancements Lead here 👋. With enhancements freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

• KEP is merged into k/enhancements repo with up to date latest milestone and stage.
• KEP status is marked as implementable.
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review for the correct stage that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks! /milestone clear

[xing-yang]

Thanks @salaxander! We'll be filing an exception soon. CC @Jiawei0227 @msau42

[ramrodo]

Hi @trierra :wave: 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[trierra]

Hi @ramrodo , I've opened the PR by mistake https://github.com/kubernetes/website/pull/30445

Can you please convert it into a draft PR?

[reylejano]

/milestone v1.23 An exception request was filed on 9/15/21 for the 1.23 Enhancements Freeze. The exception request was approved on 9/15/21

[lauralorenz]

Hi @trierra, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

• all PRs to the Kubernetes repo related to your enhancement are fully merged by the code freeze deadline (I believe the only one is https://github.com/kubernetes/kubernetes/pull/103447)
• ~have a documentation placeholder PR open by Thursday, November 18.~ (It looks like you already have this!)

Thanks!!

[gracenng]

Hi @trierra 1.24 Enhancements lead here. Just double checking that you are targeting beta for this release. If so, please let me know and update the description to help the Enhancements team. Thanks 🌷

[trierra]

hi @gracenng . I think we don't have enough time to complete all required testing by the end of January. So most likely Beta is targeting for 1.25

[msau42]

Hi @trierra, to clarify, you have until code freeze to finish the required testing. The end of Janauary date is to declare intent.

[trierra]

hi @msau42 , thank you for pointing that out, it looks like the code freeze is sometimes in March, in this case I believe we have enough time. So yes, let's target beta for the 1.24

[Jiawei0227]

I think it is appropriate to target beta but off by default. What do you think? It requires more testing but are less risky to directly be turned on by default.

[trierra]

@Jiawei0227 sounds good to me

[hosseinsalahi]

Hello @trierra

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for v1.24, is this correct?

Here’s where this enhancement currently stands:

• [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for this release
• [X] KEP has a test plan section filled out.
• [X] KEP has up to date graduation criteria.
• [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please update the issue description up-to-date with appropriate stages as well. Thanks!

[msau42]

@trierra can you help send out the update to the KEP?

[trierra]

@msau42 @encodeflush sure, will update it by early next week

[trierra]

KEP update PR https://github.com/kubernetes/enhancements/pull/3187