enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Extend podresources API to report allocatable resources

Open ffromani opened this issue 4 years ago • 25 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Extend the podresources API to report the allocatable compute resources
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/2404
  • Discussion Link: SIG Node Meeting 20200811: Recording, Slides Slack thread for introducing GetAllocatableResources() endpoint (previously called GetAvailableResources) in podresource API
  • Primary contact (assignee): Francesco Romani (@fromanirh)
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y):
    • Beta release target (x.y):
    • Stable release target (1.21):

Previous/Related work:

  • initial issue - initially targeting 1.20, we are creating a separate issue + KEP to clearly describe this unit of work.

PRs:

  • kubernetes/kubernetes#95734

ffromani avatar Feb 02 '21 16:02 ffromani

/sig node

ffromani avatar Feb 02 '21 16:02 ffromani

rationale for this split in this slack conversation

the main goal is to make this change easier to review

ffromani avatar Feb 02 '21 17:02 ffromani

/milestone v1.21

derekwaynecarr avatar Feb 02 '21 18:02 derekwaynecarr

Hey @fromanirh, enhancements 1.21 shadow here,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

The enhancements team is aware that KEP update is currently in progress (PR #2404). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

JamesLaverack avatar Feb 07 '21 19:02 JamesLaverack

Hi @fromanirh,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

JamesLaverack avatar Feb 19 '21 23:02 JamesLaverack

Hi @fromanirh,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

* Tuesday, March 9th: Week 9 — Code Freeze

* Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
  
  * If this enhancement requires new docs or modification to existing docs, please follow the steps in the [Open a placeholder PR doc](https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr) to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

Thanks for the reminder! I don't think this enhancement requires a k/website PR, but I'll doublecheck and file a placeholder PR if needed. Implementation PR: https://github.com/kubernetes/kubernetes/pull/95734

ffromani avatar Feb 20 '21 08:02 ffromani

Hi @fromanirh,

A friendly reminder that Code freeze is 3 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

JamesLaverack avatar Mar 06 '21 18:03 JamesLaverack

Hi @fromanirh, with https://github.com/kubernetes/kubernetes/pull/95734 merged in, we will mark this as code complete.

annajung avatar Mar 09 '21 22:03 annajung

yes, thanks!

ffromani avatar Mar 09 '21 22:03 ffromani

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

k8s-triage-robot avatar Jul 26 '21 22:07 k8s-triage-robot

/remove-lifecycle stale

pacoxu avatar Aug 24 '21 17:08 pacoxu

/milestone v1.23

per 08/24 Node meeting

ehashman avatar Sep 02 '21 17:09 ehashman

/stage beta

ehashman avatar Sep 02 '21 17:09 ehashman

Hi @fromanirh! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • [ ] Updated KEP file using the latest template has been merged into the k/enhancements repo. (PR open)
  • [X] ~~KEP status is marked as implementable~~
  • [X] ~~KEP has a test plan section filled out.~~
  • [X] ~~KEP has up to date graduation criteria.~~
  • [ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (PR open)

As long as that PR merge by enhancements freeze, we should be all good!

Thanks!

salaxander avatar Sep 02 '21 21:09 salaxander

Graduating PodResource API GetAllocatableResource to Beta in 1.23 release:

  • [ ] Beta

    • [x] KEP (k/enhancements) update PR(s): KEP-2403: Update PodResource API GetAllocatableResource 1.23 Beta #2932
    • [x] Code (k/k) update PR(s):
    • [x] https://github.com/kubernetes/kubernetes/pull/103289
    • [x] https://github.com/kubernetes/kubernetes/pull/104123
    • [x] https://github.com/kubernetes/kubernetes/pull/97415
    • [x] k/k PR to graduate the feature to Beta (enable by default): https://github.com/kubernetes/kubernetes/pull/105003
    • [x] Docs (k/website) update PR(s) to dev-1.23 branch: https://github.com/kubernetes/website/pull/29751

swatisehgal avatar Sep 06 '21 18:09 swatisehgal

Hi @swatisehgal @fromanirh :wave: 1.23 Docs lead here

This enhancement issue is listed as "Needs Docs" for the 1.23 release. I see a docs PR is open (k/website 28074), can you point it at the dev-1.23 branch in k/website please?

For more info, please refer to the steps in the documentation. Ping if you have any questions.

Thanks!

jlbutler avatar Sep 17 '21 17:09 jlbutler

Hi @swatisehgal @fromanirh 1.23 Docs lead here

This enhancement issue is listed as "Needs Docs" for the 1.23 release. I see a docs PR is open (k/website 28074), can you point it at the dev-1.23 branch in k/website please?

For more info, please refer to the steps in the documentation. Ping if you have any questions.

Thanks!

Thanks @jlbutler, I have created a docs PR that points to dev-1.23 branch in k/website here: https://github.com/kubernetes/website/pull/29751. Let me know if there is anything else you need from my end.

swatisehgal avatar Sep 20 '21 09:09 swatisehgal

Hi @swatisehgal @fromanirh 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

salaxander avatar Nov 08 '21 18:11 salaxander

hi @salaxander ! @swatisehgal has already tracked the items you mentioned in https://github.com/kubernetes/enhancements/issues/2403#issuecomment-913806988 . Please let us know if something's missing!

ffromani avatar Nov 09 '21 06:11 ffromani

Graduating PodResource API GetAllocatableResource to Beta in 1.23 release:

All PRs merged!

EDIT: fix formatting

ffromani avatar Nov 17 '21 15:11 ffromani

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 09 '22 18:04 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar May 09 '22 19:05 k8s-triage-robot

/remove-lifecycle rotten

swatisehgal avatar May 09 '22 21:05 swatisehgal

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 07 '22 21:08 k8s-triage-robot

/remove-lifecycle stale

ffromani avatar Aug 08 '22 09:08 ffromani

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 06 '22 09:11 k8s-triage-robot

/remove-lifecycle stale

ffromani avatar Nov 07 '22 06:11 ffromani

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 05 '23 07:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 07 '23 07:03 k8s-triage-robot

/remove-lifecycle rotten

ffromani avatar Mar 07 '23 07:03 ffromani