enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

cAdvisor-less, CRI-full Container and Pod Stats

Open haircommander opened this issue 3 years ago • 110 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): cAdvisor-less, CRI-full Container and Pod Stats
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2371-cri-pod-container-stats/README.md
  • Primary contact (assignee): @haircommander, @bobbypage
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.26
    • Beta release target (x.y): 1.28
    • Alpha release target (x.y): 1.29 See https://github.com/kubernetes/enhancements/pull/4249
    • Stable release target (x.y):
  • [x] Alpha
    • [x] KEP (k/enhancements) update PR(s):
      • https://github.com/kubernetes/enhancements/pull/2812
      • https://github.com/kubernetes/enhancements/pull/3559
      • https://github.com/kubernetes/enhancements/pull/3439
      • https://github.com/kubernetes/kubernetes/pull/110754
      • https://github.com/kubernetes/kubernetes/pull/113609
    • [x] Code (k/k) update PR(s):
      • 1.23 https://github.com/kubernetes/kubernetes/pull/103095
      • 1.26 https://github.com/kubernetes/kubernetes/pull/110754
    • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/30535
  • [x] Beta 1.28
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/3770
    • [x] Code (k/k) update PR(s):
      • https://github.com/kubernetes/kubernetes/pull/118838
      • 1.28 https://github.com/kubernetes/kubernetes/pull/116968
    • [ ] Docs (k/website) update PR(s):
  • [ ] Alpha 1.29
    • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4249
    • [ ] Code (k/k) update PR(s):
      • 1.30 https://github.com/kubernetes/kubernetes/pull/122846
    • [ ] Docs (k/website) update PR(s):

haircommander avatar Jan 29 '21 15:01 haircommander

/sig node

haircommander avatar Jan 29 '21 15:01 haircommander

/milestone v1.21

ehashman avatar Feb 02 '21 19:02 ehashman

Hey @haircommander and @bobbypage, enhancements 1.21 shadow here,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

The enhancements team is aware that KEP update is currently in progress (PR #2364). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

JamesLaverack avatar Feb 07 '21 19:02 JamesLaverack

Hi @haircommander and @bobbypage, 1.21 Enhancements Lead here.

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

annajung avatar Feb 10 '21 03:02 annajung

/milestone v1.22

ehashman avatar May 04 '21 18:05 ehashman

Hey @haircommander and @bobbypage - 1.22 enhancements team here! Just a reminder that enhancements freeze is coming up on 5/13. We'll need the KEP merged before then to get this included in the 1.22 release.

Let us know if there's anything we can do to help before then!

salaxander avatar May 07 '21 22:05 salaxander

@haircommander @bobbypage #2364 merged so we've got you tracked for 1.22 :)

salaxander avatar May 13 '21 14:05 salaxander

Hello @haircommander @bobbypage 👋, 1.22 Docs release lead here. This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 
Thank you!

PI-Victor avatar May 18 '21 11:05 PI-Victor

thanks for the heads up @PI-Victor !

haircommander avatar May 19 '21 19:05 haircommander

xref https://github.com/kubernetes/kubernetes/pull/102789

ehashman avatar Jun 18 '21 18:06 ehashman

xref initial kubelet implementation kubernetes/kubernetes#103095

haircommander avatar Jun 22 '21 15:06 haircommander

Hey @bobbypage and @haircommander - Just checking in as we're about 2 weeks away from 1.22 code freeze. I've got https://github.com/kubernetes/kubernetes/pull/103095 and https://github.com/kubernetes/kubernetes/pull/103095 tracked as the open k/k PRs. Are there any other open or merged PRs we should be tracking? Thanks!

salaxander avatar Jun 23 '21 02:06 salaxander

none opened yet! I will post them here if we do. Thanks for your work @salaxander

haircommander avatar Jun 23 '21 13:06 haircommander

Hey @haircommander - One more check-in as we're a week out from 1.22 code freeze. Any updates on if you expect https://github.com/kubernetes/kubernetes/pull/103095 and https://github.com/kubernetes/kubernetes/pull/103095 to merge before the deadline?

Thanks!

salaxander avatar Jul 02 '21 01:07 salaxander

Thanks for checking! I do expect them to merge. We're waiting on a e2e POC which I'm working on :)

haircommander avatar Jul 02 '21 13:07 haircommander

Hi @haircommander - One last ping (sorry!). Code freeze is tomorrow evening (PST), so those two open PRs will need to merge before then for this to be included in 1.22. Let me know if there's anything we can do to help :)

salaxander avatar Jul 08 '21 03:07 salaxander

thanks for the reminder @salaxander ! I can imagine I'll be requesting an extension, but there's a day to figure that out :)

haircommander avatar Jul 08 '21 13:07 haircommander

/milestone v1.23

Priyankasaggu11929 avatar Sep 01 '21 12:09 Priyankasaggu11929

@Priyankasaggu11929: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 01 '21 12:09 k8s-ci-robot

/milestone v1.23

salaxander avatar Sep 01 '21 17:09 salaxander

/remove-stage beta /stage alpha

this slipped in 1.22 and is not yet alpha

ehashman avatar Sep 01 '21 18:09 ehashman

@Priyankasaggu11929 please update the corresponding spreadsheet phase

ehashman avatar Sep 01 '21 18:09 ehashman

Updated the enhancements sheet to change the KEP's stage to alpha. Thanks for pointing, @ehashman.

Priyankasaggu11929 avatar Sep 01 '21 18:09 Priyankasaggu11929

Hi @haircommander ! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • [ ] KEP file using the latest template has been merged into the k/enhancements repo.
  • [X] KEP status is marked as implementable
  • [X] KEP has a test plan section filled out.
  • [X] KEP has up to date graduation criteria.
  • [X] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

Thanks!

Priyankasaggu11929 avatar Sep 07 '21 10:09 Priyankasaggu11929

Looks like for this one, we would just need to update the following:

* update issue description with the latest `Enhancements target`

done!

* update [keps/sig-node/2371-cri-pod-container-stats/kep.yaml](https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2371-cri-pod-container-stats/kep.yaml) file to add the current milestone & fill all the TODO/TBC/TBD placeholders.

updated the PR in https://github.com/kubernetes/enhancements/pull/2812

Thanks!

thank you for the reminder and for your work :)

haircommander avatar Sep 08 '21 14:09 haircommander

Thanks for the changes @haircommander. Once the PR is merged, we're all good for the enhancements freeze. :)

Priyankasaggu11929 avatar Sep 08 '21 14:09 Priyankasaggu11929

Hi @haircommander :wave: 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

jlbutler avatar Sep 17 '21 15:09 jlbutler

Hello @haircommander 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.
  • Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks you so much! 🙂

Priyankasaggu11929 avatar Nov 08 '21 14:11 Priyankasaggu11929

Thank you @Priyankasaggu11929 ! I have tagged the one kubernetes PR in the description, it has merged, and I have https://github.com/kubernetes/website/pull/28044 opened and ready to be populated. Please let me know if I'm missing anything, but I believe we are all set here

haircommander avatar Nov 08 '21 19:11 haircommander

Thank you, @haircommander. I wanted to be sure in case if I'm missing any PRs (other than the one already listed above). With the above comment, all looks fine to me.

Thanks so much once again! 🙂

Priyankasaggu11929 avatar Nov 11 '21 09:11 Priyankasaggu11929