Allow Kubernetes to supply pod's fsgroup to CSI driver on mount

[gnufied]

Enhancement Description

• Allow kubernetes to supply pod's fsgroup to CSI driver when a volume is mounted

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/pull/2323

• Discussion Link:

• Primary contact (assignee): @gnufied @verult

• Responsible SIGs: sig-storage

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.21
  • Beta release target (x.y): 1.23
  • Stable release target (x.y):

• [x] Alpha

  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2323
  • [x] Code (k/k) update PR(s): https://github.com/kubernetes/kubernetes/pull/103244
  • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/28869

• [ ] Beta

  • [x] KEP (k/enhancements) update PR(s):
    • https://github.com/kubernetes/enhancements/pull/2941
    • https://github.com/kubernetes/enhancements/pull/2949
    • https://github.com/kubernetes/enhancements/pull/3044
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes/kubernetes/pull/106330
  • [x] Docs (k/website) update(s):
    • https://github.com/kubernetes/website/pull/29753

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[gnufied]

/sig storage

[gnufied]

/assign

[jrsapi]

@gnufied This is Joseph v1.21 enhancement shadow. A reminder for this enhancement to be included in the 1.21 milestone, it must meet the following criteria:

The KEP must be merged in an implementable state The KEP must have test plans The KEP must have graduation criteria The KEP must have a production readiness review

Starting 1.21, all KEPs must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this.

[jrsapi]

Greetings @gnufied @msau42,

Checking in and reminding that Enhancements Freeze is 2 days away, Feb 9th EOD PST.

Enhancements team is aware that the KEP update is currently in progress (PR #2323 ) and we're tracking it. Any enhancements that do not complete the following requirements by the freeze will require an exception.

[DONE] The KEP must be merged in an implementable state [DONE] The KEP must have test plans [DONE] The KEP must have graduation criteria [DONE] The KEP must have a production readiness review

[msau42]

@jrsapi the kep has merged 6 days ago and has met all the crtieria. Can you confirm there is nothing else we need to do?

[annajung]

With https://github.com/kubernetes/enhancements/pull/2323 merged, this enhancement has met all criteria for the enhancements freeze 👍

[jrsapi]

Greetings @gnufied, Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates: • Tuesday, March 9th: Week 9 - Code Freeze • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo. As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them. Thanks!

[jrsapi]

Greetings @gnufied, The enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so the release team can track it.

[annajung]

Hi @gnufied, with code freeze now in effect, we are removing this enhancement from 1.21 release due to no code PR being tracked for this enhancement.

If needed, feel free to file an exception to add this back into the release. thanks!

[JamesLaverack]

/milestone 1.22

[k8s-ci-robot]

@JamesLaverack: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.25]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JamesLaverack]

Whoops. /milestone v1.22

[reylejano]

Hi @gnufied,

1.22 release team here. After reviewing the kep and the approved PRR, this enhancements is in good shape for the 1.22 Enhancements Freeze at 23:59:59 pst on Thursday, May 13. A few updates to the KEP are required before Enhancements Freeze:

• In the KEP README.md, update the missing sections for Implementation History , Drawbacks , and Alternatives. Here's an example KEP

[reylejano]

Hi @gnufied , please see my comment above on changes required to make the 1.22 Enhancements Freeze which starts on Thursday, May 13 at 23:59:59 pst

[gnufied]

@reylejano I opened https://github.com/kubernetes/enhancements/pull/2723 to fill those sections.

[reylejano]

Hi @gnufied , with the merge of PR 2723, this enhancement is all set for the 1.22 Enhancements Freeze 🎉 Thank you!

[ritpanjw]

Hello @gnufied 👋 , 1.22 Docs Shadow here.

This enhancement is marked as Needs Docs for 1.22 release. Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

[reylejano]

Hi @gnufied ,

With about 2 weeks until code freeze (July 8, 2021). Aside from the linked issues listed below, are there any open or merged k/k PRs we should be tracking for this?

Linked issues:

• https://github.com/kubernetes/kubernetes/issues/102923
• https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/708

[verult]

@reylejano I'm working on a PR for kubernetes#102923 and will hopefully be out in the next few days.

[reylejano]

Hi @gnufield and @verult ,

The 1.22 code freeze starts in a few days on Thursday, July 8 at 18:00 PDT. The following PR and any other PR required for this enhancement for 1.22 (e.g. for issue https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/708) has to merge by then:

• https://github.com/kubernetes/kubernetes/pull/103244
• k/k PRs related to issue https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/708 (please link the related k/k PRs)

This enhancement is currently at-risk of falling out of 1.22 with kubernetes/kubernetes#103244 open and k/k PRs related to issue https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/708

[verult]

https://github.com/kubernetes/kubernetes/pull/103244 is good to go minus flaky tests.

@gnufied there aren't any k/k PRs required for kubernetes-sigs/azurefile-csi-driver#708 right?

[gnufied]

@verult thats right https://github.com/kubernetes-sigs/azurefile-csi-driver/issues/708 is as such not affected by k8s feature freeze and drivers are expected to implement this feature post code freeze.

[reylejano]

Hi @gnufield and @verult ,

This enhancement is set for the 1.22 code freeze 🎉

[PI-Victor]

Hello @gnufied 👋 , 1.22 Docs Shadow here.

This enhancement is marked as Needs Docs for 1.22 release. Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@gnufied Friendly reminder about the upcoming docs placeholder PR deadline on Fri July 9, 11:59 PM PDT

[verult]

Doc PR placeholder: https://github.com/kubernetes/website/pull/28869

[xing-yang]

/milestone v1.23

[ramrodo]

Hi @gnufied @verult :wave: 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[verult]

/assign

[gracenng]

Hi @gnufied @verult , 1.23 Enhancements Shadow here.

In light of code freeze approaching on November 16th, please make sure to link your k/k code PR's in the description so the release team can keep track. As of now, the status of this enhancement is at-risk Thanks :)

[gracenng]

Hi all, looks like this enhancement is code complete 🎉 Updated status to tracked.