enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Job tracking without lingering Pods

Open alculquicondor opened this issue 4 years ago • 25 comments

Enhancement Description

  • One-line enhancement description (can be used as a release note): Job controller keeps track of Pod completions in status without relaying on lingering Pods.

  • Kubernetes Enhancement Proposal: https://git.k8s.io/enhancements/keps/sig-apps/2307-job-tracking-without-lingering-pods

  • Discussion Link: kubernetes/kubernetes#28486

  • Primary contact (assignee): alculquicondor

  • Responsible SIGs: apps

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.22
    • Beta release target (x.y): 1.23
    • Stable release target (x.y): 1.25
  • [x] Alpha

    • [x] KEP (k/enhancements) update PR(s): #2308 #2585
    • [x] Code (k/k) update PR(s): kubernetes/kubernetes#98238
    • [x] Docs (k/website) update PR(s): kubernetes/website#28841
  • [x] Beta

    • [x] KEP (k/enhancements) update PR(s): #2874
    • [x] Code (k/k) update PR(s): kubernetes/kubernetes#105197 kubernetes/kubernetes#105687
    • [x] Docs (k/website) update(s): kubernetes/website#30423

/sig apps

alculquicondor avatar Jan 21 '21 19:01 alculquicondor

/sig apps

alculquicondor avatar Jan 21 '21 19:01 alculquicondor

/assign

alculquicondor avatar Feb 05 '21 21:02 alculquicondor

It looks like #2232 is almost there. Once it merges, we would have very little time to handle conflicts and go through reviews. So we would likely be deferring this enhancement to 1.22.

cc @ahg-g @soltysh

alculquicondor avatar Mar 04 '21 20:03 alculquicondor

/milestone v1.22

ahg-g avatar May 05 '21 00:05 ahg-g

@alculquicondor can you update the links to the merged KEP and the open implementation PRs please

ahg-g avatar May 05 '21 00:05 ahg-g

Hi @alculquicondor 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In KEP.yaml, latest-milestone has not been updated
  • In KEP.yaml, milestone (alpha: v1.21, beta: v1.22) doesn't match your current stage

Thanks!

gracenng avatar May 09 '21 17:05 gracenng

Hi @gracenng, it is up to date https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/2307-job-tracking-without-lingering-pods/kep.yaml Perhaps you missed the last PR?

alculquicondor avatar May 10 '21 13:05 alculquicondor

My apologies @alculquicondor, I did miss that PR. I've updated Enhancement track sheet and this issue is no longer at risk.

gracenng avatar May 10 '21 15:05 gracenng

Hi @alculquicondor 👋 1.22 Enhancements shadow here. I just wanted to check to see if SIG-Apps will need to do anything for this enhancement and if so, are they OK with it? Thanks!

gracenng avatar May 11 '21 12:05 gracenng

Yup, sig-apps is aware and tracking this development.

soltysh avatar May 11 '21 12:05 soltysh

Hi @alculquicondor ! I'm @chrisnegus , a Docs Shadow for release 1.22. This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

chrisnegus avatar May 19 '21 20:05 chrisnegus

Hi @alculquicondor 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as k/k#98238 has not been merged.

Please let me know if there is other code PR associated with this enhancement and feel free to ping me once its merged.

Thanks

gracenng avatar Jun 23 '21 12:06 gracenng

Thanks Grace. The PR is approved by the SIG, but still awaiting for api-review. There are no more PRs.

alculquicondor avatar Jun 23 '21 15:06 alculquicondor

Hi @alculquicondor 🌷 1.22 enhancements shadow here.

A friendly reminder that Code Freeze is tomorrow, on July 8th. Please also be mindful of the docs PR deadline on July 9th

Thanks

gracenng avatar Jul 07 '21 12:07 gracenng

Hey @alculquicondor, v1.22 Enhancements Lead here. We had this enhancement marked as "at risk" going into code freeze, but were satisfied that https://github.com/kubernetes/kubernetes/pull/98238 was approved and just awaiting merge, which it has now done.

However I see you've got a new k/k PR open now though in https://github.com/kubernetes/kubernetes/pull/103644. Can you confirm if this PR is intended for v1.22 (which would require an exception request at this stage as we have passed code freeze) or if this is intended for future development?

JamesLaverack avatar Jul 12 '21 17:07 JamesLaverack

Hi, kubernetes/kubernetes#103644 is a potential bugfix, which is awaiting for confirmation from sig-scalability

AFAIK, bugfixes are exempt from code freeze. Is that correct?

alculquicondor avatar Jul 12 '21 17:07 alculquicondor

/milestone v1.23

salaxander avatar Sep 01 '21 15:09 salaxander

Hi @alculquicondor :wave: 1.23 Docs lead here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

jlbutler avatar Sep 22 '21 17:09 jlbutler

Hi @alculquicondor, 1.23 Enhancements Shadow here 🌻

Looks like all PR's related to this enhancements have been merged and ready for Code Freeze on November 16th.

Please update the description and let me know if there is any unmerged code PR related to this enhancements.

Thanks!

gracenng avatar Nov 09 '21 02:11 gracenng

I updated the description Grace. I still have pending to submit a website update.

alculquicondor avatar Nov 09 '21 14:11 alculquicondor

Related Doc PR to k/website for 1.23 https://github.com/kubernetes/website/pull/30423

reylejano avatar Nov 10 '21 00:11 reylejano

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 09 '22 18:04 k8s-triage-robot

/remove-lifecycle stale

I plan to graduate to GA in 1.25

alculquicondor avatar Apr 11 '22 13:04 alculquicondor

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 04 '22 16:08 k8s-triage-robot

/remove-lifecycle stale

ahg-g avatar Aug 05 '22 17:08 ahg-g

/lead-opted-in

soltysh avatar Sep 13 '22 20:09 soltysh

@soltysh try /label lead-opted-in

reylejano avatar Sep 13 '22 21:09 reylejano

/label lead-opted-in

soltysh avatar Sep 14 '22 05:09 soltysh

/stage stable

soltysh avatar Sep 14 '22 05:09 soltysh

/milestone v1.26

rhockenbury avatar Sep 18 '22 19:09 rhockenbury