Node log query

[aravindhp]

Enhancement Description

• Add a kubelet API for viewing logs of system services on nodes

• Kubernetes Enhancement Proposal: KEP-2258: Node log query

• Discussion Link: https://kubernetes.slack.com/archives/C0SJ4AFB7/p1610055846236600

• Primary contact (assignee): @aravindhp

• Responsible SIGs: sig-windows

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y): 1.27
  • Beta release target (x.y): 1.30
  • Stable release target (x.y): 1.32

• [x] Alpha

  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/2271
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes/kubernetes/pull/96120
  • [x] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/40003

• [ ] Beta

  • [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4480
  • [x] Code (k/k) update PR(s):
    • https://github.com/kubernetes/kubernetes/pull/120678
    • https://github.com/kubernetes/kubernetes/pull/121707
    • https://github.com/kubernetes/kubernetes/pull/122240
    • https://github.com/kubernetes/kubernetes/pull/122594
    • https://github.com/kubernetes/kubernetes/pull/123205
  • [x] Docs:
    • https://github.com/kubernetes/website/pull/45126
  • [x] kubectl plugin: kubectl-node-logs

[aravindhp]

/cc @LorbusChris @marosset @immuzz /sig windows

[dougsland]

/cc

[annajung]

Hi @aravindhp

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR https://github.com/kubernetes/enhancements/pull/2271/). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

• [IN PROGRESS] The KEP must be merged in an implementable state
• [IN PROGRESS] The KEP must have test plans
• [IN PROGRESS] The KEP must have graduation criteria
• [IN PROGRESS] The KEP must have a production readiness review

[aravindhp]

@annajung #2271 has the following completed: [IN PROGRESS] The KEP must have test plans [IN PROGRESS] The KEP must have graduation criteria [IN PROGRESS] The KEP must have a production readiness review (I need update the check mark but it has been /approved for PRR) Is there a reason for it to be marked IN PROGRESS?

[annajung]

@aravindhp We consider it in progress until PR merges. Even if you have a PR open for the change, if it doesn't merge before the enhancements freeze, this enhancement is at risk of not making it into the release.

[aravindhp]

Thanks for the clarification @annajung. We are waiting for LGTMs from sig-node and sig-auth to merge.

[annajung]

Hi @aravindhp,

Enhancements Freeze is now in effect.

Unfortunately, your KEP needed to be updated and the PR has not yet merged. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

[immuzz]

This is very much needed especially for scenarios where you need to access host like gMSA for Windows Containers. Cant wait to see this land soon

[salaxander]

Hi @aravindhp , 1.22 enhancements team here!

For the enhancement to be included in the milestone, it must meet the following criteria:

[DONE] ~~The KEP must be merged in an implementable state~~ [DONE] ~~The KEP must have test plans~~ [DONE] ~~The KEP must have graduation criteria~~ [DONE] ~~The KEP must have a production readiness review~~

Looks like we're in good shape for enhancements freeze on 5/13. Let us know if there's anything we can do to help before then!

Thanks!!

[salaxander]

Hey @aravindhp - Just checking in as we're about 2 weeks away from 1.22 code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!

[aravindhp]

@salaxander, I have a WIP PR: https://github.com/kubernetes/kubernetes/pull/96120. But it is looking very tight at this point.

[salaxander]

Hi @aravindhp - One more check-in as we're a week out from code freeze. Any updates on if you expect https://github.com/kubernetes/kubernetes/pull/96120 to merge before the deadline?

Thanks!

[LorbusChris]

By now, I don't think it's reasonable to assume it will make it in in time. We will circle back to this in the next Dev window.

[marosset]

/milestone clear

[salaxander]

/milestone v1.23

[salaxander]

Hi @aravindhp! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

• ~~[x ] KEP file using the latest template has been merged into the k/enhancements repo.~~
• ~~[x ] KEP status is marked as implementable~~
• ~~[ x] KEP has a test plan section filled out.~~
• ~~[ x] KEP has up to date graduation criteria.~~
• ~~[ x] KEP has a production readiness review that has been completed and merged into k/enhancements.~~

Looks like you're all set for enhancements freeze

Thanks!

[mehabhalodiya]

Hi @aravindhp :wave: 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[ehashman]

Is this the PR for alpha? https://github.com/kubernetes/kubernetes/pull/96120

[aravindhp]

Yes it is for alpha ~but it will not make the cut for 1.23.~

[aravindhp]

Yes it is for alpha ~but it will not make the cut for 1.23.~

I misunderstood the sig-node PR review deadline for alpha features. Thanks you for clarifying @ehashman

[salaxander]

Hi @aravindhp 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.
• Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

[salaxander]

Hi @aravindhp - checking in one more time since today is code freeze. Looks like there are k/k PRs that haven't yet merged? Could you provide links to all the PRs associated with the KEP?

[LorbusChris]

@salaxander the PR is https://github.com/kubernetes/kubernetes/pull/96120. I probably should've posted here what I wrote there yesterday:

This still needs testing for the kubectl changes, and isn't realistically getting into v1.23 now.

[salaxander]

@LorbusChris thanks for the update. I'll remove this one from the milestone for now and if you'd like to file a code freeze exception request later that's totally fine :)

/milestone clear

[Priyankasaggu11929]

Hello @aravindhp 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

This enhancement is targeting for stage beta for 1.24, is that correct?

Here’s where this enhancement currently stands:

• [X] Updated KEP file using the latest template has been merged into the k/enhancements repo.
• [X] KEP status is marked as implementable for this release
• [X] KEP has a test plan section filled out.
• [X] KEP has up to date graduation criteria.
• [x] KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

• update the merged KEP's kep.yaml to reflect the current stage and latest-milestone.
• (if graduating to stage beta), this enhancement require a production readiness review (PRR) approval for stage beta.

At the moment, the status of this enhancement is marked as at-risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[LorbusChris]

@Priyankasaggu11929 I believe this is targeting alpha for 1.24 now.

[Priyankasaggu11929]

Thanks @LorbusChris for the clarification!

I believe this is targeting alpha for 1.24 now.

For note, I'll update the enhancement's target stage to alpha in the 1.24 enhancements tracking sheet.

[Priyankasaggu11929]

All of the above criteria are satisfied now that the KEP PR https://github.com/kubernetes/enhancements/pull/3154 has been merged. This enhancement is ready for the upcoming 1.24 enhancements freeze. 🚀

For note, the status of this enhancement is now tracked. Thank you so much!

[PI-Victor]

Hi @LorbusChris :wave: 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[LorbusChris]

Thanks @PI-Victor, @aravindhp and I will make sure to open the PR in time.